From: Joe Lawrence <joe.lawrence@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
x86@kernel.org, Jiri Slaby <jslaby@suse.cz>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH] x86/stacktrace: export save_stack_trace_tsk_reliable
Date: Wed, 27 Feb 2019 17:25:18 -0500 [thread overview]
Message-ID: <07491738-dfdb-deb4-7e25-f1c173dda773@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1902272219160.1644@nanos.tec.linutronix.de>
On 2/27/19 4:31 PM, Thomas Gleixner wrote:
> On Wed, 27 Feb 2019, Joe Lawrence wrote:
>
>> The ppc64le implementation of save_stack_trace_tsk_reliable() is
>> exported, so do the same with x86.
>
> And what's the in tree module user of this? I can't find one and just
> because PPC has an export with no user is not a convincing argument to add
> another one. The proper solution is to remove the unused PPC export.
>
Good point.
For that matter, I do see in-tree modules making use of
save_stack_trace, but who is calling save_stack_trace_tsk (exported by
most arches) and save_stack_trace_regs (exported by openrisc, powerpc,
s390)?
-- Joe
next prev parent reply other threads:[~2019-02-27 22:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 21:17 Joe Lawrence
2019-02-27 21:31 ` Thomas Gleixner
2019-02-27 22:25 ` Joe Lawrence [this message]
2019-02-27 23:20 ` Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07491738-dfdb-deb4-7e25-f1c173dda773@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®