mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Niedermayr, BENEDIKT" <benedikt.niedermayr@siemens.com>,
	"zev@bewilderbeest.net" <zev@bewilderbeest.net>,
	"jdelvare@suse.com" <jdelvare@suse.com>
Cc: "Lopes Ivo, Diogo Miguel" <diogo.ivo@siemens.com>,
	"Kiszka, Jan" <jan.kiszka@siemens.com>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Question about nct6775 regarding MFD
Date: Mon, 16 Jun 2025 05:14:48 -0700	[thread overview]
Message-ID: <074a2561-1c9b-4138-9ade-bdd1b34825f2@roeck-us.net> (raw)
In-Reply-To: <a0164db0-e234-44ac-8584-a14f0b625181@siemens.com>

On 6/16/25 03:34, Niedermayr, BENEDIKT wrote:
> Hi folks,
> 
> we are currently refactoring some parts of the
> "drivers/platform/x86/siemens/*" which has references to some
> 
> Nuvoton Super-I/O chips. One of them is the nct6775.
> 
> The driver in question is not implemented as MFD, even though MFD would
> have fit perfectly for it (or am I wrong?).
> 
> 
> My question now:
> 
> Why wasn't the driver implemented as an MFD? Was MFD discussed during
> your upstreaming-related conversations?
> 

Super-IO chips have historically not been implemented as MFD since the functionality
is well separated except for configuration register access, and that is well handled
with the various superio_enter() functions which use a multiplexed memory region
to (temporarily) request chip access. Implementing those drivers as MFD would only
add complexity with no gain or benefit.

Guenter


  reply	other threads:[~2025-06-16 12:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 10:34 Niedermayr, BENEDIKT
2025-06-16 12:14 ` Guenter Roeck [this message]
2025-06-16 14:48   ` Niedermayr, BENEDIKT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=074a2561-1c9b-4138-9ade-bdd1b34825f2@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=benedikt.niedermayr@siemens.com \
    --cc=diogo.ivo@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zev@bewilderbeest.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®