mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	lee.jones@linaro.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	johnson.wang@mediatek.com, hsin-hsiung.wang@mediatek.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys
Date: Fri, 17 Jun 2022 11:17:11 +0200	[thread overview]
Message-ID: <074b6829-c5c1-d3fa-d4b9-8b0ba001eabe@gmail.com> (raw)
In-Reply-To: <20220616091531.12646-2-angelogioacchino.delregno@collabora.com>



On 16/06/2022 11:15, AngeloGioacchino Del Regno wrote:
> The MT6331 PMIC provides many sub modules: regulators, audio
> codec, LED controller, keys, RTC and some GPIOs.
> It is always paired with a MT6332 Companion PMIC, which provides
> thermistors, WLEDs (display LED backlight), secondary AP cluster
> regulators, modem clocks, battery charger and fuel gauge.
> 
> Add the necessary compatibles to start implementing the basics.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   Documentation/devicetree/bindings/mfd/mt6397.txt | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
> index 293db2a71ef2..f637bee2f3eb 100644
> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt
> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
> @@ -29,6 +29,7 @@ Optional subnodes:
>   - rtc
>   	Required properties: Should be one of follows
>   		- compatible: "mediatek,mt6323-rtc"
> +		- compatible: "mediatek,mt6331-rtc"
>   		- compatible: "mediatek,mt6358-rtc"
>   		- compatible: "mediatek,mt6397-rtc"
>   	For details, see ../rtc/rtc-mt6397.txt
> @@ -52,8 +53,10 @@ Optional subnodes:
>   	see ../leds/leds-mt6323.txt
>   
>   - keys
> -	Required properties:
> -		- compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys"
> +	Required properties: Should be one of the following
> +		- compatible: "mediatek,mt6323-keys"
> +		- compatible: "mediatek,mt6331-keys"
> +		- compatible: "mediatek,mt6397-keys"
>   	see ../input/mtk-pmic-keys.txt
>   
>   - power-controller

  parent reply	other threads:[~2022-06-17  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  9:15 [PATCH v2 0/2] MediaTek Helio X10 MT6795 - MT6331/6332 PMIC MFD integration AngeloGioacchino Del Regno
2022-06-16  9:15 ` [PATCH v2 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys AngeloGioacchino Del Regno
2022-06-16 13:51   ` Krzysztof Kozlowski
2022-06-17  9:17   ` Matthias Brugger [this message]
2022-06-16  9:15 ` [PATCH v2 2/2] mfd: mt6397: Add basic support for MT6331+MT6332 PMIC AngeloGioacchino Del Regno
2022-06-17 10:12   ` Matthias Brugger
2022-06-17 10:43     ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=074b6829-c5c1-d3fa-d4b9-8b0ba001eabe@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hsin-hsiung.wang@mediatek.com \
    --cc=johnson.wang@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome