From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Chris Lew <quic_clew@quicinc.com>
Cc: Alex Elder <elder@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 1/4] soc: qcom: aoss: Move length requirements from caller
Date: Sat, 12 Aug 2023 12:53:07 +0200 [thread overview]
Message-ID: <074d2bf6-1f89-4ec9-80de-52deeb1c319f@linaro.org> (raw)
In-Reply-To: <20230811205839.727373-2-quic_bjorande@quicinc.com>
On 11.08.2023 22:58, Bjorn Andersson wrote:
> The existing implementation of qmp_send() requires the caller to provide
> a buffer which is of word-aligned. The underlying reason for this is
> that message ram only supports word accesses, but pushing this
> requirement onto the clients results in the same boiler plate code
> sprinkled in every call site.
>
> By using a temporary buffer in qmp_send() we can hide the underlying
> hardware limitations from the clients and allow them to pass their
> NUL-terminates C string directly.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2023-08-12 10:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 20:58 [PATCH v2 0/4] soc: qcom: aoss: Introduce debugfs interface and cleanup things Bjorn Andersson
2023-08-11 20:58 ` [PATCH v2 1/4] soc: qcom: aoss: Move length requirements from caller Bjorn Andersson
2023-08-12 10:53 ` Konrad Dybcio [this message]
2023-08-11 20:58 ` [PATCH v2 2/4] soc: qcom: aoss: Add debugfs interface for sending messages Bjorn Andersson
2023-08-11 21:01 ` Andrew Lunn
2023-08-11 23:32 ` Bjorn Andersson
2023-08-12 17:11 ` Andrew Lunn
2023-08-13 1:59 ` Stephen Hemminger
2023-08-11 23:36 ` Bjorn Andersson
2023-08-11 20:58 ` [PATCH v2 3/4] soc: qcom: aoss: Format string in qmp_send() Bjorn Andersson
2023-08-11 20:58 ` [PATCH v2 4/4] soc: qcom: aoss: Tidy up qmp_send() callers Bjorn Andersson
2023-08-14 2:33 ` (subset) [PATCH v2 0/4] soc: qcom: aoss: Introduce debugfs interface and cleanup things Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=074d2bf6-1f89-4ec9-80de-52deeb1c319f@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_clew@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®