From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24031C4332F for ; Thu, 22 Dec 2022 00:27:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234780AbiLVA1V (ORCPT ); Wed, 21 Dec 2022 19:27:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229742AbiLVA1R (ORCPT ); Wed, 21 Dec 2022 19:27:17 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31E332034C for ; Wed, 21 Dec 2022 16:27:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671668837; x=1703204837; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=jHQcEHSK0InmHnPsXM0Gx80tyPuqDCQXyyxjt9KKKBE=; b=eFxG1caUXXOZ19rXqHGaJGkZFG5HOHTZ/avXSdQ4gAcGk7rXU6gzEbqJ FgfyeoLJjqKoyX3D6foDLkJlxaojndLjeK4l6mYsvYUEyvaJMLlI6AffN P6Au238XqMaQ8eYpc7wdxIreM1Zma6kD5llmJmhNBTKLqlBs73BYDPy25 4Q3Yn9pSeY+kmR2DNSKsEMODgrPNEL8oMX98C/AOAAJrVYPwnld7wrkjQ 2F3Z6U3nVctM5GcIcUl/dIJjTwOSYFEOvwDOyVM/S3g3viCcghhEk4cts ux+ivd93flQ2Agl14xj8clo3Y30BxYld4tana2KiV45Uh2cgPTGm0xsRT w==; X-IronPort-AV: E=McAfee;i="6500,9779,10568"; a="299679563" X-IronPort-AV: E=Sophos;i="5.96,263,1665471600"; d="scan'208";a="299679563" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 16:27:16 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10568"; a="740360369" X-IronPort-AV: E=Sophos;i="5.96,263,1665471600"; d="scan'208";a="740360369" Received: from gaoyuanf-mobl.amr.corp.intel.com (HELO [10.212.85.133]) ([10.212.85.133]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 16:27:15 -0800 Message-ID: <07538266-ea40-389e-9e68-054822121e0b@linux.intel.com> Date: Wed, 21 Dec 2022 18:27:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH v2] ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier. Content-Language: en-US To: Ajye Huang Cc: Libin Yang , Liam Girdwood , Cezary Rojewski , Kai Vehmanen , ye xingchen , Peter Ujfalusi , Takashi Iwai , linux-kernel@vger.kernel.org, "balamurugan . c" , Mark Brown , Muralidhar Reddy , Ranjani Sridharan , Akihiko Odaki , David Lin , alsa-devel@alsa-project.org, Bard Liao , Brent Lu , Yong Zhi References: <20221216154938.9426-1-ajye_huang@compal.corp-partner.google.com> <9aa4bffd-bc7e-0e40-3063-5ce80b5fbe9a@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/21/22 17:30, Ajye Huang wrote: > Hi Pierre > > On Sat, Dec 17, 2022 at 1:37 AM Pierre-Louis Bossart > wrote: > >> >> Ok, thanks for the explanations. >> >> Acked-by: Pierre-Louis Bossart > > Yesterday, I saw Arnd Bergmann sent this patch "ASoC: Intel: > sof-nau8825: fix module alias overflow " for reducing the string to > prevent over length,https://patchwork.kernel.org/project/alsa-devel/patch/20221221132515.2363276-1-arnd@kernel.org/. > > so, I need to check with you, should my string need to change the > format style with his, even the my string does not over length , from > .drv_name = "adl_nau8318_nau8825" to .drv_name = "adl_nau8318_8825", > align with his format style? That would be more consistent indeed, no objections from me.