From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F5A727FB05 for ; Tue, 30 Dec 2025 05:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767074211; cv=none; b=WulC6W+kXHHQfVeTSJ9tGg7kVtYkMl/L3hvH0qcylmXCUk1Qgv9j/AjCam+JUE6jrOeD2Xv7ebfSJbSRcUJ+YN7vet2XBsWMUX6mxZE7c0ISoWjFUM7KqjWpxniRn0FvHmJi+mFCULUqVUfzb2q8Fturh5NjoOPvXM4WGjK/1eI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767074211; c=relaxed/simple; bh=L6H6gmBf1ZBdl0q5TYxz359VcOz9UUMQe1RMxC8Wzf0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nqi0GwOUx7L5vDCm0SpjZlwBfICqfD20L0V9yA1lp+j3fE5HjXGxBFz2FY6m0mUAKmV8E9CCW+1jsGxOgKdSoRjTBupYORBbE8I217aIfrKtETU77tkW3lsFtZgyVeQQPC8f2xNuav/J3BgmpMb+XC/OyPUA/GiWgk87xFMyg3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QcAE2BIY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HI2hIABf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QcAE2BIY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HI2hIABf" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BU01Iee322822 for ; Tue, 30 Dec 2025 05:56:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= i5EHtVYCCr/LDL6mIRC+UCLJkKZahagXsQnQDecKjrQ=; b=QcAE2BIYE+Yw2Md0 Teqf33rGqV8L46GhGoVELqIpuhNLjlZKDtbux0kWiXiZKA8FOxrLlpoIpRbZTk9B OmlCPQ8T/uLdZ4dIMxGt6NchTum7811pJTqHDNZcecC9bFBDygXME42hTyAmZnHP u1u0gSbwDoeMlGN5FCaU+cFetMr4KlgXpq20SnDHLdkEdEs+B3nsVyRfrKU2FUnF xi6vX/vhUN7/XdkIP+RghI9xYh2oltcMdnWm2jYmlJxyH6f1QPqopC16W+6Uld5N nZgkobWyUnejdyQ3vq+L3SYyTKnzNtk1Ad8wG3SK8fBiT6Znyp/xONihTQbDlcS3 0JygsA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bbc9v3gtx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 05:56:46 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-29f1f79d6afso140277445ad.0 for ; Mon, 29 Dec 2025 21:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767074206; x=1767679006; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=i5EHtVYCCr/LDL6mIRC+UCLJkKZahagXsQnQDecKjrQ=; b=HI2hIABfvufL3IxMqpKDhd56PKm8Bepiq3t7w5t1hfYsJTyZCZ3veIUZfPJ+gBvZgK 484mKF5P11qj5eME+W8yAh0A/ndO4b2hbAD1V7QU3pP6EeEhijIijhjT5u8cRVpa2fRp M5/pY1L3Q9YLwiza/O5cLfqHsFaZE4+3NrM+YTuvhJPOFaIUz26hOgkoMkIgWtbWoCwz fcF9XIJuoHEgkBzgVc6cq+zmQdH8gkIVXwY4BQV1wdVWKYHWYuEZdOhxNF+XZo0o0WHX B82kdZC/rtJBwWBMkAW/3/y6VVesfpY9n0Dd1Y4YZ/3zSfYFS+nc5U7E8wD3d+O5wi7I 200Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767074206; x=1767679006; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i5EHtVYCCr/LDL6mIRC+UCLJkKZahagXsQnQDecKjrQ=; b=udgQY447fThnA3mMlQA38kTuHisp2PENLpkUyvaqGXgryHCx1wKCVDkgvxaG4AdS+D Hp10eU+TY+5vDh+vR1Of+dt30n/paVwMVgoYQAjMSqxM7SX9ZS/lMijgDkDP7EMbMtvz o9hQR8+lyIs8rykUHxtA6mHfPPnFNWqI4uRIOgKJNcXHzMegY95hsr1dUqfXpNhRkcej 4GruVFG+SowEErBRbbx6GMOyyHvO04TQ94nqXFQNMzWYI3YSvBnkcz/nycDixlbPqWo0 ZGSHDRxBQNgnSGotYTTlqsbS1czA84hBGA6dN/Hv0IMdOHeQ2h2j6XdP6Arx9Rr4wedo BeqQ== X-Forwarded-Encrypted: i=1; AJvYcCVsf5hz7Ayqtwc5/45BhWtJGWssbwLa2fRduxtK7w4C07yt4rq4szDBY6WJF8o/J4nF4d/UBF0Kx/x1AvU=@vger.kernel.org X-Gm-Message-State: AOJu0YwZeis6Kok5ReKujIIKAfDp1GueWPsacvIPVrhAqiPcWdxUsBj0 Kbhm78DWC123g8hzmWEqt7R1kUjhPv0J7kQuuU758kHjp0eDFAYNVmqTU1UxrzAG4OFXR7ojpJ4 Wr8+ECE6Kzz0L4dK1bG3MbbDB9tNRMPPps+Q9SVZrCYr8nVPicIA7cD+2jyx292fd3Q0= X-Gm-Gg: AY/fxX6mIE39IdZn2Wj4dDVOIs/gR7myLbOuiQpYA1CNV4dYErzF+4fBYsmWKrnQitR oTUDTpEh8cNmrrSrgCDjAFJOXRQ8ubsrtdBm8PAzCvgPEZYI/rLABjLfN+Q3A+wWyI+hebGCvFI W0tIj0fse7N1YbpQwu1pGbzDz/BFBNb3SwaCzq4x/Q19vgwW0SoE6N9nlfZdxLKBpN2JeFgwRx0 R45q5Gtq29w8TWjK0ropghSFxydZ6ksGjORR2426GaNMi8k3n8tivbh9wohOERM4NOChuBvy3bA lQm5TltxO2vfICt8ZNpRR3l191qu1CsUT4VLQRkWm7GdpRbw3Hzk8jSuSg2wpOchlzubqu9d22e MhHLvV416BAKLYEYt69UAyIBG+INb9liDsjIJtzpBvw== X-Received: by 2002:a17:903:228b:b0:2a0:f0e2:94b7 with SMTP id d9443c01a7336-2a2f2735298mr294397815ad.30.1767074205636; Mon, 29 Dec 2025 21:56:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLFCVKUO/BC1akeZJ9O630BExjlkUKCBZABwyorRPspy4Bx8ohj8gEoXnF/Oji7nTuCtgvWw== X-Received: by 2002:a17:903:228b:b0:2a0:f0e2:94b7 with SMTP id d9443c01a7336-2a2f2735298mr294397595ad.30.1767074205137; Mon, 29 Dec 2025 21:56:45 -0800 (PST) Received: from [10.0.0.3] ([106.222.235.175]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d5d6e4sm288818205ad.75.2025.12.29.21.56.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 21:56:44 -0800 (PST) Message-ID: <0758caf0-c23d-8fd8-ab26-2c68e5f78f60@oss.qualcomm.com> Date: Tue, 30 Dec 2025 11:26:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 3/6] media: qcom: iris: Add B frames support for encoder Content-Language: en-US To: Wangao Wang , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: quic_qiweil@quicinc.com, Renjiang Han , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251219-batch2_iris_encoder_enhancements-v2-0-371f7fe24801@oss.qualcomm.com> <20251219-batch2_iris_encoder_enhancements-v2-3-371f7fe24801@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20251219-batch2_iris_encoder_enhancements-v2-3-371f7fe24801@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: f3iST1eOKKbObq8bWfU1bMbDuH3HVdN4 X-Authority-Analysis: v=2.4 cv=R/sO2NRX c=1 sm=1 tr=0 ts=6953699e cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=IzfGebrgPFzWcUWWzKPHyQ==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=jKdzUOJkW_5VvHNVDv8A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDA1MiBTYWx0ZWRfX+7Pa4PH4fl3r LDru1W7Wy9gRNavJugVGXL4S6TiB3rh7r9CnkWA6E3YVbpUDoMUpLZ6tEoBnNsemu3L/CAu79tP xiQ6EZ/415ldlMYnK6xWbyOfaDUGuc0k0pt02xmZMsNg3nERlRdjHWU0bApagQ7qYUsjf1lhEz3 QQ25EesJfEqYpsBr0vMDTzS7ogXzjbmJX18ccftj1/WtS8a6SgdfbpL/merPJ2vetSmA5utl7YF hya0wvvgSW0DVnFideSeHzlvsXRJ279/wgNemqd72OfEhwytYbjoq4g/khXhZ0idxxCKTe2kLz1 e6AyXslrhoDVJIZt6NyqAm/jyIlvaV+hPODfhionrtoIYGKL6QizIUuNA4LEBZDRvYswd7NlTYE xXWjQr/38/If0xJ08YDlqVeVYfJTjK4+zBncfClyL2daRrJ3ZjSgyqaJXNTi16uzz7LfvI8KV1f lPDtzQEH0MeafGOZkSQ== X-Proofpoint-ORIG-GUID: f3iST1eOKKbObq8bWfU1bMbDuH3HVdN4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_07,2025-12-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300052 On 12/19/2025 1:12 PM, Wangao Wang wrote: > Add support for B-frame configuration on both gen1 and gen2 encoders by > enabling V4L2_CID_MPEG_VIDEO_B_FRAMES control. > > Signed-off-by: Wangao Wang > --- > drivers/media/platform/qcom/iris/iris_ctrls.c | 30 ++++++++++++++++++++++ > drivers/media/platform/qcom/iris/iris_ctrls.h | 1 + > .../platform/qcom/iris/iris_hfi_gen1_command.c | 8 ++++++ > .../platform/qcom/iris/iris_hfi_gen1_defines.h | 10 ++++++++ > .../platform/qcom/iris/iris_platform_common.h | 2 ++ > .../media/platform/qcom/iris/iris_platform_gen1.c | 18 +++++++++++++ > .../media/platform/qcom/iris/iris_platform_gen2.c | 10 ++++++++ > drivers/media/platform/qcom/iris/iris_vpu_buffer.c | 6 ++++- > 8 files changed, 84 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index c48dfb6d47734fadd4f2e4123c93560f55355b86..34deb32eb5be0899fee779ff99b3f4b8bd91529f 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -154,6 +154,8 @@ enum platform_inst_fw_cap_type { > LTR_COUNT, > USE_LTR, > MARK_LTR, > + B_FRAME, > + INTRA_PERIOD, > INST_FW_CAP_MAX, > }; > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > index 13cee5f72a443b85136d30b41b589aeb0db8eb9a..78f3a44f4ef037a5291330627b3e94750b624f4d 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > @@ -279,6 +279,24 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8250_enc[] = { > .flags = CAP_FLAG_INPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED, > .set = iris_set_mark_ltr, > }, > + { > + .cap_id = B_FRAME, > + .min = 0, > + .max = 3, > + .step_or_mask = 1, > + .value = 0, > + .flags = CAP_FLAG_OUTPUT_PORT, > + }, > + { > + .cap_id = INTRA_PERIOD, > + .min = 0, > + .max = 1, > + .step_or_mask = 1, > + .value = 0, > + .hfi_id = HFI_PROPERTY_CONFIG_VENC_INTRA_PERIOD, > + .flags = CAP_FLAG_OUTPUT_PORT, > + .set = iris_set_intra_period, > + }, > }; is this not needed for gen2? > > static struct platform_inst_caps platform_inst_cap_sm8250 = { > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index 99d8e1e59e6bfd5e4ab0fd2b5831f74c54b6e87d..56b6a73bff8ae8e1da06a7b53632712932abe5bb 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -667,6 +667,16 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_enc[] = { > .flags = CAP_FLAG_INPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED, > .set = iris_set_use_and_mark_ltr, > }, > + { > + .cap_id = B_FRAME, > + .min = 0, > + .max = 1, > + .step_or_mask = 1, > + .value = 0, > + .hfi_id = HFI_PROP_MAX_B_FRAMES, > + .flags = CAP_FLAG_OUTPUT_PORT, > + .set = iris_set_u32, > + }, > }; >