From: Daniel Borkmann <daniel@iogearbox.net>
To: Greg Thelen <gthelen@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore
Date: Thu, 16 Mar 2023 22:10:59 +0100 [thread overview]
Message-ID: <075bcfa1-8b9a-3d0c-4db2-3772491225c2@iogearbox.net> (raw)
In-Reply-To: <20230315054932.1639169-1-gthelen@google.com>
On 3/15/23 6:49 AM, Greg Thelen wrote:
> After building the kernel I see:
> $ git status -s
> ?? tools/bpf/resolve_btfids/libbpf/
>
> Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> started copying header files into
> tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are
> not covered by higher level wildcard gitignores.
>
> gitignore the entire libsubcmd directory. It's created as part of build
> and removed by clean.
>
> Fixes: af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> Signed-off-by: Greg Thelen <gthelen@google.com>
Already fixed in bpf-next by:
commit fd4cb29f2a3d54ec7b4e012300321601af10bd68
Author: Rong Tao <rongtao@cestc.cn>
Date: Sat Mar 4 23:17:04 2023 +0800
tools/resolve_btfids: Add /libsubcmd to .gitignore
Thanks,
Daniel
prev parent reply other threads:[~2023-03-16 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 5:49 Greg Thelen
2023-03-15 21:20 ` John Fastabend
2023-03-15 21:20 ` Ian Rogers
2023-03-16 21:10 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=075bcfa1-8b9a-3d0c-4db2-3772491225c2@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=gthelen@google.com \
--cc=haoluo@google.com \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®