Re: [PATCH v3] xen: Remove dependency between pciback and privcmd

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1217 bytes --]

On 12.10.24 04:36, Chen, Jiqian wrote:
> On 2024/10/12 10:22, Chen, Jiqian wrote:
>> On 2024/10/11 20:06, Juergen Gross wrote:
>>> On 11.10.24 05:42, Jiqian Chen wrote:
>>>> Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev")
>>>> adds a weak reverse dependency to the config XEN_PRIVCMD definition, that
>>>> dependency causes xen-privcmd can't be loaded on domU, because dependent
>>>> xen-pciback isn't always be loaded successfully on domU.
>>>>
>>>> To solve above problem, remove that dependency, and do not call
>>>> pcistub_get_gsi_from_sbdf() directly, instead add a hook in
>>>> drivers/xen/apci.c, xen-pciback register the real call function, then in
>>>> privcmd_ioctl_pcidev_get_gsi call that hook.
>>>>
>>>> Fixes: 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev")
>>>> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
>>>> Signed-off-by: Jiqian Chen <Jiqian.Chen@amd.com>
>>>
>>> Unfortunately I'm seeing a build breakage for the 32-bit x86 build.
> Could you please attach the link or steps?
> Then I can reproduce it, and validate it locally with new changes.

I'm using the attached kernel config.


Juergen


[-- Attachment #1.1.2: .config --]
[-- Type: application/x-config, Size: 144408 bytes --]

[-- Attachment #1.1.3: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 491 bytes --]