From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FE541A38F9 for ; Fri, 12 Jun 2026 04:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781239255; cv=none; b=S0MPDtLn04Ol/En6vCk7HaoW7vjHed1hK47dTBYRCRXPmSSsOFhlgoa6x9fOwoxO2aUnk66BBw9fp6jUMkNE3ysShqfpR47NWIQ7moB4/pfx6ARibJZNLNLc33B6fp28O2Uq8rM9WooHYDzutICjt2TzO51VE2r5FYiQ/pnXZVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781239255; c=relaxed/simple; bh=/Y60YSoDMBhPFLKh0PrNpBU6l5qOYQX41POXnzHdOPI=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=o04jETH3VVGKL7C9s+O0Sse3fkUhfYOuOYylJGjLx6x2As9ZWhaVzd+v7QKCpKDC4UFcwGaTzcpBCMV+iqbHIzHyo2wrf7wgPPRgADs6i75yvZjF56pOxfCC2TrJ3AAvMxGQ7tkeSpZUSC65/vrBWhq8AG7AG3icW8Q+SPOCwNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dNPJ/s1t; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dNPJ/s1t" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-396753f343aso5241771fa.2 for ; Thu, 11 Jun 2026 21:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781239252; x=1781844052; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=vJcAf7LIH4TJaGZDb7GZo/dGpM4PHaBR77968ztms+I=; b=dNPJ/s1tnJ2PtfJB7O5FrbMyJ15ZKtrbzDTB/9ZZmS55zdvGRa7B+aPq4SKc0TfVLg TCFgRHqayEqWZayXsw5SI1f3R/tJT8e4guBtFMss/94/dcyvK6dSCWGVnIkRwqyP4XQe TqH2txc81UgXCNo97dbGfYXTHHxqXq0rJeUksvp9KWZNwjj0rfzZKXE90IjQfxTFB9uE l+/zyNG57aZWLz+zQI677dW3nAu5XJQXhNJAQyNpTDbvmpbMF/RnBo14A3adMnYz6oYK wH9boh/tEQEB587l9azhOolja8XcqxhWofzmrUjtCwp7HGZhmt91qK5VbvssJwX15zzJ meqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781239252; x=1781844052; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vJcAf7LIH4TJaGZDb7GZo/dGpM4PHaBR77968ztms+I=; b=oIVsMrybwumxM6DUQoFuUyl5kLe37vnh0Aoy8yVARVbyfT12tr/QGDoTXZ93Buf7Og oDzFl7ANnI8mRO2PqXsPN/gjCw1W5TyJULBxPrB0vqMGApcZZm2OFzo2lXt3YNHdBzyD HOxTL2dw1Ku5ajtCOsWdIOfGwDEaPkcoTu0/Kh+2a8y9XVsvQ7RFElAKxIsj6qsYobnA TRD2fSiDjeuoJ1ULenLhjJ+/0JAxArBC/v5UKfQCsu8ukPgc0WxWXanBowC2+MZciE1W sI2jKakicuZazu6sd1JqVN1snDxBJdA72AHXYkuCbzwRoPFSswNdWMo1Gl9/fZ7KsMit 5Zow== X-Forwarded-Encrypted: i=1; AFNElJ/nw0wNeeIrjMzczjhE7TzLGqTlIZ0PxPKmHFq8nKiS9Jk/K0i6EVhPvjNPqwzVBOkr6H/3QeLeBs4Za+Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8UkTYkK2OvA4pyO/Y1/urmhvZgXednDSyB8wiwmshsv7ZI8Ot EVY0CqdfoDCpZfdpdNA/BrDX3iYG+Kr63RA67jArYv3sIGDxyJ9rrwPIWdkmb58E X-Gm-Gg: Acq92OHNtKPVTaWooZ4mac/LzqFOL2+PmtS1oUq9f20vwBGK/Z2ZBp3OjKq9A08ak4d wFDFH5xJbz5IKb0WZ5Fu0Of9D7TXIi7QyTWvkptIZkDmz8YZrJFb6Qy9ZLgm8FO4yVEUwc1j9mm 8iuwzieRJJmZDwYCtrVP/3ACeoZfLudVhJ5aWCudhqE991xLdk+pUCJgLBd6SW5RsxOySgFJ12a lIjIhSMOoL4GZb1HbPDPckrq3YQR1Dqgfh2Gbm8iAWdq37IwWwNgcPcu8EoP+8uuUJgghU1smpM yzNZc0+Ebq0m/5oBGr9CnoPu/Nt1htU1/z/ocessQeWmKr3dtEKaZr0efZxvmxZMTHPWk6vSaHq kGyMXnDWqEbxSPritqOKxSAzrKMsAN1xCH/pr0e2zTv2brIx5zB0nPCBMn3nKc15zKqu4QLKIFh bT9ysTvT7ayGWUZ8n0aqiF6NdoE1B3yQZ44BXkqSfCXz3uvXKKYrfietPf8XfNgxNZ6vz6HYGC9 P526mk0 X-Received: by 2002:a05:6512:10d3:b0:5aa:753c:d8b6 with SMTP id 2adb3069b0e04-5ad2dab3c37mr403983e87.0.1781239252003; Thu, 11 Jun 2026 21:40:52 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e1adedesm182675e87.57.2026.06.11.21.40.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 21:40:50 -0700 (PDT) Message-ID: <075d48b7-5cb2-43a4-aacb-e11a9ac916a5@gmail.com> Date: Fri, 12 Jun 2026 07:40:49 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/2] rohm-bdi718x7/71828: Use software nodes for gpio-keys From: Matti Vaittinen To: Dmitry Torokhov , Lee Jones Cc: Arnd Bergmann , linux-kernel@vger.kernel.org References: <20260611-rohm-software-nodes-v5-0-0244664a3b65@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/06/2026 07:38, Matti Vaittinen wrote: > On 11/06/2026 18:48, Dmitry Torokhov wrote: >> Now that gpio-keys can use platform resources to identify interrupts >> assigned to buttons we can convert ROHM power buttons to use software >> nodes and device properties for configuration, removing the need to use >> platform data. >> >> Signed-off-by: Dmitry Torokhov > > ---> Changes in v5: >> Addressed Lee's comments: >> - moved static constants out of function to module level >> - added #defines for nodes' indexes >> - adjusted error message >> - renamed "error" to "ret" >> - dropped unneeded comments >> - Link to v4: https://patch.msgid.link/20260427-rohm-software-nodes- >> v4-0-ffeb5b0c4774@gmail.com > > I think I did already review these? Is there a reason my tags were dropped? "These" referring to these patches, not the v5 changes (which seem minor to drop the tags). Furthermore, is there a reason I was not CC'd? Especially if there was a reason to drop the tags. -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~