mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <amber.kao@ite.com.tw>
To: <krzk@kernel.org>, <ite_pd@ite.com.tw>
Cc: <jeson.yang@ite.com.tw>, <Yaode.Fang@ite.com.tw>,
	<gregkh@linuxfoundation.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<heikki.krogerus@linux.intel.com>, <linux-usb@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] usb: typec: ucsi: itepd: Add DisplayPort alternate mode support
Date: Wed, 16 Sep 2026 09:59:39 +0000	[thread overview]
Message-ID: <075d62e2b252455fb236036b9e0210dc@ite.com.tw> (raw)
In-Reply-To: <20260913-agile-tacky-mayfly-7a0ff3@quoll>

On Sun, Sep 13, 2026 at 09:05:40AM +0000, Krzysztof Kozlowski wrote:
> >  static const struct of_device_id itepd_of_match_table[] = {
> >  	{ .compatible = "ite,it8851" },
> > +		{ .compatible = "ite,it5271" },
> 
> So devices are fully compatible?

Yes. The IT527x series shares the same programming interface as
IT8851/IT8853: same register map, same UCSI command path, and the
driver does not branch on the part number -- neither match entry
carries match data.

The integrated MUX/SBU on IT527x is transparent to the host. The mux
and retimer are resolved through the connector's OF graph, so a board
without an external mux simply has no port@2 and the same code path
does the right thing.

I will drop the "ite,it5271" entry in v2 and express the relationship
as a fallback in the binding instead, consistent with ite,it8853. I
will also update MODULE_DESCRIPTION to cover the IT527x series.

Thanks,
Amber

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org> 
Sent: Sunday, September 13, 2026 5:06 PM
To: ITE_PD <ite_pd@ite.com.tw>
Cc: Amber Kao (高鈺盈) <amber.kao@ite.com.tw>; Jeson Yang (楊志賢) <jeson.yang@ite.com.tw>; Yaode Fang (方耀德) <Yaode.Fang@ite.com.tw>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Heikki Krogerus <heikki.krogerus@linux.intel.com>; linux-usb@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: typec: ucsi: itepd: Add DisplayPort alternate mode support

On Fri, Sep 11, 2026 at 06:17:58PM +0800, Amber Kao wrote:
> +	ret = itepd_bridges_add(itepd);
> +	if (ret)
> +		goto out_ucsi_unregister;
> +
>  	return 0;
>  
> +out_ucsi_unregister:
> +	ucsi_unregister(itepd->ucsi);
>  out_free_irq:
>  	free_irq(client->irq, itepd);
>  out_ucsi_destroy:
> @@ -330,6 +715,7 @@ static void itepd_remove(struct i2c_client *client)
>  
>  static const struct of_device_id itepd_of_match_table[] = {
>  	{ .compatible = "ite,it8851" },
> +	{ .compatible = "ite,it5271" },

So devices are fully compatible?

Best regards,
Krzysztof


      reply	other threads:[~2026-09-16  9:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 10:17 [PATCH 0/2] usb: typec: ucsi: Add ITE IT5271 series and DisplayPort alt " Amber Kao
2026-09-11 10:17 ` [PATCH 1/2] dt-bindings: usb: ite,it8851: Add IT5271 series support Amber Kao
2026-09-13  9:07   ` Krzysztof Kozlowski
2026-09-16  9:59     ` amber.kao
2026-09-11 10:17 ` [PATCH 2/2] usb: typec: ucsi: itepd: Add DisplayPort alternate mode support Amber Kao
2026-09-13  9:05   ` Krzysztof Kozlowski
2026-09-16  9:59     ` amber.kao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=075d62e2b252455fb236036b9e0210dc@ite.com.tw \
    --to=amber.kao@ite.com.tw \
    --cc=Yaode.Fang@ite.com.tw \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=ite_pd@ite.com.tw \
    --cc=jeson.yang@ite.com.tw \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®