From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEBA5C001B0 for ; Mon, 14 Aug 2023 07:41:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234224AbjHNHlE (ORCPT ); Mon, 14 Aug 2023 03:41:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234198AbjHNHke (ORCPT ); Mon, 14 Aug 2023 03:40:34 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD815E73; Mon, 14 Aug 2023 00:40:30 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8CB125C0125; Mon, 14 Aug 2023 03:40:27 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 14 Aug 2023 03:40:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691998827; x=1692085227; bh=zhIr+YFny3Ax+nBYjcGNtxMTlKdI2p4qsam OFHm/fmU=; b=lQyzt8ZLnsC5Y4UD4rcO9dWLQemDrz7il2Mxuh11MQmaHw+tEBa WZDt4/Dez0EgliHQKAHWxE4olKashOAKJ6eUkT6FdeyTLJECyYPyhtI7i4Gqe5nF hXE6HrnSoZ6cNhxVj0CHKKmbmxhXFP2ByD0RE+1S1kRlkWJJZqH9l30gc508ss8m Fg1u3TpiwcMJJTDRRJr0uQBmB0QKwNWirPjXPTrv+Z3XSDNBykO6ibnWw6zyMfz4 7h0n5DQtmxjoUKRmRBuZcbHmWJz/yrIUe0B38slYIg2GDnRq3r3t1G+84c91JRXI 1sLrN+lAiojvZUzO0Ry+J6LnON2gDb4OI4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1691998827; x=1692085227; bh=zhIr+YFny3Ax+nBYjcGNtxMTlKdI2p4qsam OFHm/fmU=; b=ocFr0qDmiS9E5/sOvsP5cpWIFi/jWAZeosdutO/nXN7USaZsaWk y58ZvbAPa3S7o+UGyrYhowIRb1sAuz/9U+GsjxUJQAyE/XayHiVEvwJwgnVvEmQe k4FTPfXsOXc+nz+Xe2sNy0jtI2dz40sA7SfVHT84lGO/8bNHR9L4vZ/9gyp21Xsp 2ZKzxntQsMuRqJ1s6VUUbASKVBdXE42/CG5RiftQajbPvvPg5q5ofhTYxqlTmL/s WTIoamvXGGQwqbbhr6ON10dpRo291lnWNwmp8/tZ5NaKykQGuzYb+KZlwNxg3uOA 929mGr7RtvjAA9TdObEckQhGXE38FFv5J9w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddtfedguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepfffhvdejieelteeljeekgeegieevheelueehieehkeehgeekhfdtleek teevtefgnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E93C5B60089; Mon, 14 Aug 2023 03:40:26 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440 Mime-Version: 1.0 Message-Id: <075ff937-645e-41fe-87cd-0fa878dd6408@app.fastmail.com> In-Reply-To: <7aa516e1.1dfc.189f22149f6.Coremail.xingtong_wu@163.com> References: <20230811130948.2211800-1-arnd@kernel.org> <97764bad-7091-e9ed-6f49-d31861fc622f@linux.intel.com> <69fbdb7bb4d048bc9c5eb756bbf87f56@siemens.com> <7aa516e1.1dfc.189f22149f6.Coremail.xingtong_wu@163.com> Date: Mon, 14 Aug 2023 09:40:04 +0200 From: "Arnd Bergmann" To: "xingtong.wu" Cc: "xingtong.wu" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "Arnd Bergmann" , "Hans de Goede" , "Mark Gross" , "Nathan Chancellor" , "Nick Desaulniers" , "Tom Rix" , "Andy Shevchenko" , "Lee Jones" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, gerd.haeussler.ext@siemens.com, tobias.schaffner@siemens.com Subject: Re: FW: [PATCH] platform/x86/siemens: simatic-ipc: fix nonsensical condition Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14, 2023, at 05:40, xingtong.wu wrote: >>From: Arnd Bergmann =20 > >>Sent: Friday, August 11, 2023 11:02 PM >> >>Ok, I see. I missed those as there is hasn't been a new linux-next in = a few days. >> >>I suppose this one is also fixed then? >> >>WARNING: unmet direct dependencies detected for P2SB >> Depends on [n]: PCI [=3Dn] && X86 [=3Dy] >> Selected by [m]: >> - SIEMENS_SIMATIC_IPC_WDT [=3Dm] && WATCHDOG [=3Dy] && SIEMENS_SIMAT= IC_IPC [=3Dy] >>drivers/platform/x86/p2sb.c:68:9: error: call to undeclared function '= pci_scan_single_device'; ISO C99 and later do not support implicit funct= ion declarations [-Wimplicit-function-declaration] > > I=E2=80=99m pretty sure your .config file is error to compile the kern= el, > you must have changed the .config file manually, and there will be no > possibility that option SIEMENS_SIMATIC_IPC is [y] while PCI is [n]. > reason: > https://elixir.bootlin.com/linux/v6.5-rc6/source/drivers/platform/x86/= Kconfig#L1079 > > if the PCI option is [n], the "p2sb.c" should never compile pass. > > I suggest you make menuconfig to build kernel and check your .config > carefully. It was broken in linux-next by commit b72da71ce24b0 ("platform/x86: simatic-ipc: drop PCI runtime depends and header"), I sent a fix now. Arnd