From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5E1FC433F5 for ; Thu, 24 Mar 2022 09:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349350AbiCXJup (ORCPT ); Thu, 24 Mar 2022 05:50:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239549AbiCXJun (ORCPT ); Thu, 24 Mar 2022 05:50:43 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D15A84EF6F; Thu, 24 Mar 2022 02:49:11 -0700 (PDT) X-UUID: b52eb9a7d30c473c87e0d2785ec59a2c-20220324 X-UUID: b52eb9a7d30c473c87e0d2785ec59a2c-20220324 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 158482102; Thu, 24 Mar 2022 17:49:08 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 24 Mar 2022 17:49:07 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 24 Mar 2022 17:49:07 +0800 Message-ID: <076256c903e71137b4b4b2891388509ceb009dfa.camel@mediatek.com> Subject: Re: [PATCH 4/4] cpufreq: mediatek: add platform data and clean up voltage tracking logic From: Jia-Wei Chang To: Krzysztof Kozlowski , "Rafael J . Wysocki" , Viresh Kumar , "Rob Herring" , Liam Girdwood , "Mark Brown" , Matthias Brugger CC: , , , , , , , , , , , Jia-Wei Chang Date: Thu, 24 Mar 2022 17:49:07 +0800 In-Reply-To: References: <20220307122151.11666-1-jia-wei.chang@mediatek.com> <20220307122151.11666-5-jia-wei.chang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-03-07 at 20:03 +0100, Krzysztof Kozlowski wrote: > On 07/03/2022 13:21, Tim Chang wrote: > > 1. add required header files and remove unnecessary header files. > > 2. some soc needs different min/max voltage shift and voltage > > tracking > > attributes. make these variables into platform data to support > > future soc. > > 3. add need_voltage_tracking variable to platforma data. if true, > > it > > indicates soc is required to realize the voltage tracking > > between > > voltage of sram and voltage of cpu by software approach. > > otherwise, > > the voltage tracking is realized by hardware approach. > > 4. add opp frequency look-up function as mtk_cpufreq_get() and > > registered in cpufreq framework. > > 5. update voltage_tracking() logic and drv_init(). in drv_init(), > > it > > always sets highest opp voltage before return. it could prevent > > from > > high-freqeuncy-low-voltage issue if two or more clients using > > the > > same regulator. > > One change at a time. Sure, I will split the change and send one change in one commit. > > > > > Signed-off-by: Jia-Wei Chang < > > jia-wei.chang@mediatek.corp-partner.google.com> > > Your SoB does not match from field. I will update it for the whole series in next version. > > Best regards, > Krzysztof