From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.nearlyone.de (mail.nearlyone.de [49.12.199.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58AC5328243 for ; Wed, 8 Apr 2026 16:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.12.199.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775665286; cv=none; b=Viae5NwHdX3gwGxlUz9o5RTnzTOFQVJgAnrommZxZMdDFVJdk9n18qvHqqPDvEa9DLVaW5Bqny020Wn039ll492pkgFjcFPU/5VR1yx3FmEsf23XqusVKFty5lQF71sDRxRFOWFM6zJXvqTnEbvBge+PpXfg3QXdtkwx1q3/xWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775665286; c=relaxed/simple; bh=s0G61yPI2iK6qwgfz5zYRqjoWCDzd36yU/13n2vR4DE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mb91pICOzixHvCYL1sjDSy4fus4cFu0faDMH+OlAWT/gRwucDjYTsIKctqwO8KhOUe32JYo6ITJDbKgxLcgzT+C0qKKvTLGwjX+BD3zfhAdjhf+nZARWEV55VObCLi4f2iE3q25qtTeNbcgWQ5U0v6H++5egqQnqoP/oS+7vtaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=monom.org; spf=pass smtp.mailfrom=monom.org; dkim=pass (2048-bit key) header.d=monom.org header.i=@monom.org header.b=mRzhgaGO; arc=none smtp.client-ip=49.12.199.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=monom.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=monom.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=monom.org header.i=@monom.org header.b="mRzhgaGO" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id CC364E3A94; Wed, 8 Apr 2026 18:21:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monom.org; s=dkim; t=1775665275; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=33EaTuG0lOnu3JCCqENsBUzQ4rztEmObNIT+Q+NHz4s=; b=mRzhgaGOBELlN3uEaWZEOMy7gGbMTbHE4QywkpnEQb4kFip1OyuWXbWTTd7y59TAiDVmIb gB/qDFi6AlnH2T++YHu7zF1fvs4IIPbfDMBH3/EhHGdDCPLbElGqhFJIpJQI+gsGSrW0R9 6d36PWPw+ezcBckSMZ9jAUCYeqhuszN8nlVi75eflm+4w1HIDRoyV3W9wbX82zEL9ApFLI jM1y4jVYsmOYUOzfGUrNd/DTqIAfqY0ZTbxjfNy+2hpah63tbpZOxXU9ZexvNc+muiqxsT FA+Lb+nFydTzaNRnL1x3zu5gnEyNZMpTxB3Qa5IrOkGVkSS7Im+Y2XlFGvip/Q== Date: Wed, 8 Apr 2026 18:21:07 +0200 From: Daniel Wagner To: Daniel Wagner Cc: Keith Busch , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] nvme: expose TLS mode Message-ID: <076475db-0463-40b7-8ee3-5e85c05ae69a@nitrogen.local> References: <20260408-expose-tls-mode-v2-1-17a25aa414dc@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408-expose-tls-mode-v2-1-17a25aa414dc@kernel.org> X-Last-TLS-Session-Version: TLSv1.3 On Wed, Apr 08, 2026 at 05:40:36PM +0200, Daniel Wagner wrote: > As Hannes suggested, tls_mode is only visible when either --concat or --tls is > used. This avoids the 'none' string. I got the visibility condition wrong, this version uses opts->tls_key which is wrong, it should be opts->tls. v3 fixes this.