From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC6A73191BB for ; Sat, 25 Jul 2026 07:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784964767; cv=none; b=h783pXm37JzuLX14xVstowHqrtnB6CfmoFw6gntcRKarr57k6v91/9x9cVmcLn3MWkjRo2y3v870+G8khrIokFm6jjqVjakSir6gP9P44tZCHG4bZhnVYL9aJSvkHUoSxLFHhTxojW4BslrayjxWurMvlNvm8OvPQ3PmRmM9aB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784964767; c=relaxed/simple; bh=ISNiLlzbBIN1cNfO53+tFyj2q5vGd9wWiUFlb/jKmRM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZsaQratop9cap6jz1t0yx0FtSl7Y36376C9WqCFzlj/RNMrMBLqUBqECCE3VwawtKzuyF2VxYESZWj8H5/IohSsmtWMYn9kgcf5G92KOGfDX0tp6hRaMYqOkwcEUGcX+dskwwieWRCRvRKsQirQYfazgUZ4zq6YenfeXLRZCzkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fc6yUYsp; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fc6yUYsp" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5b2a1fd0ab0so92926e87.0 for ; Sat, 25 Jul 2026 00:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784964764; x=1785569564; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=SlGbODmTnTj5crUJcYH6Lgn3M5IBqL6iL2YhZzeM6GM=; b=fc6yUYspRSNyWFzJLMEibOCf1BrjE5PebqqMslxgMS0bICZ1vtemRQfps0JoSm9jPX DKoIcAu2wOayPbLA/0iFIYBF/nnh9VZpFp1iTna8vyr3TbBhDjtkvzu6MYxbS0GP3idS 2IKlF1aLqmzOBV2zD1parsXbHt7QkApft4ms6HdlRgRSi3PyEVRjpLGwtiTDWcxPDdTQ moXolm2K5G3BlZZgBJltx2ZARmxX3OKhAgE9a61iZnVW3rIR/Od+tv4chQjOOERw/BPy iy8n0wEsVH1m1Sfnyt/OSG7zmki/zQJHLdCFwpDGrRILcp+/VeYemfEZjxiIcA3jw6XS x5UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784964764; x=1785569564; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SlGbODmTnTj5crUJcYH6Lgn3M5IBqL6iL2YhZzeM6GM=; b=i61OZdvbvAwwBFRWBhdhjF4ayvDgHvZ/Ou8Ym7wN14O0gW6m6WFYkFMJjvl/Ic7U+w +YLCSKvBz1CUU9/OTku+se9y5g/I4AZNELrObEbTvqZaV3MXPzcMUlZW5GNr/Cz34VdS 9P1b01fm2Ohe0E9+juHrpW0YS1AXRzq/nGfiRxAB/J/GgKF9W/nFKvdQkNF5reoiwJ/r ss8xpouI6eyVfUAXu7rdr0A395qQPsAk2i3ry4Pe6d7VETkcAy8dGpAJ9rbW0VkD30Dh wCxyOcGVYMV+iHP8Ie9ebdAWTF+1HrMTxIZXP03rNdj10vvcejSUVa2b8bj5E/5UdxdI qEVg== X-Forwarded-Encrypted: i=1; AHgh+Rp+KgnwuYPDW5VxvMo11Zz7OthvFXUGcSBMBM3jRFTop/K59Z/ou1dOaKP9GsDkHDo0G4P4uZbJ/Ylh4oc=@vger.kernel.org X-Gm-Message-State: AOJu0Yysr+Yub+J4y1JSF4k2LFM1G6b57JAAleEahGM7byMq6/qyTMyd Pkbia+X1laZ9Tkr5CjpDjh3+vhUzHqllSJalVWo3jSjaXRpkN6VsWKqo9D52riiH55I= X-Gm-Gg: AR+sD11tMQKYzmgMwrroUhtDx7p5McAUNjD6d9rQ6P6NKeIqcMMvWERb84F9ga/ovPH FpSvlVhf3ivkL6bYngYRIAseIzgsoG8eZXchkr267HHMyU0REiXD8r09onsCvd7yKjLvXONVLiW zF+mdEuW26OKjAe9zJD6bSfJxJYuR4nKnTPTub5WVo+iSBmWJG4kkuTWayKfxQt7PhVZV5Mqd0Z vXcwgbmAmz8I1N2JHQwQCY2T8vfE0hmHwoD8kLxOCAIFuCHzsOSShy6YM9OJ5x9nkKO/OVotiW1 mloA+GGAABZw7YzSdNKaXCRQ0YZXUjvew88y7eSXa0weIBEj6WPT60Z/zWn7ZLoEu4pmZ2RFwmi hkaIey2vgkPr7f3ZzqGDbsou9eQGHxtEz0jyaCMyrURzRCDPj9cWkIgz7a1RpKwfVqPmkRV8nqq udf66yoLPM7hExvJky/rK8JrwI9TOvw2hKZcj+4gkU9RCBH6ygBHgmo/BJOkxGcC8TQb0= X-Received: by 2002:a05:6512:3c99:b0:5ae:cf48:bd37 with SMTP id 2adb3069b0e04-5b2c1b0201emr130838e87.1.1784964763762; Sat, 25 Jul 2026 00:32:43 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2be1d84fesm297418e87.47.2026.07.25.00.32.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jul 2026 00:32:42 -0700 (PDT) Message-ID: <0769346d-b49a-4043-a2fb-60c9e5f6b6cf@linaro.org> Date: Sat, 25 Jul 2026 10:32:41 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/17] media: i2c: os05b10: Update active format before adjusting framing controls To: Tarang Raval , sakari.ailus@linux.intel.com, mehdi.djait@linux.intel.com Cc: Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260718200912.16001-1-tarang.raval@siliconsignals.io> <20260718200912.16001-13-tarang.raval@siliconsignals.io> From: Vladimir Zapolskiy In-Reply-To: <20260718200912.16001-13-tarang.raval@siliconsignals.io> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/18/26 23:09, Tarang Raval wrote: > os05b10_set_pad_format() calls os05b10_set_framing_limits() before updating > the ACTIVE format. As a result, the VBLANK control handler uses the old > height when recalculating exposure limits, causing -ERANGE when switching > to a larger resolution. > > Update the ACTIVE format before adjusting framing controls so control > callbacks use the correct dimensions. > > Signed-off-by: Tarang Raval > --- > drivers/media/i2c/os05b10.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c > index d124db74766c..82a96081fe21 100644 > --- a/drivers/media/i2c/os05b10.c > +++ b/drivers/media/i2c/os05b10.c > @@ -907,14 +907,14 @@ static int os05b10_set_pad_format(struct v4l2_subdev *sd, > > format = v4l2_subdev_state_get_format(sd_state, 0); > > + *format = fmt->format; > + > if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) { > ret = os05b10_set_framing_limits(os05b10, mode); > if (ret) > return ret; > } > > - *format = fmt->format; > - > return 0; > } > Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir