From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D640397AE5 for ; Tue, 16 Jun 2026 07:40:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781595657; cv=none; b=PZ3ln6VCb9j1OLcKaNxqIJyND7ko9IeH5rUOIS4M4vVc38fgLGBYZS3hM4oBAobvpheDuecwbPi18XDBRTTKIwf9yKsd7uyK+E1trEZzM58k1y4yCKGVqP/Z5YzzK+Lw78g9QjzXv2KawvhUEGtqzQXQpg3SqB5Ea6wAqSSxl2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781595657; c=relaxed/simple; bh=1+UpSrsH/Ix8VCNeN6AUnYxCHtow2cQqT4Xr0O9yi74=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=XcfoPPYWNaqX4GSeQSoaEN6PVB24v8iBbYbxdjiUfHR9OfZVXrES5aI3KHgpfgAarYkbld+gLZ7YaayZ89bcbtA4hBamJHXdntuuj0FNTLNqis9daRMdrM+P107bOLhru6yTS3C1y4i3fRu/UnT1RctdAiE+AfPSj9nocGvvQLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LUoNmRyp; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LUoNmRyp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 380801F000E9; Tue, 16 Jun 2026 07:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781595656; bh=mHKTLAuwcY3e5jMqpY2/5BQURtTBfwyO9fzJIKibCMQ=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=LUoNmRyp1B4AF6jK+MpLlyn1Ng2ugnS8Pq751sU/oCjrQCEifuTr4/8rk+8CU+kHh EIG6n+81lS++i2oEsckVSNFI8PPX7O5Jd8TdIG/fS+N5tac2jTsOiBQQq+1dssyfXd ZV9e/HGyBlwKeyQOzJL5eutZdSltYfCXCPGBQS4RVb/A2Ub3vdOLFYgbIXpYT9y1JX vfbKqUwn6TwEw6M60TNKWShFRytdvHmdrTowCvqlMD5zUCIEqkMgC9mp21/XnQOb2y JSaiD3i9PFAIrP52yR7N3NJUWxV0aLY3ugfzxbw/nG15Ytym1RSYZyO61Su2yYPDa3 cejbjy7Z01FTQ== Message-ID: <076be691-398b-4365-a06b-9e290fa52a8e@kernel.org> Date: Tue, 16 Jun 2026 07:40:53 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] f2fs: use fscrypt_finalize_bounce_page() for cleanup To: Matthew Wilcox , Eric Biggers References: <20260615130822.2576088-1-chao@kernel.org> <20260615130822.2576088-5-chao@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/15/26 13:11, Matthew Wilcox wrote: > On Mon, Jun 15, 2026 at 09:08:21PM +0800, Chao Yu wrote: >> No logic changes. > > This seems like a step backwards. We should be looking to convert to > a future fscrypt_finalize_bounce_folio(), if anything. You're right, what do you think of this? From 533ee72170c2ad451097db926dd713d9fea442f9 Mon Sep 17 00:00:00 2001 From: Chao Yu Date: Fri, 26 Sep 2025 01:43:06 +0800 Subject: [PATCH] fscrypt,f2fs: introduce fscrypt_finalize_bounce_folio() for cleanup As part of the linux kernel's migration to folio-based APIs, introduce fscrypt_finalize_bounce_folio() as the folio equivalent of fscrypt_finalize_bounce_page(), and clean up f2fs codes with this new helper. Suggested-by: Matthew Wilcox Cc: Eric Biggers Signed-off-by: Chao Yu --- fs/f2fs/data.c | 7 +------ include/linux/fscrypt.h | 11 +++++++++++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index ac1cf4de3d62..e0fca6c60e34 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -362,12 +362,7 @@ static void f2fs_write_end_bio(struct bio *bio) struct folio *folio = fi.folio; enum count_type type; - if (fscrypt_is_bounce_folio(folio)) { - struct folio *io_folio = folio; - - folio = fscrypt_pagecache_folio(io_folio); - fscrypt_free_bounce_page(&io_folio->page); - } + fscrypt_finalize_bounce_folio(&folio); #ifdef CONFIG_F2FS_FS_COMPRESSION if (f2fs_is_compressed_page(folio)) { diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h index 54712ec61ffb..20b59b021c94 100644 --- a/include/linux/fscrypt.h +++ b/include/linux/fscrypt.h @@ -1132,4 +1132,15 @@ static inline void fscrypt_finalize_bounce_page(struct page **pagep) } } +/* If *foliop is a bounce folio, free it and set *foliop to the pagecache folio */ +static inline void fscrypt_finalize_bounce_folio(struct folio **foliop) +{ + struct folio *folio = *foliop; + + if (fscrypt_is_bounce_folio(folio)) { + *foliop = fscrypt_pagecache_folio(folio); + fscrypt_free_bounce_page(&folio->page); + } +} + #endif /* _LINUX_FSCRYPT_H */ -- 2.49.0