From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8AA13AC0C6 for ; Mon, 24 Aug 2026 05:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787551176; cv=none; b=eynwz0a6wRDt/k2HrT9dAd1HbRyQmTXgZY14HIm/5D5tQ6aqmMPw2Y0Uobsgcrwn3ip23pmpLy3WGsOKjd4TjbKvqQqylyRuEkM4TnwpnUS5hAfGw3uNQve8knM8D0KYsic0Blxf1d+Otd86H6tx9o9/9p4Mz6YTkDP1RUSEw3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787551176; c=relaxed/simple; bh=+qyQLvj4gN7luySg4ETkE23qZJgGuStSN2Wek5Dw/ao=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Byywfbyq15W3j/b9mkaSIy6FVBpV/v9X3SE1wYWNPhiNG5MzziKuBxUcwbte4Muj1xBY++5vOUA4X9iwfBvTzTxZyVGtAWqHyMZ4dRMAy7MWEh2EpkPCAqSG/wEmIE02MR5TdohTwfIXrpRfmvDa6SsqLkrJN1ZT+kMQ6DxI/ro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CO3JtPZZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OMyxKXxB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CO3JtPZZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OMyxKXxB" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67O5R5DR1477751 for ; Mon, 24 Aug 2026 05:59:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Zsj1FB3xuyBHeshQBDJjRvj44RjokWbqPIgy5SQ3Klc=; b=CO3JtPZZy9XfmjTA thRI+FrIgJ8Ftw0xeyVgmoNWTumaDjL5PShpC2w2Cffe6TG4CYlB5APsi8ZdX8dr e+5gp2p6LXpTPM49mO1gef5eVeE4nOPSSF/+f7WZdMYOGGXIjfTAwaGRZTHztI5m hEWQ7lcHxwSrvWBYvxdgP/PVaFUj5CtwfF3xx8PQc2AkNsJbUT6UZvwa0kpaGByZ HdNRfRD73w9Jhlb1gnwX8tBM3x3iX6UXoTSWmMKizU1/SJx1u3TQAajYxPk4YXjU elK20m/s9+87cxaJg4US0R1bcgtwVmzyIrGRP6JOsCqBCXFm1Are7vTVErnkf4S3 EJHCqw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g7528nc0e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 05:59:34 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38dbf293831so7633570a91.3 for ; Sun, 23 Aug 2026 22:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787551174; x=1788155974; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Zsj1FB3xuyBHeshQBDJjRvj44RjokWbqPIgy5SQ3Klc=; b=OMyxKXxBzSqoK63uPiVXnz5QpfY2MvMDUOTJyolVxTZeywcrU34D01ow+Yit5x+2Ll b4eluydtN5z6flDxL1DZaFSjiIvM7s2gR8QFhk0RFpiARzvgDsdjaOrLP4fOUNC3OTd1 2eRjin9sEfYQeHuuZ5NzJ6dClvR1UpvXwLuh9WGOw7ysrSSb3rJ8nxudfCsGtIWh+6Wt GDEQHTVGaZNVRjf8C82CxV13AXWn4Oi/891LNXcgDEm6iUepnU/T3/IDp5J03eFI/i7r /5rSE+hWp5wAKjfLj3iydT9Z3fn6mCwRDML0++L6AuCQvxyCs5A1UZQAVB5Hf3WEXVSO 0/3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787551174; x=1788155974; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Zsj1FB3xuyBHeshQBDJjRvj44RjokWbqPIgy5SQ3Klc=; b=RkRVaM6m3SMK0cS9aZ3C47j9nUog1DQLbMUo2kXalgftbFZo4N4KUTHWRMapl32/9+ tz/ttLohznz9UXIAQGjV8NYw3Whk/9upf+wOtVygspNtbEU+Jq6VSybDe+kAWpo2ymB0 mL3px5wEzLS/Hu/48wV6cQZUGbm8w8JpfUFEuzyP9SveR8iG6SCqYz3O5PR+f9a3Ejq4 w+hdnYvxAN789UP5OmTq5M4StU4f0gdKpOj+wBH/tY4vVI3uC504dQ9zAd0Vpl7mKZxh hvtExMFfyRFubllXAxvcTYRAuFJRgAeOZjZp9dAF1Ii/QSLx1p2ZGQSO9h4YZ/Kr22wX hrJg== X-Forwarded-Encrypted: i=1; AHgh+RoXvQzTt/uwIkUAr57tjiWQQE+qjhlo7GWLs6axI7BG836OxG+J8qZOpNEIs4IQDAVxzxSMyAMplHYJJnc=@vger.kernel.org X-Gm-Message-State: AFuF++mVUeJregzCShbJ5DYq/GNjUX9e5cJ4jvQybd3E3vrHDu/CBwnb 62g546aW7G7IqMDoSS2kYiF97H8k1xcwTY0w43EekXCbMnElg6ZU2MVA23z/56m6aKQEekc4vZ1 2Bsd8+BQpgJ75E7aA1vCBfAe4YbCzYT5v4pd0TF6JtqU6mxYShoXRdCsCAqjnO7fAu/Y= X-Gm-Gg: AR+sD12zgZo7jbZg1oieVlbO7ng1cSI+SFsX1sq0W5QiS+K/zO3eKT13jZANIHpPu3x uE5sK/XMX6F9WmJ5c3kNJbMYZ2NFSUQoQw8z44xm04q9IOEaOWHejSz24zOJ/d3SlH9KeO9VV8W 2sYAXsPDRiBxNSkrU47PLfnErX3L5dPtkMrAem3N/bljXTU8fsMzu6Klhc3Yh64KO9CAqTFYja2 8gvQ7RdyEC29Az3S/ibdNtNjRFI8uaC0955UJvGQLpAACIb9YzXpdEBEw9KfpmIbvqf+EhJwY/j qwd196c7lpNR8DJawKTQsnoIvASzP2QPeZ0gu7seSbAsj6eAdETUIOhmjREjudlx5wTU1gJuRIk m/LDNgAO2AR6zYoJav4DhiB2moGKX X-Received: by 2002:a17:90b:4b8c:b0:38e:bbf1:de34 with SMTP id 98e67ed59e1d1-395c35eb2c7mr41084471a91.7.1787551174018; Sun, 23 Aug 2026 22:59:34 -0700 (PDT) X-Received: by 2002:a17:90b:4b8c:b0:38e:bbf1:de34 with SMTP id 98e67ed59e1d1-395c35eb2c7mr41084328a91.7.1787551173105; Sun, 23 Aug 2026 22:59:33 -0700 (PDT) Received: from [10.204.78.119] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395e4b46518sm9003488a91.17.2026.08.23.22.59.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Aug 2026 22:59:32 -0700 (PDT) Message-ID: <076c7c52-d96b-4493-b723-98953c10b92b@oss.qualcomm.com> Date: Mon, 24 Aug 2026 11:29:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] phy: qualcomm: qmp-combo: update DP PHY PLL programming on Glymur To: Jason Pettit , Vinod Koul , Neil Armstrong , Wesley Cheng , Abel Vesa , Dmitry Baryshkov Cc: Ritesh Kumar , Mahadevan P , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260721-glymur-phy-conf-v1-1-7c8909552c5e@oss.qualcomm.com> <20260822142508.25473-1-jason.pettit@oss.qualcomm.com> Content-Language: en-GB From: Nabige Aala In-Reply-To: <20260822142508.25473-1-jason.pettit@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DsJmPm/+ c=1 sm=1 tr=0 ts=6a8bddc6 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=RPR65wM-umSgSowWlNQA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: OnaBKGV5G8kkfJMORTPgHvlukxfi4b7L X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDA1MSBTYWx0ZWRfXwJjQfpJMRu7n hhuuYhOephyTu3DhWqGSDMhlNllQgmHEO+vyfseCiU5jAAb2BZsr8Wbgnj69AIc/8fwBW5DxBP6 1cs48cbapraPPoQvPJHHqiStSiD6AXUpooBSmmajXctVyBzxcXp3OtbpK+IVgBFZXtilA6CaJjV 1lgb+sSMVi+1LK1Mr7vsVed76iDYO/HShYAWbVHgg9qhIXflXIpBF8sF+Ra8qI9RjH9BHQltg3G 24pvhGQh6oo8QvCAIf0IP0jbSu7c+QCKroobUM8gd5LIJdp9T15mdDvuZA6X6d1QVLJ67DlR5N7 W8QeANWZb9+tl7Ht78O/ePhqcNA8Jqzzf8hswXSTUf/BYpoix6Yh/TjGke37l0jA+Imvqc33PHH TAL+I0VPQkS8dJOKPESB8TmQ02+V753gzXmX4u5hlxuScFR2zoLlyZJFr4N4detZyH+iMsyJnJb 2QSaC0xJZHajEQKk0ew== X-Proofpoint-ORIG-GUID: OnaBKGV5G8kkfJMORTPgHvlukxfi4b7L X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDA1MSBTYWx0ZWRfXzCZPLy1GpioY p/aeJdAwRiIAnc0vFgHSmpfz3nLvY+dG5Yl+bSxihRxRTQ/czn/c7Rgk5CbCG97U5cs5B2d7D9N yKJGoA6VqzuA+rgsFXQUs29L5Vk+d5c= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_02,2026-08-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 clxscore=1015 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240051 On 8/22/2026 7:55 PM, Jason Pettit wrote: > On Tue, Jul 21, 2026 at 10:48:33AM +0530, Nabige Aala wrote: >> +#include "phy-qcom-qmp-dp-qserdes-com-v8.h" > That filename does not match the one accepted upstream. In Linus' tree the > header is > > drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h > > The "dp" and "qserdes" components are transposed. As written the build stops > at the include. > > drivers/phy/qualcomm/phy-qcom-qmp-combo.c:56:10: fatal error: > phy-qcom-qmp-dp-qserdes-com-v8.h: No such file or directory > > Dropping the line instead is not a fix, because the patch uses two symbols the > header supplies. > > phy-qcom-qmp-combo.c:321: error: 'DP_QSERDES_V8_COM_C_READY_STATUS' undeclared > phy-qcom-qmp-combo.c:322: error: 'DP_QSERDES_V8_COM_CMN_STATUS' undeclared > > Both are defined in phy-qcom-qmp-qserdes-dp-com-v8.h, which has been present in > mainline since v7.0-rc1. Correcting the spelling is the only change needed. With > that one edit the patch builds cleanly for me on next-20260821. Ack, Thanks for pointing out, I will add the "phy-qcom-qmp-qserdes-dp-com-v8" header in the next revision. This will fix the above error. > One other thing for the respin. The patch no longer applies with a plain git am > on current linux-next. The include block gained a line in > > eca0e717aab1 ("phy: qualcomm: qmp-combo: Add support for Hawi SoC") > > so the context of the first hunk no longer matches. git am -3 applies it. > > One process note. The subject line reads [PATCH], but the changelog in this > message reads "Changes in v2". The revision is therefore invisible to b4, to > patchwork, and to anyone following the thread. When you split this into the > smaller commits Dmitry asked for, please post the result as > > [PATCH v3 0/3] > > rather than starting the numbering again from [PATCH]. That keeps the lineage > traceable from v1 through the split series. Ack, Sure I will post the next revision as [PATCH v3 0/3] Thanks, Nabige Aala > > I am carrying this patch as a prerequisite for HP EliteBook X G2q board support, > so I am happy to test a v2 on Glymur hardware. > > Thanks, > Jason