mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: shanmukh.iyer@gmail.com, hugo@hugovil.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH v2] drivers/tty/moxa.c: Fix spelling mistake in comment
Date: Tue, 10 Jun 2025 06:56:41 +0200	[thread overview]
Message-ID: <076c8792-8e9e-4809-aca3-18f64e79f53d@kernel.org> (raw)
In-Reply-To: <20250609233452.164722-1-shanmukh.iyer@gmail.com>

On 10. 06. 25, 1:34, shanmukh.iyer@gmail.com wrote:
> From: Shanmukh Iyer <shanmukh.iyer@gmail.com>
> 
> Corrected some spelling and grammar in the comments, such as:
> - Units (baud -> baud rate)
> - Sentence flow
> - typos
> 
> This is part of my first patch to get familiar with
> the kernel's patch contribution workflow.
> 
> Signed-off-by: Shanmukh Iyer <shanmukh.iyer@gmail.com>
> ---

v2 changelog missing here now.

>   drivers/tty/moxa.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> index 329b30fac8fc..bf86f24e5655 100644
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
> @@ -1627,10 +1627,11 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
>    *           long baud          : baud rate (50 - 115200)
>    *
>    *           return:    0       : this port is invalid or baud < 50
> - *                      50 - 115200 : the real baud rate set to the port, if
> - *                                    the argument baud is large than maximun
> - *                                    available baud rate, the real setting
> - *                                    baud rate will be the maximun baud rate.
> + *                      50 - 115200 : the real baud rate is set to the port, if

the new "is" looks superfluous.

> + *                                    the argument baud rate is larger than
> + *                                    the maximum available baud rate, the
> + *                                    real setting baud rate will be the
> + *                                    maximum baud rate.
>    *
>    *
>    *      Function 12:    Configure the port.


-- 
js
suse labs

      reply	other threads:[~2025-06-10  4:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05  0:09 [PATCH] drivers/tty/moxa: " shanmukh.iyer
2025-06-09  8:26 ` Jiri Slaby
2025-06-09 12:39 ` Hugo Villeneuve
2025-06-09 23:34   ` [PATCH v2] drivers/tty/moxa.c: " shanmukh.iyer
2025-06-10  4:56     ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=076c8792-8e9e-4809-aca3-18f64e79f53d@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hugo@hugovil.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=shanmukh.iyer@gmail.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®