From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755AbdK1VjR (ORCPT ); Tue, 28 Nov 2017 16:39:17 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:57974 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752286AbdK1VjO (ORCPT ); Tue, 28 Nov 2017 16:39:14 -0500 From: Nick Terrell To: "Gustavo A. R. Silva" CC: Chris Mason , "linux-kernel@vger.kernel.org" , Kees Cook Subject: Re: [PATCH] lib: zstd: bitstream: Mark expected switch fall-throughs Thread-Topic: [PATCH] lib: zstd: bitstream: Mark expected switch fall-throughs Thread-Index: AQHTZ9wU2VVzFLign0ykdfxdrJ7btqMqUtQA Date: Tue, 28 Nov 2017 21:38:49 +0000 Message-ID: <0770A301-E322-4F85-A0F6-8448DECBB258@fb.com> References: <20171128000059.GA22017@embeddedor.com> In-Reply-To: <20171128000059.GA22017@embeddedor.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2620:10d:c090:200::5:38ab] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR15MB1660;20:FbK5Aj8j4P2fNxkFnGjc6fCAebStqTs1DXiDOxexYf6XRdIKrGT/8KWAoIT3hQM2q+BUfvwcWJDaDQT5QsS29dN9pT3fCkL9Ds78sN4/3y51rnw+JZgLk+ZG6hTZ8uEuAZanBv8NqSaowKo/hNpXsDihBORXB4wqCnBNQ051H3Y= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10019020)(6009001)(366004)(346002)(376002)(199003)(24454002)(189002)(82746002)(68736007)(53546010)(86362001)(7736002)(305945005)(105586002)(8936002)(6486002)(966005)(101416001)(478600001)(6436002)(25786009)(229853002)(6506006)(50986999)(33656002)(14454004)(77096006)(54356999)(76176999)(6512007)(6306002)(106356001)(53936002)(6246003)(4326008)(36756003)(6116002)(102836003)(2906002)(3660700001)(2950100002)(81166006)(3280700002)(99286004)(5660300001)(81156014)(8676002)(2900100001)(54906003)(83716003)(189998001)(316002)(97736004)(6916009);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1660;H:DM5PR15MB1753.namprd15.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: fc802288-d024-4e31-abdf-08d536a86990 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:DM5PR15MB1660; x-ms-traffictypediagnostic: DM5PR15MB1660: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(67672495146484)(81227570615382); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(11241501159)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231022)(3002001)(6041248)(20161123564025)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011);SRVR:DM5PR15MB1660;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM5PR15MB1660; x-forefront-prvs: 0505147DDB spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <23918A5464C0F9498306B10F32A42B29@namprd15.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fc802288-d024-4e31-abdf-08d536a86990 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2017 21:38:49.5037 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1660 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-28_12:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vASLdLlK016178 > On Nov 27, 2017, at 4:00 PM, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Looks good to me. We had the same patch in upstream PR#690 [1]. I believe that PR#695 [2] was also necessary to quiet the warning. [1] https://github.com/facebook/zstd/pull/690/files [2] https://github.com/facebook/zstd/pull/695/files Reviewed-by: Nick Terrell