From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9820BC48BC2 for ; Wed, 23 Jun 2021 11:13:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80B2D61075 for ; Wed, 23 Jun 2021 11:13:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbhFWLP6 (ORCPT ); Wed, 23 Jun 2021 07:15:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20086 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230098AbhFWLP5 (ORCPT ); Wed, 23 Jun 2021 07:15:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624446820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jnl2/rIg/QPDzGy+KJkBUGcAxtR6X5tNt16GwqYV2Ik=; b=IKzGp+PW+29AoQ7FUcLGm6Jak7VGE8NY790c9GbmQJ69Uz9OWuMkTVLFVEiL0PiuWs4/Vl ZAzul1Za4VaPlzoCraoeFYQyOT7pk3LVoSdx5c4OujSHNF7drUiVWTTeu++G9NggFW04AM qPQY/2/6PgPOXh+9oaCbPj0eBpF+sJU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-9066NfWBOQW6UFBG9eU2bQ-1; Wed, 23 Jun 2021 07:13:38 -0400 X-MC-Unique: 9066NfWBOQW6UFBG9eU2bQ-1 Received: by mail-wm1-f69.google.com with SMTP id o3-20020a05600c5103b02901aeb7a4ac06so1445695wms.5 for ; Wed, 23 Jun 2021 04:13:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Jnl2/rIg/QPDzGy+KJkBUGcAxtR6X5tNt16GwqYV2Ik=; b=tH9YxdgmBasd1aocKtnfTv5RTLU53BUI8ku5iVOWj0OgmKJqY7pMvdqLRbW2PTQ9PJ 8zJn6P0EOFFNPvoI68zleaj+XCtbBYk+f72A/5jKXLdSBRAKnLlKeYzqr4UxrqnOdd4E E3Eu6avVCYev4L46DEAw4xlD/HuV8AcJona417LzYj6yJeE18XEtIlyokx3pr+eYefsM IQbMVtpeaL5MoYNbAymm6CtefuITBF0gaL1Oa6z4ZpZhXbZ9SBPYCDoDtLPO+p/nyz5n ysiqCCR/MjWgmo8SDO/amzz+rw2L+GZex3ED5N7Ba3M/RS7KC5nYE9uUn1fpj224IxDe YllQ== X-Gm-Message-State: AOAM53296NdfB1k1sseZNEz8CgjP1Wz/P2m427tgmArvy3SIwGyCpu6j XKKFamL9mKhKR7s1Gb05Bzz8Pu3QXwbrZvBtqGjRq4E3Tn+ZldR0G+uPoUa9DEDH+4gCyliXrnM dy3nuMobXu5LpHYdjNjSgIZwj X-Received: by 2002:a1c:7510:: with SMTP id o16mr10132928wmc.137.1624446817643; Wed, 23 Jun 2021 04:13:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJwLzoKoz8r+R/xKXeF7Lx7jZ0y9cE2C6Y8Oc0j2T+kzzTfX0/iX0JS/L3nt4PZRaysvKkkQ== X-Received: by 2002:a1c:7510:: with SMTP id o16mr10132910wmc.137.1624446817467; Wed, 23 Jun 2021 04:13:37 -0700 (PDT) Received: from [192.168.1.101] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id i6sm2590861wro.12.2021.06.23.04.13.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 04:13:36 -0700 (PDT) Subject: Re: [PATCH v2 2/2] drivers/firmware: consolidate EFI framebuffer setup for all arches To: Thomas Zimmermann , linux-kernel@vger.kernel.org Cc: Albert Ou , David Airlie , Catalin Marinas , Russell King , dri-devel@lists.freedesktop.org, Hans de Goede , linux-efi@vger.kernel.org, Palmer Dabbelt , Peter Robinson , Paul Walmsley , linux-riscv@lists.infradead.org, Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org References: <20210601150017.774363-1-javierm@redhat.com> <9700697f-747c-fe36-d480-69762e845f30@suse.de> From: Javier Martinez Canillas Message-ID: <07745425-8d1b-5c0a-1622-cb08828d396c@redhat.com> Date: Wed, 23 Jun 2021 13:13:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <9700697f-747c-fe36-d480-69762e845f30@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Thomas, Thanks a lot for your feedback! On 6/23/21 12:06 PM, Thomas Zimmermann wrote: [snip] >> config SYSFB >> bool >> default y >> - depends on X86 || COMPILE_TEST >> + depends on X86 || ARM || ARM64 || RISCV || COMPILE_TEST >> >> -config X86_SYSFB >> +config SYSFB_SIMPLEFB > > You should also update the help text for simpledrm to reflect this > change. See drivers/gpu/drm/tiny/Kconfig. > Indeed, I missed that. I'll update it in v3. [snip] >> + >> +__init void sysfb_apply_efi_quirks(struct platform_device *pd) >> { >> if (screen_info.orig_video_isVGA != VIDEO_TYPE_EFI || >> !(screen_info.capabilities & VIDEO_CAPABILITY_SKIP_QUIRKS)) >> @@ -281,4 +348,10 @@ __init void sysfb_apply_efi_quirks(void) >> screen_info.lfb_height = temp; >> screen_info.lfb_linelength = 4 * screen_info.lfb_width; >> } >> + >> + if (screen_info.orig_video_isVGA == VIDEO_TYPE_EFI && >> + IS_ENABLED(CONFIG_PCI)) { > > We have a 100-character limit now. This should (?) fit onto a single line. > > Oh, I didn't know the character limit was extended to 100 chars now. [snip] >> >> /* if the FB is incompatible, create a legacy framebuffer device */ >> if (si->orig_video_isVGA == VIDEO_TYPE_EFI) >> - name = "efi-framebuffer"; >> + pd->name = "efi-framebuffer"; >> else if (si->orig_video_isVGA == VIDEO_TYPE_VLFB) >> - name = "vesa-framebuffer"; >> + pd->name = "vesa-framebuffer"; >> else >> - name = "platform-framebuffer"; >> + pd->name = "platform-framebuffer"; > > You're allocating the platform device with an empty name string. And > here you're overwriting the pointer. Can you rearrange the code to first > detect a proper name and then allocate the device with that name? It > takes a few bytes more memory, but seems in the spirit of the interface. > Right, I'll change that in v3 as well. > Best regards > Thomas > Best regards, -- Javier Martinez Canillas Software Engineer New Platform Technologies Enablement team RHEL Engineering