From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AA0C2210C2 for ; Thu, 12 Dec 2024 18:33:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734028401; cv=none; b=nouQHj8NNifOaD4UwkCf2loAHjmCbDpz8qznS3t0IJM2xoaPceCT8+hlhJotvIxnLl1+1w9d/5w0Fb6d/GLNRNYewVSIf8Xp4/EIfc1ilxxF2zyqTe3ck6CHwV1wk2LY+XmzSt2WoeBmAmrufmjAJi+njlKJihVwrtm1fQZqck0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734028401; c=relaxed/simple; bh=S8pyGemZgDyFrB3LbBylLdpP1liWYPzQ6w+PiYfxTUc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ao5nisC2iTkyr0KcumIY0Q6T4QbVMLFVd5y+XQ5ujYY0E5TuL2XayyzSBFGOg9QXWwnUbHWCeD+tcSs5G1i2MZx98Y7NmDp7G6moCqZvcn/niE12ELyd3HmtiaVyuzpWiGIPMmfeI8KbmX4eiKnFAAPGvO6zKzL/ZA8QywbijBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L+aVZGCh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L+aVZGCh" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BCG9WcS030098 for ; Thu, 12 Dec 2024 18:33:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7P0lT5CU0pXRpSIELwaVuf56/lpIFAAE4uyri3Arzm0=; b=L+aVZGCh2stHV2W5 kCKcATDhp6Ty1c0xLKj1DE0gq/wHEIxuFLwc1RShbIkg2Ht4GhxQ9oJaU9cUAejY d3d7iwj7HP6rF/k/dw3lM9V8l2zjB9YtTWvtcmhH3/cciOvnqu1f1jciuPD5o5/+ H2RSroSdJfH2KSGr8l2ZQnWkf8eHGCRKRfXyfkfrDYv0NsRh8vjUMIbkmHskpB0Y 692uc1sqjjSAypk48xkBviIPJCEcy50zjH0qKzpN8m8cMUgQ3Kmy611093taRyuh LSzauJ32RR5WQJ2EI0/cnXAjDVvnrO1Y/NeWyNQKy+dTUmNhoDITrBuGaq4RFfnz xhx6xw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43dxw4ca95-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 12 Dec 2024 18:33:19 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-467975f1b53so2381251cf.3 for ; Thu, 12 Dec 2024 10:33:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734028398; x=1734633198; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7P0lT5CU0pXRpSIELwaVuf56/lpIFAAE4uyri3Arzm0=; b=fVa7Bv9dNbqIguMzhZyuHMaHcOwKr/+PahutUuCCK8ZvULzdd3NPE7Yhf30TzoTj7P ZD/q3JLc87YEiIavBKNyILJ2MIpqzkNptpxHp3Fbn3zd6Fcut848Zyejv6KY4cBSZiUm pjiC1JDc7uBGgWcnMW4j4VUj017lc0M9aWUfNTrdPbK/ygrfKLqTPVxnnCDpxvJkqOZy MfnDEhyBZjrsZ7fP71PvMNZpaZaX7MofkDXFvYjyZ6WF1h1rCjzt51/noH0BdBrv8SdG EouIJtOkJBJyITyD9B8r5X0rfRJmKVvR1N7TffGONL3/XJgfrOGQxtwGrPWUSDK1aylH 6tLQ== X-Forwarded-Encrypted: i=1; AJvYcCVew49fBkpCRElb/E70dgYWYa01KkIg7sHsZ4rkGRoEtFmUJ/qRlR15bBZ5AyvB2hJvQgHuEzjljMTZkc8=@vger.kernel.org X-Gm-Message-State: AOJu0YzQEnXK8IfKui15RtrzkHMHYoMi7F6dWRlluCL23FYF+sdR0YXb BBoEnZOHDMGMW9Jks8YoimqZZeP7fwxESoTL8fjVHIi5rPwFQ/G+FXkbthThcguHv2TffuxSfF5 CQJxexfJpSc/iagiuYdZrsgjICSpfTwUqiJHdpGacgsUOuSxM2TN/8T6J9hi4DWE= X-Gm-Gg: ASbGnctnGlGe2Qc9IvqoNDcJdpc4TC+AdlVC2UiCQP4FY8pZKYriM/NksOoekGKDfKW fYn/A8ImsisvoCLiTeWLBXEfpcL6ddkXwattp4bX9kYYKAnHKtcjoJF3p+K5JR50HYEkdWLXZeI 8YGyd0nzvBUEuCDgnpywBsuUXhoisMMLGjsTrv1IZ/oyimgYilnbsMEed1NGOGrIT+UjpxCxiUT ZX2ScOXchubrUMq5l7VOlLyVcTskMWrfM/+U2OG0PulcNmJsLCwuTnxbdHMZzzkPLrAR9IEbmf7 6tz+++PCY9LoYIeKjzB/oicQE0cebHmfztVxrQ== X-Received: by 2002:a05:622a:c9:b0:467:5fd2:9963 with SMTP id d75a77b69052e-467a157c299mr7693051cf.6.1734028398523; Thu, 12 Dec 2024 10:33:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+5d8r2euOhZpYPGkl75/hl53j9+GKYqvLkelPut+0NmoKj8nha2RmqO1ELxeypwqRDcftCA== X-Received: by 2002:a05:622a:c9:b0:467:5fd2:9963 with SMTP id d75a77b69052e-467a157c299mr7692831cf.6.1734028398169; Thu, 12 Dec 2024 10:33:18 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa671f1482asm744364966b.107.2024.12.12.10.33.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2024 10:33:17 -0800 (PST) Message-ID: <0776a26e-56cd-4838-9b52-210ae9a1f281@oss.qualcomm.com> Date: Thu, 12 Dec 2024 19:33:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/5] arm64: dts: qcom: Update IPQ9574 xo_board_clk to use fixed factor clock To: Luo Jie , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_kkumarcs@quicinc.com, quic_suruchia@quicinc.com, quic_pavir@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, bartosz.golaszewski@linaro.org, srinivas.kandagatla@linaro.org References: <20241107-qcom_ipq_cmnpll-v6-0-a5cfe09de485@quicinc.com> <20241107-qcom_ipq_cmnpll-v6-5-a5cfe09de485@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241107-qcom_ipq_cmnpll-v6-5-a5cfe09de485@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: dplJ9zbiv8xIA81v_A1yYEP0tXAdKA9u X-Proofpoint-GUID: dplJ9zbiv8xIA81v_A1yYEP0tXAdKA9u X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412120134 On 7.11.2024 10:50 AM, Luo Jie wrote: > xo_board_clk is fixed to 24 MHZ, which is routed from WiFi output clock > 48 MHZ (also being the reference clock of CMN PLL) divided 2 by analog > block routing channel. > > Signed-off-by: Luo Jie > --- > arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 7 ++++++- > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 3 ++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > index 78f6a2e053d5..9a8692377176 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > @@ -174,8 +174,13 @@ &ref_48mhz_clk { > clock-mult = <1>; > }; > > +/* > + * The frequency of xo_board_clk is fixed to 24 MHZ, which is routed > + * from WiFi output clock 48 MHZ divided by 2. > + */ > &xo_board_clk { > - clock-frequency = <24000000>; > + clock-div = <2>; > + clock-mult = <1>; > }; > > &xo_clk { > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > index 8246a00a3e3e..25aed33e9358 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > @@ -32,7 +32,8 @@ sleep_clk: sleep-clk { > }; > > xo_board_clk: xo-board-clk { > - compatible = "fixed-clock"; > + compatible = "fixed-factor-clock"; > + clocks = <&ref_48mhz_clk>; This must be squashed with the previous patch, you can't introduce code and replace it immediately afterwards. Konrad