From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755250AbdKGMx5 (ORCPT ); Tue, 7 Nov 2017 07:53:57 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41534 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751792AbdKGMxy (ORCPT ); Tue, 7 Nov 2017 07:53:54 -0500 Subject: Re: [PATCH] tty: serial: jsm: remove redundant pointer ts To: Colin King Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171107114107.22805-1-colin.king@canonical.com> From: "Guilherme G. Piccoli" Date: Tue, 7 Nov 2017 10:53:47 -0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171107114107.22805-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17110712-0008-0000-0000-0000029C8BC0 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008025; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000239; SDB=6.00942421; UDB=6.00475391; IPR=6.00722709; BA=6.00005675; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017895; XFM=3.00000015; UTC=2017-11-07 12:53:51 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17110712-0009-0000-0000-0000373CDCA0 Message-Id: <077747a9-4ed2-9716-4de6-35f2fa269183@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-07_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711070178 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2017 09:41 AM, Colin King wrote: > From: Colin Ian King > > Pointer ts is assigned a value that is never read, ts is therefore > redundant and can be removed. Cleans up clang warning: > > drivers/tty/serial/jsm/jsm_tty.c:285:2: warning: Value stored to 'ts' > is never read > > Signed-off-by: Colin Ian King Thanks Colin! Acked-by: Guilherme G. Piccoli > --- > drivers/tty/serial/jsm/jsm_tty.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c > index e69227cc3827..5ecd878669b8 100644 > --- a/drivers/tty/serial/jsm/jsm_tty.c > +++ b/drivers/tty/serial/jsm/jsm_tty.c > @@ -275,14 +275,12 @@ static int jsm_tty_open(struct uart_port *port) > static void jsm_tty_close(struct uart_port *port) > { > struct jsm_board *bd; > - struct ktermios *ts; > struct jsm_channel *channel = > container_of(port, struct jsm_channel, uart_port); > > jsm_dbg(CLOSE, &channel->ch_bd->pci_dev, "start\n"); > > bd = channel->ch_bd; > - ts = &port->state->port.tty->termios; > > channel->ch_flags &= ~(CH_STOPI); >