From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751806AbdFGHBF (ORCPT ); Wed, 7 Jun 2017 03:01:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:36776 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751508AbdFGHBD (ORCPT ); Wed, 7 Jun 2017 03:01:03 -0400 Subject: Re: [PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper To: Sagi Grimberg , Christoph Hellwig , Keith Busch Cc: Hannes Reinecke , maxg@mellanox.com, Linux NVMe Mailinglist , Linux Kernel Mailinglist References: <20170606143617.32143-1-jthumshirn@suse.de> <20170606143617.32143-2-jthumshirn@suse.de> From: Johannes Thumshirn Message-ID: <0778ec96-8396-143e-9925-55f9c7d39239@suse.de> Date: Wed, 7 Jun 2017 09:00:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2017 08:26 PM, Sagi Grimberg wrote: > >> + while ((offset < buflen) && sg_miter_next(&miter)) { >> + unsigned int len; >> + >> + len = min(miter.length, buflen - offset); >> + memset(miter.addr, '\0', len); > > Why '\0' and not 0? Shouldn't be a difference, should it? ascii(7) says '000 0 00 NUL '\0' (null character)' -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850