From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B84CC77B76 for ; Mon, 24 Apr 2023 11:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231727AbjDXL47 (ORCPT ); Mon, 24 Apr 2023 07:56:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231710AbjDXL45 (ORCPT ); Mon, 24 Apr 2023 07:56:57 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 155BF4487; Mon, 24 Apr 2023 04:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=MtsLW4d1n4qxZAyNGKNu8MdKeZ+rUviA1nhEexKNVKE=; b=GQURdknGFoDSPPpyJrEyNvNBaD smr5vVOj3hoONFSVdWuYGTWfXpW/GDSGpbeaPflQ4eYnMsS2uVo6Lo/zBjUP8eIZbcB9vqIZVmYkw fzKLhU8dXN37ZXn0VUHQgRVE+ZxGhmxBkLMrhuqy/Ze3g0Xb9wkzj8iWYgVAZ7v6qUCk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pquo8-00B5Cm-7G; Mon, 24 Apr 2023 13:56:36 +0200 Date: Mon, 24 Apr 2023 13:56:36 +0200 From: Andrew Lunn To: "Radu Pirea (OSS)" Cc: Jakub Kicinski , hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enabling/disabling Message-ID: <077d3578-4475-4195-9018-392edd34d4e5@lunn.ch> References: <20230410124856.287753-1-radu-nicolae.pirea@oss.nxp.com> <20230412204414.72e89e5b@kernel.org> <36cab8c2-1901-a263-a7db-b7de486bfbeb@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36cab8c2-1901-a263-a7db-b7de486bfbeb@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Also why ignore the return value? > This register might not be present on every PHY, that's why the return value > is ignored. Please document that, otherwise you might see people add code to check the return value. Or better, still, differentiate between the different versions, and only touch it when it does exist. Andtrew