Re: [PATCH 01/11] hwmon: (pmbus/bel-pfe) Remove use of i2c_match_id()

[Andrew Davis <afd@ti.com>]

On 3/6/26 10:16 AM, Guenter Roeck wrote:
> On Thu, Mar 05, 2026 at 01:56:32PM -0600, Andrew Davis wrote:
>> The function i2c_match_id() is used to fetch the matching ID from
>> the i2c_device_id table. This is often used to then retrieve the
>> matching driver_data. This can be done in one step with the helper
>> i2c_get_match_data().
>>
>> This helper has a couple other benefits:
>>   * It doesn't need the i2c_device_id passed in so we do not need
>>     to have that forward declared, allowing us to remove those or
>>     move the i2c_device_id table down to its more natural spot
>>     with the other module info.
>>   * It also checks for device match data, which allows for OF and
>>     ACPI based probing. That means we do not have to manually check
>>     those first and can remove those checks.
> 
> The above seem to be boilerplates, not matching the actual patches.
> 
> AI review says:
> 
>    This isn't a bug, but this description is inaccurate for this specific driver.
>    Looking at the code before this commit, there were no manual checks for OF or
>    ACPI match data (like of_match_device or acpi_match_device) in
>    pfe_pmbus_probe(). The driver only ever relied on i2c_match_id().
>    Could the commit message be updated to avoid claiming it removes manual
>    OF/ACPI checks from this specific driver?
> 
> Similar feedback applies to most of the patches in this series. Please resend
> the series and drop inaccurate information from the commit descriptions.
> 

Yes, this one superset commit message was used for all the patches.
I'll go though and manually trim out the parts that are not relevant
for each given patch.

Thanks,
Andrew

> Thanks,
> Guenter
> 
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>>   drivers/hwmon/pmbus/bel-pfe.c | 5 +----
>>   1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/hwmon/pmbus/bel-pfe.c b/drivers/hwmon/pmbus/bel-pfe.c
>> index ddf9d9a2958c4..6499556f735b4 100644
>> --- a/drivers/hwmon/pmbus/bel-pfe.c
>> +++ b/drivers/hwmon/pmbus/bel-pfe.c
>> @@ -88,13 +88,10 @@ static struct pmbus_driver_info pfe_driver_info[] = {
>>   	},
>>   };
>>   
>> -static const struct i2c_device_id pfe_device_id[];
>> -
>>   static int pfe_pmbus_probe(struct i2c_client *client)
>>   {
>> -	int model;
>> +	int model = (uintptr_t)i2c_get_match_data(client);
>>   
>> -	model = (int)i2c_match_id(pfe_device_id, client)->driver_data;
>>   	client->dev.platform_data = &pfe_plat_data;
>>   
>>   	/*
>> -- 
>> 2.39.2
>>