From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752521AbdEPPyV (ORCPT ); Tue, 16 May 2017 11:54:21 -0400 Received: from mout.web.de ([217.72.192.78]:50096 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbdEPPyT (ORCPT ); Tue, 16 May 2017 11:54:19 -0400 Subject: [PATCH 3/3] s390: virtio: Adjust a null pointer check in two functions From: SF Markus Elfring To: kvm@vger.kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, Cornelia Huck , Halil Pasic , Heiko Carstens , Martin Schwidefsky Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <078ad841-544f-b989-4fdc-5f33acc220e7@users.sourceforge.net> Date: Tue, 16 May 2017 17:53:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:9kg1ETuLjSOYZIwhsP69IJnTIfMST40gK2Wd8CXKPTad7EhyEes NC8NZR1HYpf0O1T7wfXL6V4aUv4gn1vL4hDdilb6PRp3AEEdlEvWVFQ1/AxFv1tZ8pcxN3z ykXbWDO3vjN+9wFrgaxO32ECKSfPSqnKr53Ad0lo7eSnXym9OyMHbb8EByBvyh+uP+M6FO9 GS/RW4u0xeoqpdHngGzmw== X-UI-Out-Filterresults: notjunk:1;V01:K0:0Pl7896wLsY=:mm1yN65c2K9jVv/di9FxQI SyvHC5QmIiWLhNn6furI6my1q9Khh/8qgf9RV57u0jJzJw8USR+wWKkH4dYtjMUXDR0wkxrAZ mAUPOIUSt1YuvEvnnKWIDyVthAH/I6xQ1s+ENOSA1Kd9PhA77x6uDNAoHFO7LUKBnIWxhPhC2 kL+AI85rkDbmhjXQERYX1Th4gn0UGXHXFwQFH9831UCjCZ3x884xC9QNegKqbYat0zRQvMJkJ Zr6C5wSwKG4S6FT/7z8iv8CVNW+ttRZQ8nXB0Qti6O0w2y5+aXnmTB/ISi3HIAwS3IgqEMMpn 7XtCaBMnwreMUkyGjHuJ8sVZCCKwS7qYVpNVAdiNDKbPrJ4xaiERI0Qqq8RNfWMWOMqzV55wt 3GtMgy/OiSbpTt7DX4X5qN6kTlFBT59vjgkKTky9KDCgsZHs6Y/0DczaQCKWHQYthb4sHKUHV 2X5/BW29GnjIX8HC2oMhI/YNc6YdM0qkGJtC5mPsNiBh5fLPvZkWnot4dtfxo7oQUMNdHB42n /t8AAhawOba2icp/V1yL9paGp/EhP9ragEkd4WQrapccstgYry+X/vM74ElM90HnVSD5wpJAl tL/OuxEp3i2Bb24GmryDRS647VcqXAgmz8ary/eKOAxBZl91Cw6XIvz+PAG3ZoYzzfJHcXKfs I5A8B7aWuWTldJpVqHVsNLPHZ3rgzdwQt/Qkbg97eN6iZ3u9h01gbNaBtaHQcjtXupJnzoMie V+kCHtmBkFSGx1jf+lJwV4MpFUa2SkoQiQk3bDc+dmMy6hrIQajpKNDL0MBqg4rn+YGe4aCGt 4nlwWZu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 16 May 2017 17:14:26 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/s390/virtio/virtio_ccw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index bfb845d7faa7..27ab0f0b59cd 100644 --- a/drivers/s390/virtio/virtio_ccw.c +++ b/drivers/s390/virtio/virtio_ccw.c @@ -513,7 +513,7 @@ static struct virtqueue *virtio_ccw_setup_vq(struct virtio_device *vdev, } size = PAGE_ALIGN(vring_size(info->num, KVM_VIRTIO_CCW_RING_ALIGN)); info->queue = alloc_pages_exact(size, GFP_KERNEL | __GFP_ZERO); - if (info->queue == NULL) { + if (!info->queue) { dev_warn(&vcdev->cdev->dev, "no queue\n"); err = -ENOMEM; goto out_err; @@ -1388,7 +1388,7 @@ static void __init no_auto_parse(void) &from_ssid, &from); if (rc) continue; - if (parm != NULL) { + if (parm) { rc = parse_busid(parm, &to_cssid, &to_ssid, &to); if ((from_ssid > to_ssid) || -- 2.13.0