From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 011F7221F20 for ; Thu, 5 Mar 2026 09:54:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772704493; cv=none; b=Kq4xmpcvz1rAhLOSFO07wXysAjv7nxndyfdkRuoi6R7CdTo/ABzM4IEEEvFNqHQ0UHDMc0qd3oRxNUqYmHr8wVxbT6lQCNDxLGYsOB8DqUIG2WGttfkvLujLuuo991IiBRDjZl0MdgRYy0MDpVKXoCk8Q55tEVaY2OruMkMg2Pc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772704493; c=relaxed/simple; bh=XQukW4/ROjIRaE/AjfKafsRfg1a0xwL70/N0xAoX1/Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oO4+LylMrrdx4lLE9TEL3nTRXkNbKCgy8gRzOM/RrMJYjeXUI+6djV0zrsGYUOi6ZQKAOV/iFNtgauE+1rT1x3cXEhdHy6+2SZYeXIuTWzj2ppKbdRlaRdOiEEQ5BHtFomNrx2+XLHwxrDKPyTKvN5UQHeJixUlHT6jjuNAd3UQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lISM4GYy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FAAyF/p4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lISM4GYy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FAAyF/p4" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62590ZQ73473599 for ; Thu, 5 Mar 2026 09:54:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8bIcgp0lZ74b/t0VJU2b2r35aufWZF3oWB9C4Cu2IJs=; b=lISM4GYy7r2YvjjU he4Xn7XIzqyhlsO5K1EieQNDL0YlmsoRBamjcxtaeggPUF/bFKEYsxqE7ucR1iaf vqYv2T+XnqzKJRHtYFyUy71iivagmE96MKe1VSotqqcezS/Oq/OjWChvOD4XkwlI JWJySWaWoIno8r4zZD1j9pEpPKA5o/RM17NnRH3uA9qQYtp+zz+C4iKZaDMCbqpW b9/AJY1jRDU3zwiNu27sgD3X+YpDvBndopQz+MoCjwNxTu31Bz6MmwYwHHtAG6R0 6QHxt9gXTJvO/DIcsclzmbgNB9aNyqg288aW1a+ewi0Vc4mFtsYPI/4Z9MIbKyjS po60/w== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpj1847j2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 09:54:51 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb38346fdbso591996885a.0 for ; Thu, 05 Mar 2026 01:54:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772704490; x=1773309290; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8bIcgp0lZ74b/t0VJU2b2r35aufWZF3oWB9C4Cu2IJs=; b=FAAyF/p4ETlAjDhzYR7IzeUm4bwuG4qLmRaQZNiRN+1J8kI57cDOpOF4DpBk6iJkS9 cV1ApoiIRGNHOCv1h4xuRKdwgn2BXqemWPHSb07YFSvmBRBo8RthSqTvmzu6e2tIJoYo Ibso6SeIbyt10UrgsYS7W/F78aKcIZ+nh1e6BfeTIjlgcSSxcdK2Hetqz9WIVDBHtfqq wWqrkvk9/sa/NldAejQjyUsKYHKDFZrQZtVb2Gq3L4fCWnUefouJf7Z/lUTqKdzdipal 3xLIOkr9iIGcBrlLGNuYC43BtYInVkytUsnhd2nstQQeJwupNTQYSXBAh4A9wb/x+KsS GKoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772704490; x=1773309290; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8bIcgp0lZ74b/t0VJU2b2r35aufWZF3oWB9C4Cu2IJs=; b=Y4lHYMW+7B6mGjf7FnkzMrCMSf/4YTD+O58eqsDcEhLb81h/fWwmr/4f1B1sBDrnMS DjVYqo7wPA/r8i32w+jaFNveVnUiZTwodh1TvzsDfsL+LWC0QtihdTXgwP21K6TJrKdw oPQvU8CvenPuM4MNkjBiSYvIqC5mov0FOeVbszJL/1FZn2VcbfXl4BXYtygmZ2XPUKRR mWi7v6KlAbSNwM2qL3ysnGFL/E1Pe6KE2HA4cOnAJXi3mcBKy/mAzhpQmG5yIhf3FMRo rHedMaKnkNYOKOEC9m6Osyp6ivnWb6Xdh7QuMnO67B+Bhqu4lCYf682OkAQD/wA6d1hm GXuw== X-Forwarded-Encrypted: i=1; AJvYcCXV+X7bs5YYLAf1PXnZz+LkAL6rrKbvaXHxBNCoTKFgllxDHrEQlyotDWGurvZPn4eqwTo/JrZUn9ju1mo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7i92BIUUby5X+rzSLOyWM8pFLRZIb8o4xtcl2s/jXdLf+/cry 0g2Q7gNk5ToWNC+gB36KQPJlGEeNMwSA/LuaFt8jPPgKZB5E0RHV6dXK9xWlPbrg6UNXtzV2tqc RCVMUH3H0HlisYF04s2GAYXAsjKlzl3XOYB29pYkM5HmbxagWryTo00/qe9+mHUs9+qA= X-Gm-Gg: ATEYQzy8z6EPQye8tPZX4ZL9b0gcdVk2PMeOQEi8EbeT68yrd3Lo7MSEW13KDOFUeil RRs/JP1aQRu/xCXB5vy9vW/HJ2EfmbXRRv/XbnLzHJnLfdwTF4tB7tDhxlqDHNfQT3b7LpHnhSw BRhXsJNbdM1WH1v5wZ2iYU1Sa9SfxKtvSYYtAA4OK1si4DOySpFaqWPJyPz/g15DH73zT+9bS6Q CrI3Qz65YrSWL5sVqeB3h1ZUXpIJ6lWYINgLCrfTC5wdNDIvRVO04QNKmly4NYwnjQiwwTDKPLo Gy5bJIVDAWR859u8iAj2C8LH3wobCdIT1jMv4fYvuBuNC5v9AC/wKWzkf4xFuBKMbkIPGRtkfK4 VmHDhX2NZ3ZZrhM1oCoogmkmgqBPeRqJuYHkD/AkOnCRuuHsUdL7htu4rpXr2RBxIi4SoD52EyZ 2xZ8U= X-Received: by 2002:a05:620a:4014:b0:8cb:4059:a90c with SMTP id af79cd13be357-8cd5afbef4dmr441848385a.8.1772704490560; Thu, 05 Mar 2026 01:54:50 -0800 (PST) X-Received: by 2002:a05:620a:4014:b0:8cb:4059:a90c with SMTP id af79cd13be357-8cd5afbef4dmr441847685a.8.1772704490152; Thu, 05 Mar 2026 01:54:50 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ac546ddsm883089766b.20.2026.03.05.01.54.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 01:54:49 -0800 (PST) Message-ID: <07901284-a42f-488d-860d-985fc30d309b@oss.qualcomm.com> Date: Thu, 5 Mar 2026 10:54:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pinctrl: qcom: spmi-gpio: implement .get_direction() To: Neil Armstrong , Bjorn Andersson , Linus Walleij , Bartosz Golaszewski , "Ivan T. Ivanov" , Rob Herring , Fenglin Wu Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260304-topic-sm8x50-spmi-gpio-get-direction-v1-1-a25612161fba@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260304-topic-sm8x50-spmi-gpio-get-direction-v1-1-a25612161fba@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 1mkQSSrjmCH7SHUsnRxaN2hbGJcgu4e2 X-Proofpoint-ORIG-GUID: 1mkQSSrjmCH7SHUsnRxaN2hbGJcgu4e2 X-Authority-Analysis: v=2.4 cv=Ed7FgfmC c=1 sm=1 tr=0 ts=69a952eb cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=R7yui2fbp9-lrsd8BdYA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDA3OSBTYWx0ZWRfX8V7T4RGwbHgd 4OuWAVaiy/+pfmErzM5TP2NqeeZIZxfDW3hxQ+gm9fQJxLpQAKVXBGJKTr9BfD1JIBKT7/9ZCjn 5EZZoIqewOyk4W0ZPLPLCpRh1JzJVW71xg1Ix1MjnA56hiMvfOCcl/q+lf2rt0YSea6saMzhWZo wiNCF4ND/kiXOKkvlYA0vOCA12VoqhU8TvaRMbiSkL3sxUXXJvYb4GCgkbGFqUWhSAF6mFtdJnQ IVXKYhGuKYr1h5eOWd88Vpn5DkiBiukKku9nsbM5TYau0AxxyB3o0hnKTbxztuhanKfoJNgHEid +F38DZ0O+/CHpbM8hYmiXNMDP7eWwxnzMwciMnPkKJWAXkC+lv7MSgHMl5ax5yaEuG9VBDPR0U/ jft6G64V5f0O03wo/Do43v/l3MI/fQ5gL8VKphVG2wmG0HID4xbycl7XJM66iVoOIZL84zTowqG SM5JDTMgs8ItXEIlfbQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_02,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050079 On 3/4/26 6:41 PM, Neil Armstrong wrote: > GPIO controller driver should typically implement the .get_direction() > callback as GPIOLIB internals may try to use it to determine the state > of a pin. Since introduction of shared proxy, it prints a warning splat > when using a shared spmi gpio. > > The implementation is not easy because the controller supports enabling > the input and output logic at the same time, so we aligns on the > behaviour of the .get() operation and return -EINVAL in other > situations. > > Fixes: eadff3024472 ("pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver") > Fixes: d7b5f5cc5eb4 ("pinctrl: qcom: spmi-gpio: Add support for GPIO LV/MV subtype") > Signed-off-by: Neil Armstrong > --- Reviewed-by: Konrad Dybcio Konrad