From: Hongfu Li <hongfu.li@linux.dev>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: hongfu.li@linux.dev, akpm@linux-foundation.org, david@kernel.org,
liam@infradead.org, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, shuah@kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Hongfu Li <lihongfu@kylinos.cn>,
Pedro Falcato <pfalcato@suse.de>, Hongfu Li <hongfu.li@linux.dev>
Subject: Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
Date: Tue, 4 Aug 2026 16:51:57 +0800 [thread overview]
Message-ID: <0794432c-15a2-46e3-a24f-7e5e9f4d24bf@linux.dev> (raw)
In-Reply-To: <anGhWZPDaTP6M_FH@lucifer>
On 8/4/26 4:24 PM, Lorenzo Stoakes (ARM) wrote:
> On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote:
>> On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote:
>>> From: Hongfu Li <lihongfu@kylinos.cn>
>>>
>>> mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
>>> The second run repeats all assertions with no benefit. Drop the
>>> duplicate call.
>>>
>>> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
>> :))
>>
>> LGTM so
>>
>> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> Sorry Pedro mentioned off-list that you need to update the number of tests
> specified, e.g.:
>
> - ksft_set_plan(88);
> + ksft_set_plan(87);
>
> In main().
>
> Update that and send a respin and you can attach my tag to it.
Thanks a lot for your review. I will adjust ksft_set_plan() from 88 to
87 in main() and
send a respin carrying your Reviewed-by.
--
Best regards,
Hongfu
next prev parent reply other threads:[~2026-08-04 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 6:24 Hongfu Li
2026-08-04 8:20 ` Lorenzo Stoakes (ARM)
2026-08-04 8:24 ` Lorenzo Stoakes (ARM)
2026-08-04 8:51 ` Hongfu Li [this message]
2026-08-04 9:25 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0794432c-15a2-46e3-a24f-7e5e9f4d24bf@linux.dev \
--to=hongfu.li@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®