From: Mark Brown <broonie@kernel.org>
To: Baojun Xu <baojun.xu@ti.com>
Cc: tiwai@suse.de, andriy.shevchenko@linux.intel.com,
13916275206@139.com, alsa-devel@alsa-project.org,
shenghao-ding@ti.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, k-yi@ti.com, henry.lo@ti.com,
robinchen@ti.com, niranjan.hy@ti.com, pin-hao.huang@hp.com,
Syed.SabaKareem@amd.com
Subject: Re: [PATCH v2] ASoC: tas2783-sdw: add firmware download status check
Date: Thu, 13 Aug 2026 23:19:47 +0100 [thread overview]
Message-ID: <0799cd9d-a0ef-41da-80ea-3fb9b1ef0f7f@sirena.org.uk> (raw)
In-Reply-To: <20260813021450.1897-1-baojun.xu@ti.com>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On Thu, Aug 13, 2026 at 10:14:50AM +0800, Baojun Xu wrote:
> Currently, the firmware download is unnecessarily triggered on every
> system resume from suspend, causing significant wake-up latency. However,
> this step is redundant if the AMP remains powered on. Furthermore, certain
> memory pages (addresses > 0xc60000) are skipped even after an AMP reset.
> + if (!tas_dev->first_hw_init || file->dest_addr < 0xc60000) {
> + ret = sdw_nwrite_no_pm(tas_dev->sdw_peripheral,
> + file->dest_addr,
> + file->length,
> + file->fw_data);
What happens if the amplifier uses power (eg, over a system suspend)?
Though since nothing clears first_hw_init I guess there might be issues
there anyway...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-08-13 22:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 2:14 Baojun Xu
2026-08-13 22:19 ` Mark Brown [this message]
2026-08-14 3:51 ` Xu, Baojun
[not found] ` <7ea690074ee94d9786ed21e2bdde43de@ti.com>
2026-08-14 11:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0799cd9d-a0ef-41da-80ea-3fb9b1ef0f7f@sirena.org.uk \
--to=broonie@kernel.org \
--cc=13916275206@139.com \
--cc=Syed.SabaKareem@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=henry.lo@ti.com \
--cc=k-yi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=pin-hao.huang@hp.com \
--cc=robinchen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®