From: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] clocksource: Add BE/LE APIs support for clocksource counter reading.
Date: Thu, 11 Sep 2014 02:32:35 +0000 [thread overview]
Message-ID: <07a36481c1d64505a5c8957021d400e0@BY2PR0301MB0613.namprd03.prod.outlook.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1409102212530.4178@nanos>
> Cc: daniel.lezcano@linaro.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] clocksource: Add BE/LE APIs support for clocksource
> counter reading.
>
> On Wed, 10 Sep 2014, Xiubo Li wrote:
>
> So you add BE/LE APIs according to the subject line, but you fail
> again to tell WHY. If that would be the only issue ....
>
> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> > ---
> > drivers/clocksource/mmio.c | 44
> ++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> >
> > diff --git a/drivers/clocksource/mmio.c b/drivers/clocksource/mmio.c
> > index 1593ade..ddc5214 100644
> > --- a/drivers/clocksource/mmio.c
> > +++ b/drivers/clocksource/mmio.c
>
> So you think that adding this to mmio.c is the solution to the
> problem?
>
It's just one solution of this, and will be a little faster than the old one
When reading the counter value.
> Ever heard about function prototypes, header files and such?
>
Yes, this will be fixed later if this is acceptable.
> > @@ -20,21 +20,65 @@ static inline struct clocksource_mmio
> *to_mmio_clksrc(struct clocksource *c)
> > return container_of(c, struct clocksource_mmio, clksrc);
> > }
> >
> > +cycle_t clocksource_mmio_readl_up_be(struct clocksource *c)
> > +{
> > + return (cycle_t)be32_to_cpu(readl_relaxed(to_mmio_clksrc(c)->reg));
> > +}
> > +
> > +cycle_t clocksource_mmio_readl_up_le(struct clocksource *c)
> > +{
> > + return (cycle_t)le32_to_cpu(readl_relaxed(to_mmio_clksrc(c)->reg));
> > +}
> > +
> > cycle_t clocksource_mmio_readl_up(struct clocksource *c)
> > {
> > return (cycle_t)readl_relaxed(to_mmio_clksrc(c)->reg);
> > }
>
> So now we have three global functions which provide access to the mmio
> clocksource. And one of them is always redundant for a given compile
> time endianess. You can't be serious about this...
>
Yes, any good suggestion about this ?
I found whatever the method it is about the endianness will always be many
Different voices from different people and found it hard to taste all of them.
So firstly I just using the driver's local APIs.
Thanks,
BRs
Xiubo
prev parent reply other threads:[~2014-09-11 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 9:20 Xiubo Li
2014-09-10 20:33 ` Thomas Gleixner
2014-09-11 2:32 ` Li.Xiubo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07a36481c1d64505a5c8957021d400e0@BY2PR0301MB0613.namprd03.prod.outlook.com \
--to=li.xiubo@freescale.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®