From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349FFC4361B for ; Wed, 9 Dec 2020 07:03:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE3E623B99 for ; Wed, 9 Dec 2020 07:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728325AbgLIHDP (ORCPT ); Wed, 9 Dec 2020 02:03:15 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9560 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbgLIHDO (ORCPT ); Wed, 9 Dec 2020 02:03:14 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CrSdp2CYKzM2ZQ; Wed, 9 Dec 2020 15:01:50 +0800 (CST) Received: from [127.0.0.1] (10.174.177.9) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Wed, 9 Dec 2020 15:02:28 +0800 Subject: Re: [PATCH v2 1/1] ARM: dts: mmp2-olpc-xo-1-75: clear the warnings when make dtbs To: Arnd Bergmann CC: Lubomir Rintel , Pavel Machek , "Arnd Bergmann" , Rob Herring , linux-arm-kernel , devicetree , linux-kernel References: <20201207084752.1665-1-thunder.leizhen@huawei.com> <20201207084752.1665-2-thunder.leizhen@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <07a4d7d7-29e1-80dd-52de-315caafa1ebc@huawei.com> Date: Wed, 9 Dec 2020 15:02:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.9] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/12/8 21:58, Arnd Bergmann wrote: > On Mon, Dec 7, 2020 at 9:47 AM Zhen Lei wrote: >> >> The check_spi_bus_bridge() in scripts/dtc/checks.c requires that the node >> have "spi-slave" property must with "#address-cells = <0>" and >> "#size-cells = <0>". But currently both "#address-cells" and "#size-cells" >> properties are deleted, the corresponding default values are 2 and 1. As a >> result, the check fails and below warnings is displayed. >> >> arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): \ >> /soc/apb@d4000000/spi@d4037000: incorrect #address-cells for SPI bus >> also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 >> arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): \ >> /soc/apb@d4000000/spi@d4037000: incorrect #size-cells for SPI bus >> also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 >> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dtb: Warning (spi_bus_reg): \ >> Failed prerequisite 'spi_bus_bridge' >> >> Because the value of "#size-cells" is already defined as zero in the node >> "ssp3: spi@d4037000" in arch/arm/boot/dts/mmp2.dtsi. So we only need to >> explicitly add "#address-cells = <0>" and keep "#size-cells" no change. >> >> Signed-off-by: Zhen Lei > > Right, I already sent the same patch earlier. Oh, sorry, I don't known it. If you send it earlier, please apply your patch! > > Lubomir, can I apply this to the fixes branch? This fix is really should be considered to merge into v5.10. > >> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts b/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts >> index adde62d6fce73b9..82da44dacba7172 100644 >> --- a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts >> +++ b/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts >> @@ -224,7 +224,7 @@ >> >> &ssp3 { >> /delete-property/ #address-cells; >> - /delete-property/ #size-cells; >> + #address-cells = <0>; >> spi-slave; >> status = "okay"; >> ready-gpios = <&gpio 125 GPIO_ACTIVE_HIGH>; >> -- >> 1.8.3 >> >> > > . >