From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1030844AbdAJImU (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Jan 2017 03:42:20 -0500
Received: from lucky1.263xmail.com ([211.157.147.134]:50473 "EHLO
        lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1030414AbdAJImP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Jan 2017 03:42:15 -0500
X-263anti-spam: KSV:0;
X-MAIL-GRAY: 1
X-MAIL-DELIVERY: 0
X-KSVirus-check: 0
X-ABS-CHECKED: 4
X-RL-SENDER: shawn.lin@rock-chips.com
X-FST-TO: kernel-janitors@vger.kernel.org
X-SENDER-IP: 58.22.7.114
X-LOGIN-NAME: shawn.lin@rock-chips.com
X-UNIQUE-TAG: <720948bcdbcc46bc85961b297add11a0>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Subject: Re: [PATCH 3/8] mmc-core: Use seq_puts() in mtf_testlist_show()
To: SF Markus Elfring <elfring@users.sourceforge.net>,
        linux-mmc@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>,
        Harjani Ritesh <riteshh@codeaurora.org>, Jens Axboe <axboe@fb.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mike Christie <mchristi@redhat.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>
References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net>
 <5b8afe3b-0dee-0d95-c855-f0b93a95a072@users.sourceforge.net>
Cc: shawn.lin@rock-chips.com, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
From: Shawn Lin <shawn.lin@rock-chips.com>
Message-ID: <07a62dc9-0c46-2dc3-edcf-231d5dc7521c@rock-chips.com>
Date: Tue, 10 Jan 2017 16:41:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <5b8afe3b-0dee-0d95-c855-f0b93a95a072@users.sourceforge.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017/1/9 5:45, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 8 Jan 2017 19:48:28 +0100
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: Prefer seq_puts to seq_printf

it saves some lock time,

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

>
> Thus fix the affected source code place.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/mmc/core/mmc_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 2f838a13a904..848f4f30e343 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -3163,7 +3163,7 @@ static int mtf_testlist_show(struct seq_file *sf, void *data)
>
>  	mutex_lock(&mmc_test_lock);
>
> -	seq_printf(sf, "0:\tRun all tests\n");
> +	seq_puts(sf, "0:\tRun all tests\n");
>  	for (i = 0; i < ARRAY_SIZE(mmc_test_cases); i++)
>  		seq_printf(sf, "%d:\t%s\n", i+1, mmc_test_cases[i].name);
>
>


-- 
Best Regards
Shawn Lin