From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2B3F15AF6; Wed, 31 Jul 2024 07:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722409248; cv=none; b=jd2+M00TyIZ6i0CAtMIG89uwZmmg1BCLnn8AXbiAGQ8LeLMlFwXz8uFQwJ69Fll07u1gNdmZDTh7BKu/JH8LnmnhLe7BYppmRJqki+lt/6HwrxHVXMivQ5OUTDydDaNb7UfwJ5sxer1jkdPVP43rvT5gFin8eor2w0iUg+ZYFIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722409248; c=relaxed/simple; bh=2m1FPDyQe8xDyUfFki4gWqbW/FycigIA1fOZMOU7sCw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RQZU3l6LqOoRsAVV8b0h5+0ELtmFv1+0espp9/bjxSSpwLPRVfs81icsbtE3GfcNOO9wE+NFbkkhWpq74dwcrETfyySjxVYnWdi/eP9RjF0hw6loYQEtbmByhCmcEe2/vsa7mcAw5JjfDdDUwFvzvFIUlRLg9NaaT0SCEDiTg3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=orb3e89D; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="orb3e89D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1722409245; bh=2m1FPDyQe8xDyUfFki4gWqbW/FycigIA1fOZMOU7sCw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=orb3e89D9C564m+JGiavnP8Jg53kCcIwPKPgGZ0Iu+f/xS8iTbw0uyVi6n8cqexmL WPiGpIM3efYttUML/4mD7eueAqq3urfHxiZZSRgvXH68y8zQkdLw8SS6jJP3ZOoJmC 5GiuiJoaUwVrd/01SPOugAlY4f5fvOFFzeFv3+WsCTNarenvfxdrXaXRgbvMFGX0/6 bSSzJQlINFLt3j5covI7DU4383tbrOJSbVD7jSFAYMtZpXn5IplfyTY9l1w37HpG0T lej3f6KWE67ToViDbpO3jkrUKKNVxKlr6ab5kqWNSAx+C5/J/PySzE+KIPWM4iBvpO 4F5hTRb2t40zQ== Received: from [100.93.89.217] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madrid.collaboradmins.com (Postfix) with ESMTPSA id D8C1E3780B79; Wed, 31 Jul 2024 07:00:44 +0000 (UTC) Message-ID: <07a6b2a7-9884-40cb-b29a-3b30731d9686@collabora.com> Date: Wed, 31 Jul 2024 09:00:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] media: videodev2: Add flag to unconditionnaly enumerate pixels formats To: Hans Verkuil , mchehab@kernel.org, ezequiel@vanguardiasur.com.ar Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, kernel@collabora.com References: <20240722150523.149667-1-benjamin.gaignard@collabora.com> <20240722150523.149667-2-benjamin.gaignard@collabora.com> <0b4e2f13-8d79-4931-b868-6100f8b8893f@xs4all.nl> <3459c15d-5492-4765-b81c-9360d4291384@xs4all.nl> Content-Language: en-US From: Benjamin Gaignard In-Reply-To: <3459c15d-5492-4765-b81c-9360d4291384@xs4all.nl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 30/07/2024 à 09:19, Hans Verkuil a écrit : > On 30/07/2024 09:08, Hans Verkuil wrote: >> On 22/07/2024 17:05, Benjamin Gaignard wrote: >>> When the index field is ORed with V4L2_FMT_FLAG_ENUM_ALL the driver >>> will ignore any configuration and enumerate all the possible formats. >>> Drivers which do not support this flag yet always return an EINVAL >>> error code. >>> >>> Signed-off-by: Benjamin Gaignard >>> --- >>> changes in version 5: >>> - Reset the proposal to follow Hans's advices >>> - Add new flag to be used with index field. >>> >>> .../userspace-api/media/v4l/vidioc-enum-fmt.rst | 12 +++++++++++- >>> .../userspace-api/media/videodev2.h.rst.exceptions | 1 + >>> include/uapi/linux/videodev2.h | 3 +++ >>> 3 files changed, 15 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst b/Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst >>> index 3adb3d205531..12e1e65e6a71 100644 >>> --- a/Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst >>> +++ b/Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst >>> @@ -85,7 +85,11 @@ the ``mbus_code`` field is handled differently: >>> * - __u32 >>> - ``index`` >>> - Number of the format in the enumeration, set by the application. >>> - This is in no way related to the ``pixelformat`` field. >>> + This is in no way related to the ``pixelformat`` field. When the >> You need to start a new paragraph before 'When'. Otherwise you might read >> that the 'When' sentence is somehow related to the previous sentence. >> >>> + index is ORed with V4L2_FMT_FLAG_ENUM_ALL the driver will ignore >>> + any configuration and enumerate all the possible formats. Drivers >> I'd rephrase this a little bit: >> >> the driver will enumerate all the possible formats, ignoring any limitations >> from the current configuration. >> >> And after that I would like to see an example of a use-case. > Should the flag be kept on return of VIDIOC_ENUM_FMT or should it be cleared? > For reference: VIDIOC_QUERYCTRL will clear the V4L2_CTRL_FLAG_NEXT_CTRL flag. > > Regardless of what we pick, it should be documented. I believe most of the flags are cleared in v4l2 so I will to do the same and document it. > > Regards, > > Hans > >>> + which do not support this flag yet always return an ``EINVAL`` >>> + error code. >>> * - __u32 >>> - ``type`` >>> - Type of the data stream, set by the application. Only these types >>> @@ -234,6 +238,12 @@ the ``mbus_code`` field is handled differently: >>> valid. The buffer consists of ``height`` lines, each having ``width`` >>> Data Units of data and the offset (in bytes) between the beginning of >>> each two consecutive lines is ``bytesperline``. >>> + * - ``V4L2_FMT_FLAG_ENUM_ALL`` >> I am not really happy with this name since the prefix is identical to that >> of other V4L2_FMT_FLAG_ defines. How about: V4L2_FMTDESC_FLAG_ENUM_ALL? >> Or V4L2_FMT_IDX_ENUM_ALL? >> >>> + - 0x80000000 >>> + - When the applications ORs ``index`` with ``V4L2_FMT_FLAG_ENUM_ALL`` flag >>> + the driver enumerates all the possible pixel formats without taking care >>> + of any already set configuration. Drivers which do not support this flag >>> + yet always return ``EINVAL``. >>> >>> Return Value >>> ============ >>> diff --git a/Documentation/userspace-api/media/videodev2.h.rst.exceptions b/Documentation/userspace-api/media/videodev2.h.rst.exceptions >>> index bdc628e8c1d6..8dc10a500fc6 100644 >>> --- a/Documentation/userspace-api/media/videodev2.h.rst.exceptions >>> +++ b/Documentation/userspace-api/media/videodev2.h.rst.exceptions >>> @@ -216,6 +216,7 @@ replace define V4L2_FMT_FLAG_CSC_YCBCR_ENC fmtdesc-flags >>> replace define V4L2_FMT_FLAG_CSC_HSV_ENC fmtdesc-flags >>> replace define V4L2_FMT_FLAG_CSC_QUANTIZATION fmtdesc-flags >>> replace define V4L2_FMT_FLAG_META_LINE_BASED fmtdesc-flags >>> +replace define V4L2_FMT_FLAG_ENUM_ALL fmtdesc-flags >>> >>> # V4L2 timecode types >>> replace define V4L2_TC_TYPE_24FPS timecode-type >>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h >>> index 4e91362da6da..3d11f91273a1 100644 >>> --- a/include/uapi/linux/videodev2.h >>> +++ b/include/uapi/linux/videodev2.h >>> @@ -904,6 +904,9 @@ struct v4l2_fmtdesc { >>> #define V4L2_FMT_FLAG_CSC_QUANTIZATION 0x0100 >>> #define V4L2_FMT_FLAG_META_LINE_BASED 0x0200 >>> >>> +/* Format description flag, to be ORed with the index */ >>> +#define V4L2_FMT_FLAG_ENUM_ALL 0x80000000 >>> + >>> /* Frame Size and frame rate enumeration */ >>> /* >>> * F R A M E S I Z E E N U M E R A T I O N >> Regards, >> >> Hans >> >