From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbdBOC07 (ORCPT ); Tue, 14 Feb 2017 21:26:59 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:35282 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbdBOC05 (ORCPT ); Tue, 14 Feb 2017 21:26:57 -0500 Subject: Re: [PATCH 1/2] f2fs: enable inline_xattr by default To: Jaegeuk Kim References: <20170208093945.24681-1-yuchao0@huawei.com> <20170214003502.GB14533@jaegeuk.local> CC: , , From: Chao Yu Message-ID: <07aa0a06-b637-6588-c0d2-402134921ec0@huawei.com> Date: Wed, 15 Feb 2017 10:26:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170214003502.GB14533@jaegeuk.local> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.58A3BC58.0100,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 390bd5025e1d03a163908ab6c54a5993 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, On 2017/2/14 8:35, Jaegeuk Kim wrote: > Hi Chao, > > On 02/08, Chao Yu wrote: >> In android, since SElinux is enable, security policy will be appliedd for >> each file, it stores in inode as an xattr entry, so it will take one 4k >> size node block additionally for each file. >> >> Let's enable inline_xattr by default in order to save storage space. > > Then, we need to add "noinline_xattr". OK, let me introduce the new option in another patch. Thanks, > > Thanks, > >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/super.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >> index 68a555b014cf..e2f919d3096a 100644 >> --- a/fs/f2fs/super.c >> +++ b/fs/f2fs/super.c >> @@ -1026,6 +1026,7 @@ static void default_options(struct f2fs_sb_info *sbi) >> sbi->active_logs = NR_CURSEG_TYPE; >> >> set_opt(sbi, BG_GC); >> + set_opt(sbi, INLINE_XATTR); >> set_opt(sbi, INLINE_DATA); >> set_opt(sbi, INLINE_DENTRY); >> set_opt(sbi, EXTENT_CACHE); >> -- >> 2.8.2.295.g3f1c1d0 > > . >