From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8649A37D132 for ; Fri, 6 Mar 2026 23:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772840019; cv=none; b=swgNqL4UWh0wFTfG9W+2CIKQAcZnzxDxqiirWRd2XU1kwxNa/LBWmAAEV5UG/I2Tz6e+wxMSTuXYkJiCdj4lYLKA2YXXg3U++Glnq5VvTTYNiyenXkcCGasWuJsaYw3AWYhMc6+T+TKX/M32fioRwK+vk4BcVPYr3j2yDbpGf6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772840019; c=relaxed/simple; bh=plzyiDYL13gMDVwQr9Dj9f8cir0m0t5cKB6vFZUg2cY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FuEi0i166b9jt/89/fKAOEPLAW1bJ1/H7zL1b3/nRfiK3Q7Xu56OMzNWIyEM8XCaRj6cdVi2ipKB1a47SkOcYQ6jqz+mhQc3kkJjp2xrYR41NrbKnpSsKaRWiu1oghBvx4iOTz6Ng+mMgpoyfiF2FaSUbll4mrru1IglLflaZq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N/wZENZC; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N/wZENZC" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3597df496f6so3989434a91.1 for ; Fri, 06 Mar 2026 15:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772840018; x=1773444818; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=A3n1MjNRco+xhIuiD22YqqFeZmP/U2HpmvCL9DYQOmg=; b=N/wZENZCtnWx8XFZ0kyLD+P1jMXI1eOOU4pu38Tub9fp/sFNmGx7bJ6qd13qqxBcd+ 9FxIPe26xE++UcdJThW6DFIdREb7TCRSAGOjb6V8a0HCiCpU70tT95TNpuRqal93lshz 5vU67DX3D6ChDH+R/zzpwpvbFk9gPuz7Wg+Km8g8Aon1r5rnFJ+/xXlE6pXG9Qg34Thq pZBOW1J0CnrWpASKBSjPOtVzyascg0vhc/yEqdDpDvuXRBOa5tzst5rcOBdoft+lriaU kTtCKnDMNFjElDDX52pUfaqOQSWk4znRHWesOW63O4+fQLkSSIyQFUsNy094v+Vog9su GUMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772840018; x=1773444818; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=A3n1MjNRco+xhIuiD22YqqFeZmP/U2HpmvCL9DYQOmg=; b=b5eXRU7hD7AgnMoQ8v4YK8p5Z/SB3UKmfXtWV8YmJF+TmP+ELTa/4XxcceOsXI2RMv nfM4xmbW+8vHDdEiPL7Qw2nXfRue67SKKa28SfpH5nQuEiBrRttGVUs/W3hDhljmXWKC wzW4jaIPZYnDwN1SkvUoaqvGZE0eLYWF/gR0b+yDcLRh38sGHQnciKhED5uHQ0rVTQOl y6Ffg2t+OeOIZbsLFxEFlasJYpiHLG7iQwTSkqBrUG6o2BKuOuAlb8OeMDmBPaGTAEv9 05ieP+jlThT92zklgyT93PBvDViHXmMkswZx0k27OFI+w9g1nMn/TcCm01wbMY6hy7Mq MSRQ== X-Forwarded-Encrypted: i=1; AJvYcCXivwMnustaFetP2EmB2WDqhEDj6BEusSqwdX3eAzh8BuJdx4SZP/Rm/gY6jv63Ff5Wg8Qj3CVWoL4CrkU=@vger.kernel.org X-Gm-Message-State: AOJu0YxKjx+XkeRdkRZ4DIwIsfgXceoGjGcWwIN3ppaH7n6/ACKUPzMY Buaen6ZiILH10HCroVIeb1S8Qw+0cqS0lD82y9899lpFNzpz0wLgksL1 X-Gm-Gg: ATEYQzyLFktvjkt4K1PtH6jd2/2Bd8OCZLimZo5o7oRwk877CfYeaoLMqaZ201ihZrC Nv1bFVatIM++UF0j/MbNDeVCV8dD1vSJYg2GO+MutFABooXU0IWkFLIpsHMLFHyvLjakF2d7sHH FgwSeYAcOHJISBV6b0Ma5axJMMSpBMv9za2MoDrs18TT/bxIWtgxV7Res2VDbD39CDyPr0zijw4 BOOp6RIxnuwyyVczW4ZSTf8JRkx5mL5/DqOWWfezelObr0FAQ9ilYz3slycJYgJELNCl6oegiWa p7BXatUnBp8jq2bFg3cy4X/YTmzQIl7Elm8Jdzn32ThuDH5+AfNyTH47uXbV5gIhUhes5fWhv7i EawD23q12s6TLQtsDt+loIhsfk99KzMOAA+Y+WAWX6WSPKUjoABkjNmCi6DacN355vsh2+outuH KQYuOB1StGFFqHLjFfpCK2gX06VXyP8C7iAq3Z X-Received: by 2002:a17:90b:38c4:b0:32e:528c:60ee with SMTP id 98e67ed59e1d1-359be31746amr3476775a91.24.1772840017833; Fri, 06 Mar 2026 15:33:37 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359b2de79f6sm6579296a91.9.2026.03.06.15.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 15:33:37 -0800 (PST) Sender: Guenter Roeck Date: Fri, 6 Mar 2026 15:33:36 -0800 From: Guenter Roeck To: Bartosz Golaszewski Cc: Catalin Marinas , Will Deacon , Alexey Brodkin , Vineet Gupta , Scott Wood , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Dvorkin Dmitry , Wells Lu , Lee Jones , Pavel Machek , Wim Van Sebroeck , Mauro Carvalho Chehab , Greg Kroah-Hartman , Sebastian Reichel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-leds@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-pm@vger.kernel.org Subject: Re: [PATCH 10/14] watchdog: convert the Kconfig dependency on OF_GPIO to OF Message-ID: <07aa5d40-96b6-41a1-b8ce-22f2c2c94aed@roeck-us.net> References: <20260304-gpio-of-kconfig-v1-0-d597916e79e7@oss.qualcomm.com> <20260304-gpio-of-kconfig-v1-10-d597916e79e7@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260304-gpio-of-kconfig-v1-10-d597916e79e7@oss.qualcomm.com> On Wed, Mar 04, 2026 at 10:02:31AM +0100, Bartosz Golaszewski wrote: > OF_GPIO is selected automatically on all OF systems. Any symbols it Actually, that isn't really true. if GPIOLIB ... config OF_GPIO def_bool y depends on OF depends on HAS_IOMEM OF_GPIO also depends on GPIOLIB and HAS_IOMEM. I don't know why it needs to depend on HAS_IOMEM, but the GPIOLIB dependency is real. Guenter > controls also provide stubs so there's really no reason to select it > explicitly. We could simply remove the dependency but in order to avoid > a new symbol popping up for everyone in make config - just convert it to > requiring CONFIG_OF. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index dc78729ba2a5d6e035ed3cbe5c2b631d11b76b20..ef200339a22a6f9c51a46c9c0b8466add74313e2 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -250,7 +250,7 @@ config DA9062_WATCHDOG > > config GPIO_WATCHDOG > tristate "Watchdog device controlled through GPIO-line" > - depends on OF_GPIO > + depends on OF > select WATCHDOG_CORE > help > If you say yes here you get support for watchdog device