Re: [PATCH v3 4/9] drm/panel: novatek-nt36672a: Set driver name to novatek for consistency

[Neil Armstrong <neil.armstrong@linaro.org>]

On 10/11/26 13:54, Alexey Minnekhanov wrote:
> Since this driver should represent not only devices manufactured by
> Tianma Micro-electronics, but also from other companies, it makes more
> sense to name it according to what driver file name already is: novatek.
> 
> This does not change neither module file name nor Kconfig symbol, only
> driver identification in dmesg. This makes it possible to e.g. grep
> dmesg for "novatek" and get messages from both nt36672a-based panel and
> Novatek touchscreen.
> 
> Reviewed-by: David Heidelberg <david@ixit.cz>
> Signed-off-by: Alexey Minnekhanov <alexeymin@minlexx.ru>
> ---
>   drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
> index 464d9ce47d87d..73bec4f47ec60 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
> @@ -479,16 +479,16 @@ static void nt36672a_panel_remove(struct mipi_dsi_device *dsi)
>   	drm_panel_remove(&pinfo->base);
>   }
>   
> -static const struct of_device_id tianma_fhd_video_of_match[] = {
> +static const struct of_device_id panel_nt36672a_match[] = {
>   	{ .compatible = "tianma,fhd-video", .data = &tianma_fhd_video_panel_desc },
>   	{ },
>   };
> -MODULE_DEVICE_TABLE(of, tianma_fhd_video_of_match);
> +MODULE_DEVICE_TABLE(of, panel_nt36672a_match);
>   
>   static struct mipi_dsi_driver nt36672a_panel_driver = {
>   	.driver = {
> -		.name = "panel-tianma-nt36672a",
> -		.of_match_table = tianma_fhd_video_of_match,
> +		.name = "panel-novatek-nt36672a",
> +		.of_match_table = panel_nt36672a_match,
>   	},
>   	.probe = nt36672a_panel_probe,
>   	.remove = nt36672a_panel_remove,
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil