From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524AbcHSD3v (ORCPT ); Thu, 18 Aug 2016 23:29:51 -0400 Received: from mail-bl2nam02on0107.outbound.protection.outlook.com ([104.47.38.107]:2417 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753751AbcHSD3c (ORCPT ); Thu, 18 Aug 2016 23:29:32 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=linda.knippers@hpe.com; Subject: Re: [PATCH] acpi, nfit: fix acpi event notifications for nfit To: Dan Williams , Vishal Verma References: <1471546104-28520-1-git-send-email-vishal.l.verma@intel.com> CC: Linux ACPI , Xiao Guangrong , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "linux-nvdimm@lists.01.org" From: Linda Knippers Message-ID: <07af328e-d703-fd80-20be-725f00e54812@hpe.com> Date: Thu, 18 Aug 2016 15:52:48 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [50.187.52.22] X-ClientProxiedBy: BLUPR11CA0064.namprd11.prod.outlook.com (10.141.30.32) To CS1PR84MB0229.NAMPRD84.PROD.OUTLOOK.COM (10.162.190.151) X-MS-Office365-Filtering-Correlation-Id: 65b78744-f4c7-42ce-ef6d-08d3c7a13dcc X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0229;2:NixDMZK/hqTc3pmr102wigFMJw7mJG1o/cq7CbXjUiQgl19Er/hSF9WudoURcHYvUVHI3g+nAJcf68h3o7AV1d+WydTBAK7vNXW07mj+jvcOfpb/osxy8oFHZkNQ6nxCBNOt9T96kwjg9H+paZxnlbwi8Je1ffWFxvuUc+LdhGaAHWLx1Nz3cJWgw728qFDi;3:nttog9DNSQTPFFqKGoUqRd855W3DyxalBq54YXwkJ7WIHXxO66aNutThgEGrqo9VYMaLJBXJ7LCVhsdCXuv91WeGmRbHZXSYMc4Gq30Lc4lxJHFX6Cs/xGnCd+5I8LMD;25:r3b+2IQgRoYy/rBl8iadk+ok4j1OCDCHs63rNqtclGxH8fbuHS/lva6lYU5zXUQbQHfz+SPsAI+PZUL1Eht1/3Bj0ZgF0+5AyrlyMybwd3ekX4PV3ooGyrRfkmaWBHo9X0r+t+r50rVYIAFNgP6Cum+zedNtBg6i9omhdRsPS9Fl4lm3BhhAvC7Mk7cHRqFRPEogq8unF+TgHc6s58gYM/JLcEp6vNNb2EMJ+PIXBMql4xOP+cqA0vov132ToJ+wwuMApemxINkuCcXfShL3/HIz6TnSkFWcYFycmzoplrQnk/AC9QyyvetCq2Stdo1u4j2t9ZdNeu9xlVKpbetWVwa3Kwp//OEI066itVGVOy1iYQlFm/oWwXStC2dNnxult3bBLmU0Iy/JR8W2D+frhOCAbc8eSbp1ooeIbqpL2dY= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0229; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0229;31:Wp/SiWl4fSOG6f9V3VkjudXwpnJNry/Khd6MRUTfrD6i61P6vVmy7IUX3JpVwhSiCk7Bsg/FXvv+xNDrYzzHABp6H3SzsFtIPg9S4d64WDzoTWVAguK08I63jRvd3wg2vgm0NSzmbsR3pJmOpby1QH+q9GLkwUQzPTm8xK5THEXxY7tenl8AaxUIvnE2rjaj0tnw960hlwlkgT6A4r8efEgQkAb4HSny5PiYtaEbxTM=;20:vZUv+IXmYKJGka0QGNFuERq/fJrcMGllhToISktogWS8iaTP6+yr14IuRQrpEhFwkhDDX0aDFHN1dbIyYGVQCDORqpS6B6sD7aonpMzr1ea3AnWF2+7tJcGYyCt+xQVMiwkEMUwWc/xNErsjyOK1UZrcCT0C8L16bbE3YghCwhjyX4qGF3gtkvqWwkEGX/wDLDxFC8rnalQ8X5cFgAH9M6f7ZvWr64F0I2uY/g+9dvrsatijPTYYjvBaWHNS56Le+qBcloQZ6t86dhsy0sanmRLu6QzS7A23tMzq9b4zq2mGP1z8YhuEUzc+rh+MOAysgZtUhqLpVZoJBmsn+uX6/bVAd6QpVzXmjxECB4apX+jUqm0qQkb/PO5c68Qe2dHMKtIJsYmdM0qN6JOfAkuW1+6r0tdacGk7lSC2PuEJoL45Ra2BUdZF2zLnvJJ1r+gDxN50arUjlCQbEfdTbjGhDTojaAXoL4nXTAYTd9+ZzDdfhsbIjXnpMDfSetdB6Ka+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(162533806227266)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:CS1PR84MB0229;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0229; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0229;4:6IujQ4cz+LjPpmmuy2yPF0uf4Iznb6x+EAJOVHKIv+IqsVhrrB3BGVU/XO/X+4Wg8lv0va9h/qkkBZ8xcQ6uliLGGHUYh4quWlV3wcd9bZHIHULTE4ypA9WazCVTTf15KGwWcmML5yUmt2x7L1CYqk1nnH7YFJTbHKu0G2lFpCkPvUKxnruuiSywjwaht9YjxV4a7LaetuDWv4uwghMEys9BRtdDOGlOWsGwx2Uust+lvz54v6E1YidNHZAQCsPu8W8U6Wu22om16m0tGK0Wjx5PPpV3KsDZv7k9Oy7vtN3hAP51B21PyFxvBqSECHYsJ4INPUVQkaFPWfNflUT46WymS8ehG5YBf1BXfbiiPzqkAu5Hbl5/npwAo/dNcSssqyX6svujiF+R3wJIsdJVw5H2o1toDf4mhwpBG62uiQPsPK+O4bkFvjrfs+jIcaWqe9sSBkz5SfRTazfIdqmNFhwlEp/4+IEa3jf3bjYeFwY= X-Forefront-PRVS: 0038DE95A2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(24454002)(189002)(199003)(54534003)(377454003)(6116002)(31696002)(15650500001)(5001770100001)(586003)(83506001)(92566002)(3846002)(2950100001)(36756003)(19580405001)(8676002)(33646002)(23746002)(2906002)(66066001)(31686004)(97736004)(4001350100001)(77096005)(15975445007)(19580395003)(42186005)(54356999)(7846002)(64126003)(189998001)(81156014)(305945005)(76176999)(101416001)(81166006)(4326007)(65806001)(65956001)(68736007)(230700001)(106356001)(105586002)(47776003)(7736002)(86362001)(50986999)(117156001)(50466002)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0229;H:[192.168.1.7];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CS1PR84MB0229;23:0wGVF3YvOMS2sP6PmIPI27sGwE62pwWQMNqTh?= =?Windows-1252?Q?EHCu9Ro0kFW4HtoHlZOwNwVgV1lurfp/I1YI8XSCGhOIA95iXoTlmB8v?= =?Windows-1252?Q?xS4fiNQn6I/o1ekl8fUr/9tOEo9UdLaJfWrig1elmWOu087vHA/gQBRm?= =?Windows-1252?Q?rusnsmWNfUJC/tJQ8B5nVw9Q7Wju8o+zOgHqDEb5EBfDWKVlXHCe5fkx?= =?Windows-1252?Q?TY9wTw/2fXOck5hxDi+CRJizBFvZObWV6/UV3ZC+ZMB/CYfz10wVWmFD?= =?Windows-1252?Q?iHrWcDTV1dgQ5EzxdaMsfM5WOgIScuJF0wRURzX7Fg0ljFpa2HTPxQNq?= =?Windows-1252?Q?5Ba9bCMviPpUuNU9T7Y7hSM9J2ba1wCzCyOPzDdr75vPP7q+JungG3td?= =?Windows-1252?Q?raxpEzzUq8iw6Yp2jaZfK4aWMKrLrINps15mogwMUJb0yqO0LkvcmyMb?= =?Windows-1252?Q?qkpIGCtqJM383afTXnoERQrT/dIU0N8ID4vtrbn4500xw1VTpXW9fZwp?= =?Windows-1252?Q?UVFPIE96S3u1k+aC2RNkl5wrkXYE6EvJwpV+Eb1ZPw8bWRyBGJsavo3x?= =?Windows-1252?Q?wA5BOnVXNejzUKX0fSJa7xwiErdrfTP3O4bLzK0heg6Ds0YgRgkT/w5s?= =?Windows-1252?Q?TGM0lOPM+un1Sx2XaHakHUu6cvS3UsEzm2+1o5Qh7aWaa11Z0B678LWU?= =?Windows-1252?Q?fVz66+iyfuBEZgvNj0TpBn96+lEjsAJZMvw6NpgWmUFsYTSvgjs+ObHD?= =?Windows-1252?Q?TJectMAo4chW8oid86XGjwJw6uREVTkN8UH5k8Pm6cG31bS14FxC//dM?= =?Windows-1252?Q?RQEci0W4bG1nEY4fLOVCZXSL1Oq0vfYsAeAkVoiqeA+q1/QXNlLWpMk5?= =?Windows-1252?Q?WaCN6bMXmX+XBeVtKdplpW2h2d0XIxg1H1QdkfBvGQQXsqC/2+Be+eRJ?= =?Windows-1252?Q?4gUNbHSBDBDnEa0QTm0+b8CfDVsVILi4kKd0IWK1Wv7PygOOOyMrXv1K?= =?Windows-1252?Q?HtmwTei5VLdVZvAtSRWeAqrD+jti4LPmLkVyEcqOBFb+40pUoIuoQc04?= =?Windows-1252?Q?boK/bzuKfId7vNutt/zlNTMO/lHkTrp+0xrCEr40xnd3dP0X5llHPcLw?= =?Windows-1252?Q?VeapoDgy9dxqa4fyqCbc3Jb0mQwdO22dXGzm7P6rlA1EUQ/rhfAc123Y?= =?Windows-1252?Q?2ct36iIFasZuKrLRSPjM6QcricabQCfuKMMKIPwUZWQJ5n7LRrHBWBHY?= =?Windows-1252?Q?9I8+Je9ZKFHh4v+FBG2GOdNVjbbl/1/l01RjlSwHf180UbzEK/EDzIE9?= =?Windows-1252?Q?ds/OIASY6gGQmTZZqgFxZzYqItSzKPS6Lu53yBk/O8299Xs3JpRnG84V?= =?Windows-1252?Q?fc/qkt8B1c/y59jAuZWV4006CXEYZ0oxVB7L/nUMG9OS2rvlHPXZNS+p?= =?Windows-1252?Q?FVE0NMhCqA8g8LMnZgg4km5AbBiZ/uQHpDUQub/SX2krNSRi6K0ew0Vz?= =?Windows-1252?Q?04C7AM=3D?= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0229;6:3fHaZ0Gs9G+0Z8K7of87qBVFv3TGKTD439gzi6H+t504H6dhpFTuIsNep4GzKnYSbmOuKjTAkJ4nOsrTH17M7ZWlni39dqeuizLR/rhA0OrkvRq4NApooYUPa0FCKc9BsUKfypxIpNc5HIkjXjTwil6/63bd5mVfcO7rsuG2K2vO/EXMJvhFztfpBJvFoxC1Zvmm5jz8w+vq9y3q74ZZ9zrTyqA29vau4iFsYvnUbGTTDl92/f1ovEwhsvmzQR/T9agn2GkSCnMSca7k5sodZQ6DQXrnj1mz7TFI1IQFyeGn7LkwcAMNnl0fD9PSyWMnRmijj4NqvLZjaQWKg8EKLg==;5:xEC+njOpmn7zM/MDHvVReyT0Tmbp22RI6ZRecwq+0o6ONLVI1LnNUji+SqbLXYGEIJLYKU0AaEd2/Xoj8XgSy1BxUS5I9KOvIIRKL5g1/I1k3ud6d+Ju4ezp/SCrtKMw/YOLPNOVV7vhw9GZ0wUXbg==;24:hJYlWJXNvZePiNy///BVeHeYyKMdGbTEuF1n+O1gxPBJWEtvPZpkPSdNhTHUriB/SOkoZLcFl5tW5mvfU2sMnBJwlKro1k7qJ+hFaUzVQLE=;7:9OMBZZwBJGqsVep31ENO6LmDoZE4QJ8KX1PT4wUjtNTlvbwf8o2guMruCb2Ao5/uJiSNiE4AHmH66LFz9qHmzExVTLxueYCovO2zMoJEjR9OxGrLvCQGrmh3WqCSX/Mf5lh/HHr8fiLAE5llu9BpreK3jvU5H2PxNPqCnUhYboQHNbFOZUA/K7jI/QnraQFKiF8xTSQ1tpRpfLIbk8fNW7gFLTChZYMjpzYKnxJ169G3U+wvHvWCk6428CjxxQV9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2016 19:52:52.2257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0229 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/18/2016 3:48 PM, Dan Williams wrote: > On Thu, Aug 18, 2016 at 11:48 AM, Vishal Verma wrote: >> The nfit driver had an acpi event notification handler, but it never >> would've worked because we weren't setting the >> ACPI_DRIVER_ALL_NOTIFY_EVENTS flag in acpi_driver. > > Let's update the changelog to be helpful for someone implementing a > backport or taking this back to a -stable branch. Something like: > > Subject: acpi, nfit: fix event notifications > > Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added > support for _FIT notifications, but it neglected to set the > ACPI_DRIVER_ALL_NOTIFY_EVENTS flag that acpi_bus_notify() uses to gate > notification delivery. While we're at it, should we update the notifier function to explicitly check for event 0x80 before re-evaluating the _FIT? I'm thinking about some time in the future when there might be more than one event. -- ljk > > Fixes: 209851649dc4 ("acpi: nfit: Add support for hot-add") > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm >