mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Antonio Borneo <borneo.antonio@gmail.com>,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-usb@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] usbip: tools: add in man page how to load the client's module
Date: Thu, 25 Jun 2020 15:11:29 -0600	[thread overview]
Message-ID: <07af6971-b9d2-33a6-ec01-21c53050bc04@linuxfoundation.org> (raw)
In-Reply-To: <2da8fc9e34440c1fa5f9007baaa3921767cdec50.1593090874.git.borneo.antonio@gmail.com>

On 6/25/20 7:17 AM, Antonio Borneo wrote:
> While the man page usbipd.8 already informs the user on which
> kernel module has to be used on server side, the man page usbip.8
> does not provide any equivalent information on client side.
> Also, it could be hard for a newbie to identify the proper usbip
> client kernel module, due to the name "vhci-hcd" that has no
> immediate assonance with usbip.
> 
> Add in usbip.8 the command to add the module vhci-hcd, similarly
> as it's already present in usbipd.8 for usbip-host.
> While there, rephrase the description of the command "usbip list
> --remote=server".
> 
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
> --
> 
> v1->v2: rephrase the description of command "usbip list ..."
>          fix a typo in commit message
> ---
>   tools/usb/usbip/doc/usbip.8 | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/usb/usbip/doc/usbip.8 b/tools/usb/usbip/doc/usbip.8
> index a6097be25d28..a15d20063b98 100644
> --- a/tools/usb/usbip/doc/usbip.8
> +++ b/tools/usb/usbip/doc/usbip.8
> @@ -83,7 +83,9 @@ List local USB devices.
>   .SH EXAMPLES
>   
>       client:# usbip list --remote=server
> -        - List exportable usb devices on the server.
> +        - List devices exported by remote server.
> +
> +    client:# modprobe vhci-hcd
>   
>       client:# usbip attach --remote=server --busid=1-2
>           - Connect the remote USB device.
> 
> base-commit: 48778464bb7d346b47157d21ffde2af6b2d39110
> 

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah

      reply	other threads:[~2020-06-25 21:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  0:08 [PATCH] " Antonio Borneo
2020-06-18 17:11 ` Shuah Khan
2020-06-25 13:17 ` [PATCH v2] " Antonio Borneo
2020-06-25 21:11   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07af6971-b9d2-33a6-ec01-21c53050bc04@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=borneo.antonio@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®