From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A9BF2E2299 for ; Wed, 24 Dec 2025 08:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766566645; cv=none; b=jZItDZxFwqbrlHdlAvl4NHjwm0HQRlWjFdYx/8+LOqmNATK6HcUF1exmwSAIJ6cGPprgCDkrbTyPkcFrPmGbh2YSOwFzYDVPWTvZbBJmY5kerCZv+Ggo0Pdt86BpBh2gzOmtgknLCTRxo5T2ZDfd0g7d8mLKBrmzwDVBs4SZRuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766566645; c=relaxed/simple; bh=1n0t3PmqciaFWCpPU8IXS/Yq1JqNg+AVk9HAeWY7Bgo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jdhv3UFZ3JaUL2UPDYVfNQ0GFDL3abL6fu930e8h7toh8HWOexayovtAh0t8PeBENF3MO6muXgpN75E8QzzJJr01RuXH7fOeKxmjLVvsaGjJERWI9iKCiCJ36tk73V+QsdStLW9y3VuCCfzh+r8/3E3y066/x3oSOJnHeRxbTk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MYvEcW9k; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MbpmRk2u; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MYvEcW9k"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MbpmRk2u" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO354Js913442 for ; Wed, 24 Dec 2025 08:57:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YY2vZMGLYtMSNHn9qH/0CopeYQXkFGZwayfiSDsdyjE=; b=MYvEcW9khyfZVtdb dXQ0kTCzYLcWu56asyOY2ZB4OWZ0fEI+52XDKIcQ6Eyp8hfq2jtIt5NC4vVio436 7XSQb+FGCFZ7U70gjKwI0YQ5eQkW9IyZbHUNkJtJyHr2/ZiNEHgnu5wKuLT5DwqF zAxQ0fu+KqYDB2wB5IqGqn0UzozPk5i2J+8CPSL1d/uuCWv8znNesn6sC6wwo7zZ vWpzTAM4ZmwPH4c9QUMpgwOz0LqjbUQqH9UsyD/CAM02u9sCOxfjWZ8qtfByYVq6 644+Iwzw+izWBDmJBnUm3PzINXBmxlPdbxmZR/P8Lar4tg9p4KfCVQkN9nSivgqj nZdoxQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7vt2jps4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 08:57:22 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7b895b520a2so6749875b3a.0 for ; Wed, 24 Dec 2025 00:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766566641; x=1767171441; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YY2vZMGLYtMSNHn9qH/0CopeYQXkFGZwayfiSDsdyjE=; b=MbpmRk2u22W6MdsmyFU88VwVghkfd0PfsV1cmkujwVo0VLz+xn+HcnZ6FdpPJm5a1U GInq+32yQTVmQB+oXQDV6rpmU9jOcYCl7gGT1t2P20vGKb+SQBFJxzvtM7vNY8TGDbP7 YWEUR8c2VhL2M7unkUmovlzeC+flcowhcdsZEWmcSvwz0kCfKhadRq+LpF9efOdVwN6p SRQsaaDNiwkOsbPvX1o2U2lD2tS7mae1hnhfR4VBqkW0b6AIHauKgviHvkYOziosAu9X psevlFzICXCVfD9pGe6RIA2eCgxhDNbEFo9eGW2dXK/OPkMwXJ6cZVs5lNeL1bv+CkgN 5A4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766566641; x=1767171441; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YY2vZMGLYtMSNHn9qH/0CopeYQXkFGZwayfiSDsdyjE=; b=GTw/uMFIl7RNanbyezVoL7EYgYvxCW13Z5IDDELZxg2jXF0+3Ulgtrr7aOoIYkTmg8 Lqb4Tn0cRYAZ0z8RJGYvPQZKSq6bXs5tLWUSKoidAwPMoh7K2mgoThpM43YXkfZMDlHo YwyZ3rjh8JfZwK+iu0z5JCD71wBcjesgsN5SwuaktC+730TuA8vzF4EoTVIzMzowlX8q B9uJBuo8Yl2sFsQ6J3SgchZMjvZgeyzoJwvIekguc2ecERSLCDyzh9VhZNIz4mfyQvdl jZmjK2+H30XZ3qfPQXuiPsE1vCXkrtHyqtt+cZjDtSECFD5/b/xG9VaCvVXN9bmlpAlF IoQw== X-Forwarded-Encrypted: i=1; AJvYcCXuxHAwNa4mwP6QZNrQ5qGBbdYCHrej8LdlSDSYAwa+81DYFBPA2TQJTRMCkmGalgZ3z7Y+pMENmA0WRYo=@vger.kernel.org X-Gm-Message-State: AOJu0YxfkNIfss2Nud1Ge8T4MFEBBudYcuOc85sedGR3zmf3815Bxcph udwh8ipCuVHF012sNAHbwNWQtUP3QO1sfQXY2wWujlPcg6FgvlJo+l3zYYjHiSoiYtAsUt6sNah z5klSMhtKT4qjgCewF4Eml23dql4M0j9qFV/A8B1ulCJzQ9cUYtqENMy9xOeD8HeprSY= X-Gm-Gg: AY/fxX7GEkNw+FiDxzK7OxzCgMXmBiHhl9n5GHQLvG2rzDxCNLoSAG04Q2+pJ60EUdL YdVvi6HYvOkk/KD1x2lxvRQWkYAs6F+Qz1f7k+BCAedIqtABkazaar+mUfhYPI7HzVReKHdnLXM wWPJJWaQ2GGDvtEJ+z0zp+n+UBFbQwrh9yeh/NcT1bEQN+W+a/rwWGOTMIqOht285jxzbFrJafn VFaBLIManf0CP2hVGMhLceEnwB/1yc6mDaOpYdvXfWIx9X5djo6b85X/JD/Z1yZZALLKOZa+WOF EGyjmIGeypFTrWzaOr8ZSYrhbnYPqhrzaL7QLkxwofARw7qhdLwVZXUC1a4iZ/716n+OnSdJU4U DJdpBOisJse6U1AwloigsdAT3YXp+Z7qYkhMQJbcDooY= X-Received: by 2002:a05:6a00:4509:b0:7e8:4587:e8c1 with SMTP id d2e1a72fcca58-7ff6647983bmr14043752b3a.52.1766566641359; Wed, 24 Dec 2025 00:57:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IEEGeUs49rpRM60ET1MP4H3btdQu+rWmpwolNku2pFy8M1be+WSh8RXzumzSUrw20RJfSB8FQ== X-Received: by 2002:a05:6a00:4509:b0:7e8:4587:e8c1 with SMTP id d2e1a72fcca58-7ff6647983bmr14043735b3a.52.1766566640677; Wed, 24 Dec 2025 00:57:20 -0800 (PST) Received: from [10.204.101.164] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e197f9asm15917291b3a.43.2025.12.24.00.57.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Dec 2025 00:57:20 -0800 (PST) Message-ID: <07b1a76f-02dd-4973-841d-9ea9e6fb4147@oss.qualcomm.com> Date: Wed, 24 Dec 2025 14:27:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: iris: Add missing platform data entries for SM8750 To: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Neil Armstrong , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20251218-iris-sm8750-fix-v1-1-9a6df5cd6fd3@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20251218-iris-sm8750-fix-v1-1-9a6df5cd6fd3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA3NyBTYWx0ZWRfX4tT9mxNnOEgj EkA6z6aLPJLnc6bK9Rx8XW4yXkxjE8t9A2ZPOa9rnjzapLHjEwC2xjenV3hIHlX9LnBbuMAyziY aQgxorfARzmXT+6HqhxaJIKqT9nhgrddQnfJChF2WuZ7IBv+1IOftvjqGCfyZFmKVLRwdgxlItN 1fZb76WQxJjqk2D2Xw4JTOfsTcaFALnQ/AhwWnqrcBIxfRz+Pr8csrYTkyk6GFls3BLBbC3mY/A sgQyuRobEYQgIJCKgLMM+NxBVTR71PzP/eFLZLHqEZeh3tDgS7Nc/HsiviE55+4s5YHPzcgj0B0 Lxa4oYhyN0Na2Q1ug307ITNk7KX6D8lzj/+lJ/3ShbiCtDnY1wA98KmUYIBvOchxkRxRWMdHP+F 8/YKoOF51zrGyu7U03vD2G4g1d/fgk9bhrbyl7rUA6qFYPs/pa3zCkJNjWfPzbiQ1U17Es0eY7b LBeayMDhM9E0pI2DL1Q== X-Proofpoint-GUID: QGP-QJT6mD-lSJnO1wZc8C0B-clegHTO X-Proofpoint-ORIG-GUID: QGP-QJT6mD-lSJnO1wZc8C0B-clegHTO X-Authority-Analysis: v=2.4 cv=brtBxUai c=1 sm=1 tr=0 ts=694baaf2 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=4Q0S_CixsqQ5lHILDBkA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 malwarescore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240077 On 12/18/2025 12:24 PM, Dikshita Agarwal wrote: > Two platform-data fields for SM8750 were missed: > > - get_vpu_buffer_size = iris_vpu33_buf_size > Without this, the driver fails to allocate the required internal > buffers, leading to basic decode/encode failures during session > bring-up. > > - max_core_mbps = ((7680 * 4320) / 256) * 60 > Without this capability exposed, capability checks are incomplete and > v4l2-compliance for encoder fails. > > Fixes: a5925a2ce077 ("media: iris: add VPU33 specific encoding buffer calculation") > Fixes: a6882431a138 ("media: iris: Add support for ENUM_FRAMESIZES/FRAMEINTERVALS for encoder") > Cc: stable@vger.kernel.org > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index c1989240c248601c34b84f508f1b72d72f81260a..00d1d55463179429f2ae7554546dcbe4fb1431cc 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -915,6 +915,7 @@ const struct iris_platform_data sm8750_data = { > .get_instance = iris_hfi_gen2_get_instance, > .init_hfi_command_ops = iris_hfi_gen2_command_ops_init, > .init_hfi_response_ops = iris_hfi_gen2_response_ops_init, > + .get_vpu_buffer_size = iris_vpu33_buf_size, > .vpu_ops = &iris_vpu35_ops, > .set_preset_registers = iris_set_sm8550_preset_registers, > .icc_tbl = sm8550_icc_table, > @@ -945,6 +946,7 @@ const struct iris_platform_data sm8750_data = { > .num_vpp_pipe = 4, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K * 2, > + .max_core_mbps = ((7680 * 4320) / 256) * 60, > .dec_input_config_params_default = > sm8550_vdec_input_config_params_default, > .dec_input_config_params_default_size = > Reviewed-by: Vikash Garodia