From: Kamil Debski <k.debski@samsung.com>
To: "'Axel Lin'" <axel.lin@ingics.com>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>
Cc: "'Kukjin Kim'" <kgene@kernel.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: RE: [PATCH] phy: samsung-usb2: Remove NULL terminating entry from phys array
Date: Wed, 04 Mar 2015 15:47:28 +0100 [thread overview]
Message-ID: <07b201d0568a$234c4160$69e4c420$%debski@samsung.com> (raw)
In-Reply-To: <1425344923.4315.3.camel@phoenix>
From: Axel Lin [mailto:axel.lin@ingics.com]
Sent: Tuesday, March 03, 2015 2:09 AM
>
> Current code uses num_phys settings to tell the number of entries in
> phys.
> Thus remove the NULL terminating entry from phys array which is not
> necessary.
The patch looks good.
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Kamil Debski <k.debski@samsung.com>
Best wishes,
--
Kamil Debski
Samsung R&D Institute Poland
> ---
> drivers/phy/phy-exynos4210-usb2.c | 1 - drivers/phy/phy-exynos4x12-
> usb2.c | 1 - drivers/phy/phy-exynos5250-usb2.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/phy/phy-exynos4210-usb2.c b/drivers/phy/phy-
> exynos4210-usb2.c
> index 236a52a..f30bbb0 100644
> --- a/drivers/phy/phy-exynos4210-usb2.c
> +++ b/drivers/phy/phy-exynos4210-usb2.c
> @@ -250,7 +250,6 @@ static const struct samsung_usb2_common_phy
> exynos4210_phys[] = {
> .power_on = exynos4210_power_on,
> .power_off = exynos4210_power_off,
> },
> - {},
> };
>
> const struct samsung_usb2_phy_config exynos4210_usb2_phy_config = {
> diff --git a/drivers/phy/phy-exynos4x12-usb2.c b/drivers/phy/phy-
> exynos4x12-usb2.c
> index 0b9de88..765da90 100644
> --- a/drivers/phy/phy-exynos4x12-usb2.c
> +++ b/drivers/phy/phy-exynos4x12-usb2.c
> @@ -361,7 +361,6 @@ static const struct samsung_usb2_common_phy
> exynos4x12_phys[] = {
> .power_on = exynos4x12_power_on,
> .power_off = exynos4x12_power_off,
> },
> - {},
> };
>
> const struct samsung_usb2_phy_config exynos3250_usb2_phy_config = {
> diff --git a/drivers/phy/phy-exynos5250-usb2.c b/drivers/phy/phy-
> exynos5250-usb2.c
> index 1c139aa..2ed1735 100644
> --- a/drivers/phy/phy-exynos5250-usb2.c
> +++ b/drivers/phy/phy-exynos5250-usb2.c
> @@ -391,7 +391,6 @@ static const struct samsung_usb2_common_phy
> exynos5250_phys[] = {
> .power_on = exynos5250_power_on,
> .power_off = exynos5250_power_off,
> },
> - {},
> };
>
> const struct samsung_usb2_phy_config exynos5250_usb2_phy_config = {
> --
> 1.9.1
>
prev parent reply other threads:[~2015-03-04 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 1:08 Axel Lin
2015-03-04 14:47 ` Kamil Debski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='07b201d0568a$234c4160$69e4c420$%debski@samsung.com' \
--to=k.debski@samsung.com \
--cc=axel.lin@ingics.com \
--cc=kgene@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®