From: Paolo Bonzini <pbonzini@redhat.com>
To: wang.yi59@zte.com.cn, kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, sean.j.christopherson@intel.com,
vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, x86@kernel.org,
linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
up2wing@gmail.com, wang.liang82@zte.com.cn
Subject: Re: [PATCH] x86/kvm: Fix -Wmissing-prototypes warnings
Date: Fri, 25 Oct 2019 14:02:19 +0200 [thread overview]
Message-ID: <07bbeb02-e8fe-36d5-a761-402a48fe076f@redhat.com> (raw)
In-Reply-To: <201910250958273740534@zte.com.cn>
Queued, thanks. It may not appear on git.kernel.org until after KVM
Forum though.
Paolo
On 25/10/19 03:58, wang.yi59@zte.com.cn wrote:
> Gentle Ping :)
>
>> We get two warning when build kernel with W=1:
>> arch/x86/kernel/kvm.c:872:6: warning: no previous prototype for ‘arch_haltpoll_enable’ [-Wmissing-prototypes]
>> arch/x86/kernel/kvm.c:885:6: warning: no previous prototype for ‘arch_haltpoll_disable’ [-Wmissing-prototypes]
>>
>> Including the missing head file can fix this.
>>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> ---
>> arch/x86/kernel/kvm.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
>> index e820568..32ef1ee 100644
>> --- a/arch/x86/kernel/kvm.c
>> +++ b/arch/x86/kernel/kvm.c
>> @@ -33,6 +33,7 @@
>> #include <asm/apicdef.h>
>> #include <asm/hypervisor.h>
>> #include <asm/tlb.h>
>> +#include <asm/cpuidle_haltpoll.h>
>>
>> static int kvmapf = 1;
>
>
> ---
> Best wishes
> Yi Wang
>
next parent reply other threads:[~2019-10-25 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201910250958273740534@zte.com.cn>
2019-10-25 12:02 ` Paolo Bonzini [this message]
2019-10-10 6:37 Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07bbeb02-e8fe-36d5-a761-402a48fe076f@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=up2wing@gmail.com \
--cc=vkuznets@redhat.com \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®