mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24@gmx.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Arnd Bergmann <arnd@kernel.org>,  Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	 devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree
Date: Sat, 21 Feb 2026 15:24:35 +0100 (CET)	[thread overview]
Message-ID: <07c024a6-d2f9-5805-4ae7-cbc89cda53bf@gmx.de> (raw)
In-Reply-To: <82f24afb-1fd2-bfc9-2215-4526aff372ba@gmx.de>

Hi Dmitry,

On Sat, 14 Feb 2026, Marc Dietrich wrote:

> Hi Dmitry,
>
> On Fri, 13 Feb 2026, Dmitry Torokhov wrote:
>
>> As of d64c732dfc9e ("net: rfkill: gpio: add DT support") rfkill-gpio
>> device can be instantiated via device tree.
>> 
>> Add the declaration there and drop board-paz00.c file and relevant
>> Makefile fragments.
>> 
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> ---
>> 
>> This is not tested on real hardware, compile tested only...
>> 
>> arch/arm/boot/dts/nvidia/tegra20-paz00.dts |  8 ++++
>> arch/arm/mach-tegra/Makefile               |  2 -
>> arch/arm/mach-tegra/board-paz00.c          | 56 ----------------------
>> arch/arm/mach-tegra/board.h                |  2 -
>> arch/arm/mach-tegra/tegra.c                |  4 --
>> 5 files changed, 8 insertions(+), 64 deletions(-)
>> 
>> diff --git a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts 
>> b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>> index 1408e1e00759..d1093ad569e6 100644
>> --- a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>> +++ b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
>> @@ -706,6 +706,14 @@ vdd_pnl_reg: regulator-3v0 {
>> 		enable-active-high;
>> 	};
>> 
>> +	rfkill {
>> +		compatible = "rfkill-gpio";
>> +		label = "wifi_rfkill";
>> +		radio-type = "wlan";
>> +		reset-gpios = <&gpio TEGRA_GPIO(D, 1) GPIO_ACTIVE_HIGH>;
>
> I guess this can be removed, as it should trigger the LED, which is already 
> included elsewhere ....
>
>> +		shutdown-gpios = <&gpio TEGRA_GPIO(K, 5) GPIO_ACTIVE_HIGH>;
>> +	};
>> +
>> 	sound {
>> 		compatible = "nvidia,tegra-audio-alc5632-paz00",
>> 			"nvidia,tegra-audio-alc5632";
>
> I'll give it a try and report back.

rfkill (and LED) works as expected. With the reset-gpio line mentioned 
above removed, you can add my Tested-By.

Thanks!

Marc


  reply	other threads:[~2026-02-21 14:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14  0:35 Dmitry Torokhov
2026-02-14 20:43 ` Marc Dietrich
2026-02-21 14:24   ` Marc Dietrich [this message]
2026-02-23  4:57     ` Dmitry Torokhov
2026-02-28 10:25       ` Marc Dietrich
2026-03-01 20:55         ` Marc Dietrich
2026-03-01 21:56           ` Dmitry Torokhov
2026-03-07 21:13             ` Marc Dietrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07c024a6-d2f9-5805-4ae7-cbc89cda53bf@gmx.de \
    --to=marvin24@gmx.de \
    --cc=arnd@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®