From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAE3FC4338F for ; Wed, 11 Aug 2021 18:58:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0AD860560 for ; Wed, 11 Aug 2021 18:58:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231414AbhHKS7G (ORCPT ); Wed, 11 Aug 2021 14:59:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:59704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231983AbhHKS6w (ORCPT ); Wed, 11 Aug 2021 14:58:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1FFD2610A3; Wed, 11 Aug 2021 18:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628708308; bh=vdYvbtM2dGDht3rO6eGEM9yfvtq8RxVaXP3rzYQ5CAE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=tWOYCgNyiMgVvgDnqmyQVIkWrT076yCF7mKr6+NmLhiVG43Dnsi9g74L87u7y1fEs RhMCt+eiqL/Q+hcDxSs/DqxTVtRhEv1ZF9rsdMF1E5p3trb2NjTL1DnWUUKtnRiJsS UzplKrOEmK/hZXCONNGHE18LbpQ1eqoWyfvX2O82vIHf/hC5nS6VvvIzRPM+7VIVlW fomcZ9armD8piHy67WrDgxSdVBUIh7btTtUjOAA9NrYZE7E4bVpksaL0H1w6KXZGHw Wei0Vx3tNvZO0HqS5C/TpwAQ35YNv1WNCCpf8mzHLQ7IE1Qp/LflzX6bYy4MY+0Hzv 50hGcJIgaSOjQ== Subject: Re: [PATCH 07/18] ARC: ioremap: use more commonly used PAGE_KERNEL based uncached flag To: Mike Rapoport , Vineet Gupta Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual References: <20210811004258.138075-1-vgupta@kernel.org> <20210811004258.138075-8-vgupta@kernel.org> From: Vineet Gupta Message-ID: <07c12487-dc65-9d2a-71a5-65b47c98a460@kernel.org> Date: Wed, 11 Aug 2021 11:58:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/10/21 10:18 PM, Mike Rapoport wrote: >> - return ioremap_prot(paddr, size, pgprot_val(PAGE_KERNEL_NO_CACHE)); >> + return ioremap_prot(paddr, size, >> + pgprot_val(pgprot_noncached(PAGE_KERNEL))); > But this becomes _PAGE_CACHEABLE now. What did I miss? We now use pgprot_noncached() arch/arc/include/asm/pgtable.h:30:#define pgprot_noncached(prot)        (__pgprot(pgprot_val(prot) & ~_PAGE_CACHEABLE)) -Vineet