From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751957AbdKFIUl (ORCPT ); Mon, 6 Nov 2017 03:20:41 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:52411 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750737AbdKFIUj (ORCPT ); Mon, 6 Nov 2017 03:20:39 -0500 From: Fabien DESSENNE To: Colin King , Mauro Carvalho Chehab , "linux-media@vger.kernel.org" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][V2] bdisp: remove redundant assignment to pix Thread-Topic: [PATCH][V2] bdisp: remove redundant assignment to pix Thread-Index: AQHTULvu5JVWFadjeUqzg00kaiwhgqMG/f2A Date: Mon, 6 Nov 2017 08:20:32 +0000 Message-ID: <07c2fb76-3a55-77fd-ec21-cc6bb4b3e786@st.com> References: <20171029134339.7101-1-colin.king@canonical.com> In-Reply-To: <20171029134339.7101-1-colin.king@canonical.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.50] Content-Type: text/plain; charset="utf-8" Content-ID: <0D0DD301926A4442BD2522AF824A4A33@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-06_02:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vA68KjkQ004217 Hi Colin Thank you for the patch. On 29/10/17 14:43, Colin King wrote: > From: Colin Ian King > > Pointer pix is being initialized to a value and a little later > being assigned the same value again. Remove the initial assignment to > avoid a duplicate assignment. Cleans up the clang warning: > > drivers/media/platform/sti/bdisp/bdisp-v4l2.c:726:26: warning: Value > stored to 'pix' during its initialization is never read > > Signed-off-by: Colin Ian King Reviewed-by: Fabien Dessenne > --- > drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > index 939da6da7644..7e9ed9c7b3e1 100644 > --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > @@ -723,7 +723,7 @@ static int bdisp_enum_fmt(struct file *file, void *fh, struct v4l2_fmtdesc *f) > static int bdisp_g_fmt(struct file *file, void *fh, struct v4l2_format *f) > { > struct bdisp_ctx *ctx = fh_to_ctx(fh); > - struct v4l2_pix_format *pix = &f->fmt.pix; > + struct v4l2_pix_format *pix; > struct bdisp_frame *frame = ctx_get_frame(ctx, f->type); > > if (IS_ERR(frame)) {