From: neil.armstrong@linaro.org
To: Andy Yan <andyshrk@163.com>, lumag@kernel.org
Cc: cristian.ciocaltea@collabora.com, mripard@kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
heiko@sntech.de, Andy Yan <andy.yan@rock-chips.com>
Subject: Re: [PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers
Date: Mon, 14 Apr 2025 09:37:23 +0200 [thread overview]
Message-ID: <07c6f893-1e46-4f18-95be-5519f1fe9c80@linaro.org> (raw)
In-Reply-To: <20250314075754.539221-1-andyshrk@163.com>
On 14/03/2025 08:57, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> It is not recommended for drivers to include UAPI header
> directly.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 0890add5f707..306e09a24a1c 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -22,8 +22,8 @@
>
> #include <media/cec-notifier.h>
>
> -#include <uapi/linux/media-bus-format.h>
> -#include <uapi/linux/videodev2.h>
> +#include <linux/media-bus-format.h>
> +#include <linux/videodev2.h>
>
> #include <drm/bridge/dw_hdmi.h>
> #include <drm/display/drm_hdmi_helper.h>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
prev parent reply other threads:[~2025-04-14 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 7:57 Andy Yan
2025-04-03 1:49 ` Andy Yan
2025-04-10 12:51 ` [PATCH] " Heiko Stübner
2025-04-14 7:37 ` neil.armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07c6f893-1e46-4f18-95be-5519f1fe9c80@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andy.yan@rock-chips.com \
--cc=andyshrk@163.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®