From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98C5F2C11DF for ; Tue, 14 Apr 2026 08:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776156473; cv=none; b=V+C9DD3F4/ezgwRYifHwMJaBdq9LI0FvPCqaWVz0AsyJ7MV2XT8iNePcV5pgkquHrCqJf8IZm8n9jx7E9sYFsNFG+s1W4eCCJ/iPe+eH26RiJYSzH39r8KVhHyj/uOSL3ykygGZj2cg4QiqGoaIPB1i9clCecErEICr9Og0tILE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776156473; c=relaxed/simple; bh=zDuF56UTnKqUspicas9JERjPRQ1J93IdhBgV2MtRI2I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DLswDzOdA/K8VgVH5x+2MKcp/gHsGxURJww0r+u4AyaX9TfANaexVJe0HXy+ihNDLpRjMoCL9RuiXJxOMzQwM/qrUVBCZ+/S3p8T//jygVt0PL44ohSqM0zNLBaOoKt4d95dMavDTbqZWEqqosF6KeNJzkX+DToFHeEiXp83hII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cTtu98d/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SmJqZkzX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cTtu98d/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SmJqZkzX" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63E6vS6x2509957 for ; Tue, 14 Apr 2026 08:47:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FCoWpZcp6o/MguN+kiEYFFoy3eNjZ/0+2PNOiTa7XBE=; b=cTtu98d/1VuPhWHj NC9vr1vhxgbxc5Knw8RjUcY2NOpls1XUHaOLHNWSRwo3nLswKSQzT1il1I/k6bxj ehCyYZ52G/jpuNwL17d1QjctfhDg2440BR/yYB/2+i2nPVelMvppYw4f4FhZRj4L P2dcChcMoPcPKeMLN5vfj968iDLrWsfN6y0QVAFhg7QJtgSmQzpFkrBAuRSz9F54 V7yd3IGp9EvocAqygQfKmiR9UixG8pB4hRDXv2eF7heTVxZdEIsmhJUACMaLq5XI qDT0xm1MwH17Kpdgaw1yhfxanFxCuKKhb3yEDR4FWikdza+zRnlzdhf3vkAhgwuA 3Dru/A== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh867styb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 08:47:49 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8a18178713cso12200256d6.3 for ; Tue, 14 Apr 2026 01:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776156469; x=1776761269; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FCoWpZcp6o/MguN+kiEYFFoy3eNjZ/0+2PNOiTa7XBE=; b=SmJqZkzXd8tl3BxBn9Ewqplnbv8uiPh3afSS3yRowVsC6fcDHJtBiJ2hHWECtSkIK5 1PLcdVDxy+WtQRb8/6R77RAIeuuC0OVmxTaltAdRzBVjZpvuyk98ldX8dkIl0ZKNX4Uu vZf+59Uqrj2P7v0hcznqkxymH25xArZOqRWh3BcBQvXR3mIehiZPSH68Bne5/lun9LyZ X/OKV64Hr80CL8h5qCEf2aJ/qC4S2mSpFrc/O7vm/ygAsVzpZm61tGAvTfugqHwRyHly OdxMsXXpwU/9YpTCf0tq5J4UHKjnbt1AaSFJijNclOU9UrOCsW/koOa6tF2KGFQIgzkv x9Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776156469; x=1776761269; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FCoWpZcp6o/MguN+kiEYFFoy3eNjZ/0+2PNOiTa7XBE=; b=qRCnMcNW5sMfkmkachSjoe9D1Ri4ms8Y53E2WaQRmM2fhiWQLi6P8dDRhxtOMA2/r/ oGq57rTsISVYoO15oZpD1Itp9GTtSzavisbN43DzDZU40sEZ6uQ7o+UVNbLnhps2Tf0C jhJU1ZAE36UURK3r58e7n95XB1ZhRdo7Tn18c5snBZ3IsXAnrGRgM/uy9/glynKA09Ne saPdFmBYzuGtF13DlzoeEGZ9l0QHhlQ3lNAg433t2WWqJ0H1pEya8eYcO8klemeFIuS0 jclHqdB84mEHENRte2wzi53l8MlX3mmMtw5agqoyrRYj059VP3l7ATi9cvB44Xlnld+Z d6Yg== X-Forwarded-Encrypted: i=1; AFNElJ/HfH+a4Gy31ZrG7Kf0PraWmMtUjLWJXuP5AChO49Nn0PdOv6M2M/c9R2BZaGwmKzGCCgpRBwfa0f8wQic=@vger.kernel.org X-Gm-Message-State: AOJu0YyRZDLVcmgX+1MoO52sFqsfMDprmd3Ct5/XbCZH4pR+2CHzkEin HCDp3Gqb3nYLuGu0L2GpOnvoKqIGA+0XxascjJmpZKJBRmamkHWKe88tfBcbySnZwcxWEHBtQZ+ MKMsOiKTVF8ehOqFsR1+/nzoA1y4BDpZ82jZAD2yx6LcOXBfJmaOIJqeAe+MzEfNNRLkBD6ipJz Y= X-Gm-Gg: AeBDietVGokKpCIY3LrfAALR6XtRdQVQEJ+xGee4e2xQMSI3eLvbZsjDvPwlk/qX4Tb Pku6+mmNzWEYTFWUKFctYVKOSN/4HXuR8cRIgHxlkVtEcQ+RR2dErv3P0HRk/J5lTqtB8aOJ4HV vP9XPFA6ISu2NCJ1Zpabv39mQNWyJrdL1O8oe2Wxyv5HHzI6yHOfutd+fl1LrLsXuISuh7maaSB iMF86imaXgA8JYfVXrt08OvkV5ZAOCxaSFOcCxkOH4RirlK//sybQUtfjDtlB09rHYywH8jNpjO YbfSgbt1uYc5tB0dd9TX8HnMmqVUQHNsMC5Du+EYo+Lkpp+vXogalZ4lI90hP93+K5mjEdriu0N VKjs7Kd3m/UGpt9a5MxmiIAt5N4k2F1ulIQknozLzKtcraFoxxTkGn+BQCOYszHjMFxebTe6lxx TGMyUb1MVOnWH0VA== X-Received: by 2002:a05:6214:5013:b0:8ac:4fd1:2d5d with SMTP id 6a1803df08f44-8ac86297b62mr187977666d6.5.1776156468976; Tue, 14 Apr 2026 01:47:48 -0700 (PDT) X-Received: by 2002:a05:6214:5013:b0:8ac:4fd1:2d5d with SMTP id 6a1803df08f44-8ac86297b62mr187977466d6.5.1776156468530; Tue, 14 Apr 2026 01:47:48 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e7f1e87sm378834066b.61.2026.04.14.01.47.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 01:47:47 -0700 (PDT) Message-ID: <07c73c75-5ce8-46f2-bcfb-bb6d7fe0afca@oss.qualcomm.com> Date: Tue, 14 Apr 2026 10:47:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] ASoC: codecs: lpass-wsa-macro: Guard optional NPL clock rate programming To: Ajay Kumar Nandam , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@oss.qualcomm.com References: <20260413121824.375473-1-ajay.nandam@oss.qualcomm.com> <20260413121824.375473-4-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260413121824.375473-4-ajay.nandam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 448WOtpv9RV4oMa5klx25HmEEaOwNyhw X-Proofpoint-GUID: 448WOtpv9RV4oMa5klx25HmEEaOwNyhw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDA4MSBTYWx0ZWRfX7VNKyS2pljiZ qHUv+VttiKYTv+bwlIxSIfFZo43A2vpP5qcKiyYX19Usw0cRhnnBepbnZGn4z6QuJQZxDJTCSX2 RQuJryAq76ICPokIo+7Qf6IN7LpX1P79YX2T+cMdAiIUYg6/0Kepf+FhyppR/0ZnHPMbK9R0LXb THRlm8VKmZ2dx1wJBUJeJHIY5gMgZ1lq9+EH/si3vcWcJiXm3G3Gs6nlrT1CL/vfXf/4teJ3YVk RNOyOt4kX/grnTVwjf5sDh/8mknve44/Le1mJkP4kqgdm/2wyaE8+lpTnimKJSpiuqeGP4P6lfb h+riTzMnhTqnSClBOg8GmzdE5u3aixoZZ/Ln/wkP40UpGZBidGjILnYAVgRk/gSHY+I5SArQjvH ME8Yz3VN/MmeOCmtu+rcHSKFgG7bemKadCNA8wmGciBPetWmJR3m4TBx5vkl5sPwFyhdk/FMAic 94kBTGkxYSUMEAjUexA== X-Authority-Analysis: v=2.4 cv=etzvCIpX c=1 sm=1 tr=0 ts=69ddff35 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=JHmcoMBqjwvyAgHjIWMA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=zZCYzV9kfG8A:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140081 On 4/13/26 2:18 PM, Ajay Kumar Nandam wrote: > The NPL clock is only present on some platforms. When it is absent, > wsa->npl remains NULL, but the driver unconditionally programs its rate. > > Guard clk_set_rate() for the NPL clock so platforms without NPL do not > attempt to access it. > > No functional change on platforms that provide the NPL clock. > > Signed-off-by: Ajay Kumar Nandam > --- If you dig into the definition of the function.. --- drivers/clk/clk.c --- int clk_set_rate(struct clk *clk, unsigned long rate) { int ret; if (!clk) return 0; So let's drop this patch Konrad