From: Tom Lendacky <thomas.lendacky@amd.com>
To: Borislav Petkov <bp@kernel.org>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
"Borislav Petkov (AMD)" <bp@alien8.de>
Subject: Re: [PATCH] x86/sev: Rename sev_es_ghcb_handle_msr() to __vc_handle_msr()
Date: Mon, 19 Jan 2026 08:20:25 -0600 [thread overview]
Message-ID: <07c966d6-264c-44f2-b625-d140c321f5a4@amd.com> (raw)
In-Reply-To: <20260119141310.29605-1-bp@kernel.org>
On 1/19/26 08:13, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
>
> Forgot to do that during the Secure AVIC review. :-\
>
> No functional changes.
>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> arch/x86/coco/sev/core.c | 4 ++--
> arch/x86/coco/sev/internal.h | 2 +-
> arch/x86/coco/sev/vc-handle.c | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
> index 379e0c09c7f3..a059e004f61b 100644
> --- a/arch/x86/coco/sev/core.c
> +++ b/arch/x86/coco/sev/core.c
> @@ -989,7 +989,7 @@ u64 savic_ghcb_msr_read(u32 reg)
> ghcb = __sev_get_ghcb(&state);
> vc_ghcb_invalidate(ghcb);
>
> - res = sev_es_ghcb_handle_msr(ghcb, &ctxt, false);
> + res = __vc_handle_msr(ghcb, &ctxt, false);
> if (res != ES_OK) {
> pr_err("Secure AVIC MSR (0x%llx) read returned error (%d)\n", msr, res);
> /* MSR read failures are treated as fatal errors */
> @@ -1019,7 +1019,7 @@ void savic_ghcb_msr_write(u32 reg, u64 value)
> ghcb = __sev_get_ghcb(&state);
> vc_ghcb_invalidate(ghcb);
>
> - res = sev_es_ghcb_handle_msr(ghcb, &ctxt, true);
> + res = __vc_handle_msr(ghcb, &ctxt, true);
> if (res != ES_OK) {
> pr_err("Secure AVIC MSR (0x%llx) write returned error (%d)\n", msr, res);
> /* MSR writes should never fail. Any failure is fatal error for SNP guest */
> diff --git a/arch/x86/coco/sev/internal.h b/arch/x86/coco/sev/internal.h
> index 039326b5c799..b1d0c66a651a 100644
> --- a/arch/x86/coco/sev/internal.h
> +++ b/arch/x86/coco/sev/internal.h
> @@ -85,7 +85,7 @@ static __always_inline void sev_es_wr_ghcb_msr(u64 val)
> native_wrmsr(MSR_AMD64_SEV_ES_GHCB, low, high);
> }
>
> -enum es_result sev_es_ghcb_handle_msr(struct ghcb *ghcb, struct es_em_ctxt *ctxt, bool write);
> +enum es_result __vc_handle_msr(struct ghcb *ghcb, struct es_em_ctxt *ctxt, bool write);
>
> u64 get_hv_features(void);
>
> diff --git a/arch/x86/coco/sev/vc-handle.c b/arch/x86/coco/sev/vc-handle.c
> index 43f264afd590..d98b5c08ef00 100644
> --- a/arch/x86/coco/sev/vc-handle.c
> +++ b/arch/x86/coco/sev/vc-handle.c
> @@ -404,7 +404,7 @@ static enum es_result __vc_handle_secure_tsc_msrs(struct es_em_ctxt *ctxt, bool
> return ES_OK;
> }
>
> -enum es_result sev_es_ghcb_handle_msr(struct ghcb *ghcb, struct es_em_ctxt *ctxt, bool write)
> +enum es_result __vc_handle_msr(struct ghcb *ghcb, struct es_em_ctxt *ctxt, bool write)
> {
> struct pt_regs *regs = ctxt->regs;
> enum es_result ret;
> @@ -448,7 +448,7 @@ enum es_result sev_es_ghcb_handle_msr(struct ghcb *ghcb, struct es_em_ctxt *ctxt
>
> static enum es_result vc_handle_msr(struct ghcb *ghcb, struct es_em_ctxt *ctxt)
> {
> - return sev_es_ghcb_handle_msr(ghcb, ctxt, ctxt->insn.opcode.bytes[1] == 0x30);
> + return __vc_handle_msr(ghcb, ctxt, ctxt->insn.opcode.bytes[1] == 0x30);
> }
>
> static void __init vc_early_forward_exception(struct es_em_ctxt *ctxt)
next prev parent reply other threads:[~2026-01-19 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 14:13 Borislav Petkov
2026-01-19 14:20 ` Tom Lendacky [this message]
2026-01-20 10:31 ` [tip: x86/sev] " tip-bot2 for Borislav Petkov (AMD)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07c966d6-264c-44f2-b625-d140c321f5a4@amd.com \
--to=thomas.lendacky@amd.com \
--cc=bp@alien8.de \
--cc=bp@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome