From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jinlong Mao <quic_jinlmao@quicinc.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Bjorn Andersson <quic_bjorande@quicinc.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] arm64: defconfig: Enable STM protocol and source configs
Date: Tue, 17 Dec 2024 09:11:28 +0100 [thread overview]
Message-ID: <07cc40a5-8b4c-4f5c-8ecb-cbc67b916858@linaro.org> (raw)
In-Reply-To: <e7ca1f47-8ccd-44b4-bfdd-707a1f8aef13@quicinc.com>
On 17/12/2024 08:47, Jinlong Mao wrote:
>
>
> On 2024/11/1 16:45, Mao Jinlong wrote:
>> STM is used for logging useful softevens from various entities.
>> With STM and TMC sink enabled, there will be more buffer size to store
>> the logs. STM source and STM protocol need to be configured along with
>> STM device for STM function refer to Documentation/trace/stm.rst.
>> CONFIG_CORESIGHT_STM is already added as module. Add Coresight STM
>> source and Protocol configs as module so that STM functions can be
>> used.
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>> ---
>> Changes in v5:
>> - Update commit message.
>>
>> Changes in v4:
>> - Remove Ftrace config.
>>
>> Changes in v3:
>> - update commit message.
>>
>> Changes in v2:
>> - select ftrace config explicitly.
>> arch/arm64/configs/defconfig | 5 +++++
>> 1 file changed, 5 insertions(+)
>
> Gentle reminder for the review.
No need to ping for this. It's pending deliberately - on you. If you
want this to be merged, you need to funnel it through SoC maintainer's
tree. get_maintainers.pl (explained also in SoC maintainer profile).
To be clear: I do not object this patch, but I also do not see that many
benefits in having it in defconfig, thus no ack from me.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-12-17 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 8:45 Mao Jinlong
2024-12-17 7:47 ` Jinlong Mao
2024-12-17 8:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07cc40a5-8b4c-4f5c-8ecb-cbc67b916858@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®