From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AC182FB0BA for ; Tue, 9 Dec 2025 14:37:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765291026; cv=none; b=WEFwDtQQsbmohdpnjKOrRmQsqyh5UP28Af6JZnAjB14aGRhgFEHpHw4kd4RHe86SMBT1h/Nj5+0SVSoI7AU51SLQVW+6nBnU9rwdU8NrMjMqheKgUR9sro0jWrxD1lNFGj/Nr8MHbxYDKa0m2YdFbmojktrX7l2e0Z9hc2ZXGSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765291026; c=relaxed/simple; bh=78tcxydV4SBExJ6Or7LryivXekE6yAgqLILqLWTE/Ks=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=APuRoMAkplcKimm6FCEOVo/B99ppYFcsVLN84t9E/m27y9NsVYmct22vy3oyioPx94LGd8OvEb98XG8Tbj42YixyXBqsnKljTbqk72Mbs7usToVGPz/3iNL8RJXkMxfsINuGoHkjEDbwYy0vq0zgkeevL7klWNxguQyBDgz11RE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TWpRFFhr; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TWpRFFhr" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-477aa218f20so37991395e9.0 for ; Tue, 09 Dec 2025 06:37:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765291023; x=1765895823; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=boscafpzXl1otazFO1AaYpt0e5EL9yI6zjo8na+r4zU=; b=TWpRFFhr96jUhzXX09nZ/jsn769FPa2wn6irMQb/SzwV+IpbzgWxZF9g//4CyZP4/z Nk2MEMFNy8HZ/zOHWcHEHIBr4ClEGSejoI4cESzD9gK5HD0I6oyBa288H7dl8Kegifxh ffGPhahkbsyi1M64XCPXC7h6tJTDcreMPm6OIz49H84UumoRROyWYLazxFQBmAEeNyEJ xJopmMY81QkcVrGfMouk4777BgUpk+6t/yATvq0GS4Toiwy5n+hKtDU2dAe8b/FQg63S 8FosQSq3kH9TPf/OGFxHPS2bcbYkQWGT5L1xy1cTPb2styyofNrQUHquuGKDperlr9Jv 7sGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765291023; x=1765895823; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=boscafpzXl1otazFO1AaYpt0e5EL9yI6zjo8na+r4zU=; b=WHRNBk8MDb/qUSjd5OWKfEIY9k59QWPR6e+Z61p/y8WE142OEduf0XaFU4GPajO5pI 8d2YsGmdexnskYJDs7NwLEE/fSMkdKXlf4tlhxvkRL6MmQ+nmfzqUgv8oE4GnzR+cuqm 9Q0EvLtXgTtwnTivATZ0uqa5UiOEkJsNWkwz96fGigtUufbp55esh/yjjwfq2zYqZ11D SlFfS535ebjXSfeK4c6aC+WEG1aEofzZ3sitQx71cTBo3HjPEBcIn2GBPcG1PioVhHUa oqfD0zspDQMy3PiJ8Hh0xexBGGqs8kI0zoxinX1OyjUmCchecqoOeTaO5uVtFW2nexUe o3cg== X-Forwarded-Encrypted: i=1; AJvYcCV5cy4kbfq08cC6MY7jVCL9vBXGLeqr6T0Js2I3g15mTV0Hx6spv/albjmWZRDSmJt5XNReHShnsrDZNPA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5ggKHqpv6tZFrjORnzOaek6eYGUFDO4VewsdXKoFw2VtEExIk sWjFhBvk8+Wd1UKoPrsTHmrYqzYRer/uCVZFx9YnkRTZ6UBkDOxBLQYZ4sb/g4LN/aY= X-Gm-Gg: ASbGnctsOVlaURDligj4SXHXE0lxLJEvQtHlvOaYTJC3HrmDDcZZtRjq36YBFeMdgeE taRldBem+24CAWBPHtxTfgsaUMWRz/gPYb60JzbxsPGBWaKHXP1PArV4s3deCzdhd8klTTkSsV3 ixrOEvCNVEtCL11C7ovcwy18xpFb3Kmsxer+I8s0+lr2ci6sg6r9bOsm3jXk5+Xn99rI/LwmMPH YsW3br0xvr5R9EQVmK88MnMowa7PcDbK6zvV0oHptY1j9P3LsGCU8s5MNBQs//XKx0wmJIvzXto PcuZ5Mk+bAT1NvnjCWoDEsB3QOKu0KIZi5Ps2ORP2BNj8xoYRTEmLfCMOMOaZrcG19nL0Qs9li3 74FG+QobklMpXqhzR/tUA9QrKZkZuflf6+m9WOTbDXRsJFs7ZCJACeEMqbI0LjFU65OX2jZpCzj 0gG4SBw6OLwGcYQX2l X-Google-Smtp-Source: AGHT+IFkIlM0pgcGYZe4cwuAz9t38GxlP68bvmxAK/7B33cvhbSOjAmHPVhNBWnpfOQ6F52dDQtWLA== X-Received: by 2002:a05:600c:820b:b0:475:da1a:53f9 with SMTP id 5b1f17b1804b1-47939e043d3mr123647015e9.14.1765291022690; Tue, 09 Dec 2025 06:37:02 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a7d682f10sm46389215e9.0.2025.12.09.06.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 06:37:02 -0800 (PST) Date: Tue, 9 Dec 2025 17:36:59 +0300 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Borislav Petkov , Tony Luck , Aristeu Rozanski , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] EDAC/i5000: Fix snprintf() size calculation in calculate_dimm_size() Message-ID: <07cd652c51e77aad5a8350e1a7cd9407e5bbe373.1765290801.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: The snprintf() can't really overflow because we're writing a max of 42 bytes to a PAGE_SIZE buffer. But the limit calculation doesn't take the first 11 bytes that we wrote into consideration so the limit is not correct. Just fix it for correctness even though it doesn't affect runtime. Fixes: 64e1fdaf55d6 ("i5000_edac: Fix the logic that retrieves memory information") Signed-off-by: Dan Carpenter --- v2: new patch drivers/edac/i5000_edac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c index 4a1bebc1ff14..471b8540d18b 100644 --- a/drivers/edac/i5000_edac.c +++ b/drivers/edac/i5000_edac.c @@ -1111,6 +1111,7 @@ static void calculate_dimm_size(struct i5000_pvt *pvt) n = snprintf(p, space, " "); p += n; + space -= n; for (branch = 0; branch < MAX_BRANCHES; branch++) { n = snprintf(p, space, " branch %d | ", branch); p += n; -- 2.51.0