From: Oliver Neukum <oneukum@suse.com>
To: "Limonciello, Mario" <mario.limonciello@amd.com>,
Greg KH <gregkh@linuxfoundation.org>,
Michael Wu <michael@allwinnertech.com>,
Richard Gong <richard.gong@amd.com>
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: usbhid: enable remote wakeup for mice
Date: Thu, 23 Feb 2023 12:41:06 +0100 [thread overview]
Message-ID: <07d02f6c-be4b-42b0-9edf-6f691571c5e9@suse.com> (raw)
In-Reply-To: <c99a7ae3-b8ab-30e2-67bc-87b5a7736728@amd.com>
On 22.02.23 20:50, Limonciello, Mario wrote:
> Richard and I both sent out relatively similar patches in the past, but they never went anywhere.
The problem here is that the default will never satisfy a great majority. just a majority.
So if we admit that there is no optimal solution, why not pick the tested,
that is, current solution, as long as it does least?
> We did confirm that Windows does set a similar policy as well though, which is what prompted us to attempt this.
>
> As there is more interest again maybe we can revive that discussion and merge together some ideas from the sets of patches.
Well, the most obvious question, as this can also be done with a udev rule, is,
what are the risks of a change?
> Previous submissions:
>
> v4:
> https://lore.kernel.org/linux-usb/20220825045517.16791-1-mario.limonciello@amd.com/
This one at least restricts it to some cases. And as much as it pains me,
we need to ask whether there are risks in not emulating Windows.
And on the other hand, what happens if we do this. Are you sure, for example,
that you do not break use cases for S4 with this change?
If a laptop goes into S4 because power is too low, we really do not want it
to wake up just because somebody accidentally hits a mouse button.
Regards
Oliver
next prev parent reply other threads:[~2023-02-23 11:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 1:39 Michael Wu
2023-02-22 6:04 ` Greg KH
2023-02-22 19:50 ` Limonciello, Mario
2023-02-23 11:41 ` Oliver Neukum [this message]
2023-02-23 11:18 ` Michael Wu
2023-02-23 11:23 ` Greg KH
2023-02-23 12:01 ` Oliver Neukum
2023-02-23 19:41 ` Limonciello, Mario
2023-02-28 9:03 ` Oliver Neukum
2023-02-28 18:50 ` Limonciello, Mario
2023-02-28 19:05 ` Greg KH
2023-02-28 19:07 ` Limonciello, Mario
2023-02-24 7:02 ` Michael Wu
2023-02-22 8:59 ` Sergei Shtylyov
2023-02-23 4:01 ` Michael Wu
2023-02-22 9:34 ` Oliver Neukum
2023-02-23 11:22 ` Michael Wu
2023-02-23 11:47 ` Oliver Neukum
-- strict thread matches above, loose matches on Subject: below --
2011-10-14 7:54 Benson Leung
2011-10-14 8:18 ` Oliver Neukum
2011-10-14 13:56 ` Alan Stern
2011-10-14 14:00 ` Jiri Kosina
2011-10-14 14:58 ` Benson Leung
2011-10-14 15:09 ` Alan Stern
2011-10-15 9:43 ` Oliver Neukum
2011-10-15 19:07 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07d02f6c-be4b-42b0-9edf-6f691571c5e9@suse.com \
--to=oneukum@suse.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael@allwinnertech.com \
--cc=richard.gong@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®