From: Andrej Krpic <ak77@tnode.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: <linux-kernel@vger.kernel.org>, <jslaby@suse.com>,
<gregkh@linuxfoundation.org>
Subject: Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station
Date: Tue, 23 Feb 2016 00:28:32 +0000 [thread overview]
Message-ID: <07d0ae1e589f95a9aa3972407068a935@tnode.com> (raw)
In-Reply-To: <20160221234244.175a445c@lxorguk.ukuu.org.uk>
On 21.02.2016 23:42, One Thousand Gnomes wrote:
> On Sun, 21 Feb 2016 22:38:29 +0100
> Andrej Krpic <ak77@tnode.com> wrote:
>
>> When using n_gsm you have to explicitly set it to work as a
>> initiator
>> station. This led me to believe that it can also work as a
>> responder.
snip
> This looks reasonable to me. It was never intended to work as a
> responder
> but it seems clean enough to do so. Have you tested it against some
> other
> modems with these changes applied ?
It has been tested against SIM900 (SIMCom) and M66 (Quectel).
> (I'm always wary of patches to this going in without testing on
> actual
> modems, because the spec is complex and we are not the only ones with
> bugs)
While second and third patch don't change anything for initiator mode
mux,
others certainly do.
> Also can you please cc these patches to
> xinhuix.pan@intel.com
This address got rejected. Yours and LKML's didn't.
-Andrej
next prev parent reply other threads:[~2016-02-23 0:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 21:38 Andrej Krpic
2016-02-21 21:38 ` [PATCH 1/8] tty: n_gsm: fix formatting errors Andrej Krpic
2016-02-21 22:30 ` Joe Perches
2016-02-23 0:37 ` Andrej Krpic
2016-02-21 21:38 ` [PATCH 2/8] tty: n_gsm: fix C/R bit when sending as a responder Andrej Krpic
2016-02-21 21:38 ` [PATCH 3/8] tty: n_gsm: make mux work as a responder station Andrej Krpic
2016-02-21 21:38 ` [PATCH 4/8] tty: n_gsm: send DM response when accessing an invalid channel Andrej Krpic
2016-02-21 21:38 ` [PATCH 5/8] tty: n_gsm: replace dead code with a meaningful comment Andrej Krpic
2016-02-21 21:38 ` [PATCH 6/8] tty: n_gsm: add missing length field in control channel commands Andrej Krpic
2016-02-21 21:38 ` [PATCH 7/8] tty: n_gsm: properly format Modem Status Command message Andrej Krpic
2016-02-21 21:38 ` [PATCH 8/8] tty: n_gsm: Enable reception of frames separated with a single SOF marker Andrej Krpic
2016-02-21 23:42 ` [PATCH 0/8] tty: n_gsm: Make mux work as a responder station One Thousand Gnomes
2016-02-23 0:28 ` Andrej Krpic [this message]
2016-02-22 22:53 Andrej Krpic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07d0ae1e589f95a9aa3972407068a935@tnode.com \
--to=ak77@tnode.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome